mirror of
https://github.com/NodeBB/NodeBB.git
synced 2026-02-09 16:17:45 +01:00
PostgreSQL database driver (#5861)
* [test/database/list] Fix test list 4 being used in two different tests * [database/postgres] PostgreSQL database driver * [database/postgres] Make transactions work based on continuation scope. * [database/postgres] Implement nested transactions * eslint --fix * Add database changes from earlier this week to the PostgreSQL driver. * Fix typo * Fix postgres.incrObjectFieldBy returning undefined instead of null when given NaN * [database/postgres] Fix sortedSetsCard returning an array of strings. * Update socket.io postgres adapter * Fix PostgreSQL erroring when multiple updates are made to the same sorted set entry in a single operation. Add a test case to catch this error. * Fix lint errors. * Only prune sessions on one instance in a cluster to avoid deadlocks. They're caught and handled by the database server, but they spam the logs. * Fix arguments.slice.
This commit is contained in:
Ben Lubar
Julian Lam
391
src/database/postgres/hash.js
Normal file
391
src/database/postgres/hash.js
Normal file
@@ -0,0 +1,391 @@
|
||||
'use strict';
|
||||
|
||||
var async = require('async');
|
||||
|
||||
module.exports = function (db, module) {
|
||||
var helpers = module.helpers.postgres;
|
||||
|
||||
module.setObject = function (key, data, callback) {
|
||||
callback = callback || helpers.noop;
|
||||
|
||||
if (!key || !data) {
|
||||
return callback();
|
||||
}
|
||||
|
||||
if (data.hasOwnProperty('')) {
|
||||
delete data[''];
|
||||
}
|
||||
|
||||
module.transaction(function (tx, done) {
|
||||
var query = tx.client.query.bind(tx.client);
|
||||
|
||||
async.series([
|
||||
async.apply(helpers.ensureLegacyObjectType, tx.client, key, 'hash'),
|
||||
async.apply(query, {
|
||||
name: 'setObject',
|
||||
text: `
|
||||
INSERT INTO "legacy_hash" ("_key", "data")
|
||||
VALUES ($1::TEXT, $2::TEXT::JSONB)
|
||||
ON CONFLICT ("_key")
|
||||
DO UPDATE SET "data" = "legacy_hash"."data" || $2::TEXT::JSONB`,
|
||||
values: [key, JSON.stringify(data)],
|
||||
}),
|
||||
], function (err) {
|
||||
done(err);
|
||||
});
|
||||
}, callback);
|
||||
};
|
||||
|
||||
module.setObjectField = function (key, field, value, callback) {
|
||||
callback = callback || helpers.noop;
|
||||
|
||||
if (!field) {
|
||||
return callback();
|
||||
}
|
||||
|
||||
module.transaction(function (tx, done) {
|
||||
var query = tx.client.query.bind(tx.client);
|
||||
|
||||
async.series([
|
||||
async.apply(helpers.ensureLegacyObjectType, tx.client, key, 'hash'),
|
||||
async.apply(query, {
|
||||
name: 'setObjectField',
|
||||
text: `
|
||||
INSERT INTO "legacy_hash" ("_key", "data")
|
||||
VALUES ($1::TEXT, jsonb_build_object($2::TEXT, $3::TEXT::JSONB))
|
||||
ON CONFLICT ("_key")
|
||||
DO UPDATE SET "data" = jsonb_set("legacy_hash"."data", ARRAY[$2::TEXT], $3::TEXT::JSONB)`,
|
||||
values: [key, field, JSON.stringify(value)],
|
||||
}),
|
||||
], function (err) {
|
||||
done(err);
|
||||
});
|
||||
}, callback);
|
||||
};
|
||||
|
||||
module.getObject = function (key, callback) {
|
||||
if (!key) {
|
||||
return callback();
|
||||
}
|
||||
|
||||
db.query({
|
||||
name: 'getObject',
|
||||
text: `
|
||||
SELECT h."data"
|
||||
FROM "legacy_object_live" o
|
||||
INNER JOIN "legacy_hash" h
|
||||
ON o."_key" = h."_key"
|
||||
AND o."type" = h."type"
|
||||
WHERE o."_key" = $1::TEXT
|
||||
LIMIT 1`,
|
||||
values: [key],
|
||||
}, function (err, res) {
|
||||
if (err) {
|
||||
return callback(err);
|
||||
}
|
||||
|
||||
if (res.rows.length) {
|
||||
return callback(null, res.rows[0].data);
|
||||
}
|
||||
|
||||
callback(null, null);
|
||||
});
|
||||
};
|
||||
|
||||
module.getObjects = function (keys, callback) {
|
||||
if (!Array.isArray(keys) || !keys.length) {
|
||||
return callback(null, []);
|
||||
}
|
||||
|
||||
db.query({
|
||||
name: 'getObjects',
|
||||
text: `
|
||||
SELECT h."data"
|
||||
FROM UNNEST($1::TEXT[]) WITH ORDINALITY k("_key", i)
|
||||
LEFT OUTER JOIN "legacy_object_live" o
|
||||
ON o."_key" = k."_key"
|
||||
LEFT OUTER JOIN "legacy_hash" h
|
||||
ON o."_key" = h."_key"
|
||||
AND o."type" = h."type"
|
||||
ORDER BY k.i ASC`,
|
||||
values: [keys],
|
||||
}, function (err, res) {
|
||||
if (err) {
|
||||
return callback(err);
|
||||
}
|
||||
|
||||
callback(null, res.rows.map(function (row) {
|
||||
return row.data;
|
||||
}));
|
||||
});
|
||||
};
|
||||
|
||||
module.getObjectField = function (key, field, callback) {
|
||||
if (!key) {
|
||||
return callback();
|
||||
}
|
||||
|
||||
db.query({
|
||||
name: 'getObjectField',
|
||||
text: `
|
||||
SELECT h."data"->>$2::TEXT f
|
||||
FROM "legacy_object_live" o
|
||||
INNER JOIN "legacy_hash" h
|
||||
ON o."_key" = h."_key"
|
||||
AND o."type" = h."type"
|
||||
WHERE o."_key" = $1::TEXT
|
||||
LIMIT 1`,
|
||||
values: [key, field],
|
||||
}, function (err, res) {
|
||||
if (err) {
|
||||
return callback(err);
|
||||
}
|
||||
|
||||
if (res.rows.length) {
|
||||
return callback(null, res.rows[0].f);
|
||||
}
|
||||
|
||||
callback(null, null);
|
||||
});
|
||||
};
|
||||
|
||||
module.getObjectFields = function (key, fields, callback) {
|
||||
if (!key) {
|
||||
return callback();
|
||||
}
|
||||
|
||||
db.query({
|
||||
name: 'getObjectFields',
|
||||
text: `
|
||||
SELECT (SELECT jsonb_object_agg(f, d."value")
|
||||
FROM UNNEST($2::TEXT[]) f
|
||||
LEFT OUTER JOIN jsonb_each(h."data") d
|
||||
ON d."key" = f) d
|
||||
FROM "legacy_object_live" o
|
||||
INNER JOIN "legacy_hash" h
|
||||
ON o."_key" = h."_key"
|
||||
AND o."type" = h."type"
|
||||
WHERE o."_key" = $1::TEXT`,
|
||||
values: [key, fields],
|
||||
}, function (err, res) {
|
||||
if (err) {
|
||||
return callback(err);
|
||||
}
|
||||
|
||||
if (res.rows.length) {
|
||||
return callback(null, res.rows[0].d);
|
||||
}
|
||||
|
||||
var obj = {};
|
||||
fields.forEach(function (f) {
|
||||
obj[f] = null;
|
||||
});
|
||||
|
||||
callback(null, obj);
|
||||
});
|
||||
};
|
||||
|
||||
module.getObjectsFields = function (keys, fields, callback) {
|
||||
if (!Array.isArray(keys) || !keys.length) {
|
||||
return callback(null, []);
|
||||
}
|
||||
|
||||
db.query({
|
||||
name: 'getObjectsFields',
|
||||
text: `
|
||||
SELECT (SELECT jsonb_object_agg(f, d."value")
|
||||
FROM UNNEST($2::TEXT[]) f
|
||||
LEFT OUTER JOIN jsonb_each(h."data") d
|
||||
ON d."key" = f) d
|
||||
FROM UNNEST($1::text[]) WITH ORDINALITY k("_key", i)
|
||||
LEFT OUTER JOIN "legacy_object_live" o
|
||||
ON o."_key" = k."_key"
|
||||
LEFT OUTER JOIN "legacy_hash" h
|
||||
ON o."_key" = h."_key"
|
||||
AND o."type" = h."type"
|
||||
ORDER BY k.i ASC`,
|
||||
values: [keys, fields],
|
||||
}, function (err, res) {
|
||||
if (err) {
|
||||
return callback(err);
|
||||
}
|
||||
|
||||
callback(null, res.rows.map(function (row) {
|
||||
return row.d;
|
||||
}));
|
||||
});
|
||||
};
|
||||
|
||||
module.getObjectKeys = function (key, callback) {
|
||||
if (!key) {
|
||||
return callback();
|
||||
}
|
||||
|
||||
db.query({
|
||||
name: 'getObjectKeys',
|
||||
text: `
|
||||
SELECT ARRAY(SELECT jsonb_object_keys(h."data")) k
|
||||
FROM "legacy_object_live" o
|
||||
INNER JOIN "legacy_hash" h
|
||||
ON o."_key" = h."_key"
|
||||
AND o."type" = h."type"
|
||||
WHERE o."_key" = $1::TEXT
|
||||
LIMIT 1`,
|
||||
values: [key],
|
||||
}, function (err, res) {
|
||||
if (err) {
|
||||
return callback(err);
|
||||
}
|
||||
|
||||
if (res.rows.length) {
|
||||
return callback(null, res.rows[0].k);
|
||||
}
|
||||
|
||||
callback(null, []);
|
||||
});
|
||||
};
|
||||
|
||||
module.getObjectValues = function (key, callback) {
|
||||
module.getObject(key, function (err, data) {
|
||||
if (err) {
|
||||
return callback(err);
|
||||
}
|
||||
|
||||
var values = [];
|
||||
|
||||
if (data) {
|
||||
for (var key in data) {
|
||||
if (data.hasOwnProperty(key)) {
|
||||
values.push(data[key]);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
callback(null, values);
|
||||
});
|
||||
};
|
||||
|
||||
module.isObjectField = function (key, field, callback) {
|
||||
if (!key) {
|
||||
return callback();
|
||||
}
|
||||
|
||||
db.query({
|
||||
name: 'isObjectField',
|
||||
text: `
|
||||
SELECT (h."data" ? $2::TEXT AND h."data"->>$2::TEXT IS NOT NULL) b
|
||||
FROM "legacy_object_live" o
|
||||
INNER JOIN "legacy_hash" h
|
||||
ON o."_key" = h."_key"
|
||||
AND o."type" = h."type"
|
||||
WHERE o."_key" = $1::TEXT
|
||||
LIMIT 1`,
|
||||
values: [key, field],
|
||||
}, function (err, res) {
|
||||
if (err) {
|
||||
return callback(err);
|
||||
}
|
||||
|
||||
if (res.rows.length) {
|
||||
return callback(null, res.rows[0].b);
|
||||
}
|
||||
|
||||
callback(null, false);
|
||||
});
|
||||
};
|
||||
|
||||
module.isObjectFields = function (key, fields, callback) {
|
||||
if (!key) {
|
||||
return callback();
|
||||
}
|
||||
|
||||
module.getObjectFields(key, fields, function (err, data) {
|
||||
if (err) {
|
||||
return callback(err);
|
||||
}
|
||||
|
||||
if (!data) {
|
||||
return callback(null, fields.map(function () {
|
||||
return false;
|
||||
}));
|
||||
}
|
||||
|
||||
callback(null, fields.map(function (field) {
|
||||
return data.hasOwnProperty(field) && data[field] !== null;
|
||||
}));
|
||||
});
|
||||
};
|
||||
|
||||
module.deleteObjectField = function (key, field, callback) {
|
||||
module.deleteObjectFields(key, [field], callback);
|
||||
};
|
||||
|
||||
module.deleteObjectFields = function (key, fields, callback) {
|
||||
callback = callback || helpers.noop;
|
||||
if (!key || !Array.isArray(fields) || !fields.length) {
|
||||
return callback();
|
||||
}
|
||||
|
||||
db.query({
|
||||
name: 'deleteObjectFields',
|
||||
text: `
|
||||
UPDATE "legacy_hash"
|
||||
SET "data" = COALESCE((SELECT jsonb_object_agg("key", "value")
|
||||
FROM jsonb_each("data")
|
||||
WHERE "key" <> ALL ($2::TEXT[])), '{}')
|
||||
WHERE "_key" = $1::TEXT`,
|
||||
values: [key, fields],
|
||||
}, function (err) {
|
||||
callback(err);
|
||||
});
|
||||
};
|
||||
|
||||
module.incrObjectField = function (key, field, callback) {
|
||||
module.incrObjectFieldBy(key, field, 1, callback);
|
||||
};
|
||||
|
||||
module.decrObjectField = function (key, field, callback) {
|
||||
module.incrObjectFieldBy(key, field, -1, callback);
|
||||
};
|
||||
|
||||
module.incrObjectFieldBy = function (key, field, value, callback) {
|
||||
callback = callback || helpers.noop;
|
||||
value = parseInt(value, 10);
|
||||
|
||||
if (!key || isNaN(value)) {
|
||||
return callback(null, null);
|
||||
}
|
||||
|
||||
module.transaction(function (tx, done) {
|
||||
var query = tx.client.query.bind(tx.client);
|
||||
|
||||
async.waterfall([
|
||||
async.apply(Array.isArray(key) ? helpers.ensureLegacyObjectsType : helpers.ensureLegacyObjectType, tx.client, key, 'hash'),
|
||||
async.apply(query, Array.isArray(key) ? {
|
||||
name: 'incrObjectFieldByMulti',
|
||||
text: `
|
||||
INSERT INTO "legacy_hash" ("_key", "data")
|
||||
SELECT UNNEST($1::TEXT[]), jsonb_build_object($2::TEXT, $3::NUMERIC)
|
||||
ON CONFLICT ("_key")
|
||||
DO UPDATE SET "data" = jsonb_set("legacy_hash"."data", ARRAY[$2::TEXT], to_jsonb(COALESCE(("legacy_hash"."data"->>$2::TEXT)::NUMERIC, 0) + $3::NUMERIC))
|
||||
RETURNING ("data"->>$2::TEXT)::NUMERIC v`,
|
||||
values: [key, field, value],
|
||||
} : {
|
||||
name: 'incrObjectFieldBy',
|
||||
text: `
|
||||
INSERT INTO "legacy_hash" ("_key", "data")
|
||||
VALUES ($1::TEXT, jsonb_build_object($2::TEXT, $3::NUMERIC))
|
||||
ON CONFLICT ("_key")
|
||||
DO UPDATE SET "data" = jsonb_set("legacy_hash"."data", ARRAY[$2::TEXT], to_jsonb(COALESCE(("legacy_hash"."data"->>$2::TEXT)::NUMERIC, 0) + $3::NUMERIC))
|
||||
RETURNING ("data"->>$2::TEXT)::NUMERIC v`,
|
||||
values: [key, field, value],
|
||||
}),
|
||||
function (res, next) {
|
||||
next(null, Array.isArray(key) ? res.rows.map(function (r) {
|
||||
return parseFloat(r.v);
|
||||
}) : parseFloat(res.rows[0].v));
|
||||
},
|
||||
], done);
|
||||
}, callback);
|
||||
};
|
||||
};
|
||||
Reference in New Issue
Block a user