Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-09-06 04:59:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

Object cache refactor (#7558)

Browse Source 
* fix: cache refactor

db.getObjectField no longer loads entire object
db.getObjectsFields only clones data once
more tests

* feat: add back cache to redis

db.getObjectField no longer loads entire object
This commit is contained in:
Barış Soner Uşaklı
2019-04-24 14:38:46 -04:00
committed by GitHub
parent e81a1dbb65
commit 2c98dd5f9d
5 changed files with 180 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

111
src/database/mongo/hash.js
View File

@@ -39,31 +39,70 @@ module.exports = function (db, module) {
module.getObject = function (key, callback) {
if (!key) {
return callback();
return setImmediate(callback, null, null);
}
module.getObjects([key], function (err, data) {
if (err) {
return callback(err);
}
callback(null, data && data.length ? data[0] : null);
callback(err, data && data.length ? data[0] : null);
});
};
module.getObjects = function (keys, callback) {
var cachedData = {};
function getFromCache() {
process.nextTick(callback, null, keys.map(key => _.clone(cachedData[key])));
}
module.getObjectsFields(keys, [], callback);
};
module.getObjectField = function (key, field, callback) {
if (!key) {
return setImmediate(callback, null, null);
}
const cachedData = {};
cache.getUnCachedKeys([key], cachedData);
if (cachedData[key]) {
return setImmediate(callback, null, cachedData[key].hasOwnProperty(field) ? cachedData[key][field] : null);
}
field = helpers.fieldToString(field);
db.collection('objects').findOne({ _key: key }, { projection: { _id: 0, [field]: 1 } }, function (err, item) {
if (err || !item) {
return callback(err, null);
}
callback(null, item.hasOwnProperty(field) ? item[field] : null);
});
};
module.getObjectFields = function (key, fields, callback) {
if (!key) {
return setImmediate(callback, null, null);
}
module.getObjectsFields([key], fields, function (err, data) {
callback(err, data ? data[0] : null);
});
};
module.getObjectsFields = function (keys, fields, callback) {
if (!Array.isArray(keys) || !keys.length) {
return callback(null, []);
return setImmediate(callback, null, []);
}
const cachedData = {};
function returnData() {
var mapped = keys.map(function (key) {
if (!fields.length) {
return _.clone(cachedData[key]);
}
const item = cachedData[key] || {};
const result = {};
fields.forEach((field) => {
result[field] = item[field] !== undefined ? item[field] : null;
});
return result;
});
callback(null, mapped);
}
const unCachedKeys = cache.getUnCachedKeys(keys, cachedData);
if (!unCachedKeys.length) {
return getFromCache();
return process.nextTick(returnData);
}
var query = { _key: { $in: unCachedKeys } };
@@ -81,53 +120,7 @@ module.exports = function (db, module) {
cache.set(key, cachedData[key]);
});
getFromCache();
});
};
module.getObjectField = function (key, field, callback) {
if (!key) {
return callback();
}
module.getObject(key, function (err, item) {
if (err || !item) {
return callback(err, null);
}
callback(null, item.hasOwnProperty(field) ? item[field] : null);
});
};
module.getObjectFields = function (key, fields, callback) {
if (!key) {
return callback();
}
module.getObjectsFields([key], fields, function (err, data) {
callback(err, data ? data[0] : null);
});
};
module.getObjectsFields = function (keys, fields, callback) {
if (!Array.isArray(keys) || !keys.length) {
return callback(null, []);
}
module.getObjects(keys, function (err, items) {
if (err) {
return callback(err);
}
if (items === null) {
items = [];
}
const returnData = items.map((item) => {
item = item || {};
const result = {};
fields.forEach((field) => {
result[field] = item[field] !== undefined ? item[field] : null;
});
return result;
});
callback(null, returnData);
returnData();
});
};