diff --git a/public/src/admin/settings/general.js b/public/src/admin/settings/general.js index 65f1f0bce4..019cbcdeca 100644 --- a/public/src/admin/settings/general.js +++ b/public/src/admin/settings/general.js @@ -18,7 +18,7 @@ define('admin/settings/general', ['admin/settings'], function () { $('input[data-field="brand:maskableIcon"]').val(''); }); $('button[data-action="removeOgImage"]').on('click', function () { - $('input[data-field="removeOgImage"]').val(''); + $('input[data-field="og:image"]').val(''); }); $('[data-field="homePageRoute"]').on('change', toggleCustomRoute); diff --git a/public/src/modules/api.js b/public/src/modules/api.js index bfda975662..db8e0fb1b0 100644 --- a/public/src/modules/api.js +++ b/public/src/modules/api.js @@ -69,18 +69,23 @@ async function xhr(options, cb) { const isJSON = contentType && contentType.startsWith('application/json'); let response; - if (isJSON) { - response = await res.json(); - } else { - response = await res.text(); + if (options.method !== 'head') { + if (isJSON) { + response = await res.json(); + } else { + response = await res.text(); + } } if (!res.ok) { - return cb(new Error(isJSON ? response.status.message : response)); + if (response) { + return cb(new Error(isJSON ? response.status.message : response)); + } + return cb(new Error(res.statusText)); } cb(null, ( - isJSON && response.hasOwnProperty('status') && response.hasOwnProperty('response') ? + isJSON && response && response.hasOwnProperty('status') && response.hasOwnProperty('response') ? response.response : response ));