From 260ac5f4275c14dbedbecdbfe474e7202588be97 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Fri, 30 Sep 2022 23:01:14 -0400
Subject: [PATCH] refactor: use avatar helper

fix empty dropdown when searching
---
 public/src/client/chats/search.js | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/public/src/client/chats/search.js b/public/src/client/chats/search.js
index 7a991f9c31..d5e7632793 100644
--- a/public/src/client/chats/search.js
+++ b/public/src/client/chats/search.js
@@ -1,7 +1,9 @@
 'use strict';
 
 
-define('forum/chats/search', ['components', 'api', 'alerts'], function (components, api, alerts) {
+define('forum/chats/search', [
+	'components', 'api', 'alerts', 'helpers',
+], function (components, api, alerts, helpers) {
 	const search = {};
 
 	search.init = function () {
@@ -11,7 +13,7 @@ define('forum/chats/search', ['components', 'api', 'alerts'], function (componen
 	function doSearch() {
 		const username = components.get('chat/search').val();
 		if (!username) {
-			return $('[component="chat/search/list"]').empty();
+			return $('[component="chat/search/list"]').translateHtml('<li><a href="#" class="dropdown-item">[[admin/menu:search.start-typing]]</a></li>');
 		}
 
 		api.get('/api/users', {
@@ -31,7 +33,7 @@ define('forum/chats/search', ['components', 'api', 'alerts'], function (componen
 		});
 
 		if (!data.users.length) {
-			return chatsListEl.translateHtml('<li><div><span>[[users:no-users-found]]</span></div></li>');
+			return chatsListEl.translateHtml('<li><a href="#" class="dropdown-item">[[users:no-users-found]]</a></li>');
 		}
 
 		data.users.forEach(function (userObj) {
@@ -44,10 +46,8 @@ define('forum/chats/search', ['components', 'api', 'alerts'], function (componen
 
 	function displayUser(chatsListEl, userObj) {
 		function createUserImage() {
-			return (userObj.picture ?
-				'<img src="' + userObj.picture + '" title="' + userObj.username + '" />' :
-				'<div class="user-icon" style="background-color: ' + userObj['icon:bgColor'] + '">' + userObj['icon:text'] + '</div>') +
-				'<i class="fa fa-circle status ' + userObj.status + '"></i> ' + userObj.username;
+			const img = helpers.buildAvatar(userObj, '24px', true);
+			return `<a href="#" class="dropdown-item">${img} ${userObj.username}<a>`;
 		}
 
 		const chatEl = $('<li component="chat/search/user"></li>')