From 220af7068a6aa740493cb99b6a4fcd01a8053f27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Sat, 7 Sep 2024 21:31:08 -0400 Subject: [PATCH 1/2] fix: closes #12780, 404 in api/v3 if topic doesn't exist --- src/controllers/write/topics.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/controllers/write/topics.js b/src/controllers/write/topics.js index b9691a8da5..798cac34c7 100644 --- a/src/controllers/write/topics.js +++ b/src/controllers/write/topics.js @@ -11,7 +11,11 @@ const uploadsController = require('../uploads'); const Topics = module.exports; Topics.get = async (req, res) => { - helpers.formatApiResponse(200, res, await api.topics.get(req, req.params)); + const topicData = await api.topics.get(req, req.params); + if (!topicData) { + return helpers.formatApiResponse(404, res, new Error('[[error:no-topic]]')); + } + helpers.formatApiResponse(200, res, topicData); }; Topics.create = async (req, res) => { From a6a995538c6f5e415a1c170796e35d52aa17760c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Sat, 7 Sep 2024 22:51:01 -0400 Subject: [PATCH 2/2] chore: up widgets --- install/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install/package.json b/install/package.json index e77437aa1b..a24d93217b 100644 --- a/install/package.json +++ b/install/package.json @@ -108,7 +108,7 @@ "nodebb-theme-lavender": "7.1.8", "nodebb-theme-peace": "2.2.6", "nodebb-theme-persona": "13.3.25", - "nodebb-widget-essentials": "7.0.21", + "nodebb-widget-essentials": "7.0.24", "nodemailer": "6.9.13", "nprogress": "0.2.0", "passport": "0.7.0",