From 1ca9994f43ad4cf23bbdcb827b3430274d972fcb Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Thu, 29 Feb 2024 00:06:59 -0500
Subject: [PATCH] fix: properly handle if mainPid is not a number

---
 src/activitypub/notes.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/activitypub/notes.js b/src/activitypub/notes.js
index 57a853347c..f3cf0220d3 100644
--- a/src/activitypub/notes.js
+++ b/src/activitypub/notes.js
@@ -226,6 +226,7 @@ Notes.assertTopic = async (uid, id) => {
 			title = `${title.slice(0, meta.config.maximumTitleLength)}...`;
 		}
 	}
+	mainPid = utils.isNumber(mainPid) ? parseInt(mainPid, 10) : mainPid;
 
 	// Privilege check for local categories
 	const privilege = `topics:${tid ? 'reply' : 'create'}`;
@@ -245,8 +246,8 @@ Notes.assertTopic = async (uid, id) => {
 	];
 
 	// mainPid doesn't belong in posts zset
-	if (ids.includes(parseInt(mainPid, 10))) {
-		const idx = ids.indexOf(parseInt(mainPid, 10));
+	if (ids.includes(mainPid)) {
+		const idx = ids.indexOf(mainPid);
 		ids.splice(idx, 1);
 		timestamps.splice(idx, 1);
 	}