Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-03-11 23:20:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

test: return empty array on db.exists([]);

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2024-06-07 21:44:57 -04:00
parent 70b4a0e2ae
commit 1b283ccc29
4 changed files with 52 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
src/database/postgres/main.js
View File

@@ -16,38 +16,59 @@ module.exports = function (module) {
if (!key) {
return;
}
// Redis/Mongo consider empty zsets as non-existent, match that behaviour
const type = await module.type(key);
if (type === 'zset') {
if (Array.isArray(key)) {
const members = await Promise.all(key.map(key => module.getSortedSetRange(key, 0, 0)));
return members.map(member => member.length > 0);
}
const members = await module.getSortedSetRange(key, 0, 0);
return members.length > 0;
const isArray = Array.isArray(key);
if (isArray && !key.length) {
return [];
}
if (Array.isArray(key)) {
async function checkIfzSetsExist(keys) {
const members = await Promise.all(
keys.map(key => module.getSortedSetRange(key, 0, 0))
);
return members.map(member => member.length > 0);
}
async function checkIfKeysExist(keys) {
const res = await module.pool.query({
name: 'existsArray',
text: `
SELECT o."_key" k
FROM "legacy_object_live" o
WHERE o."_key" = ANY($1::TEXT[])`,
values: [key],
values: [keys],
});
return key.map(k => res.rows.some(r => r.k === k));
return keys.map(k => res.rows.some(r => r.k === k));
}
// Redis/Mongo consider empty zsets as non-existent, match that behaviour
if (isArray) {
const types = await Promise.all(key.map(module.type));
const zsetKeys = key.filter((_key, i) => types[i] === 'zset');
const otherKeys = key.filter((_key, i) => types[i] !== 'zset');
const [zsetExits, otherExists] = await Promise.all([
checkIfzSetsExist(zsetKeys),
checkIfKeysExist(otherKeys),
]);
const existsMap = Object.create(null);
zsetKeys.forEach((k, i) => { existsMap[k] = zsetExits[i]; });
otherKeys.forEach((k, i) => { existsMap[k] = otherExists[i]; });
return key.map(k => existsMap[k]);
}
const type = await module.type(key);
if (type === 'zset') {
const members = await module.getSortedSetRange(key, 0, 0);
return members.length > 0;
}
const res = await module.pool.query({
name: 'exists',
text: `
SELECT EXISTS(SELECT *
FROM "legacy_object_live"
WHERE "_key" = $1::TEXT
LIMIT 1) e`,
WHERE "_key" = $1::TEXT
LIMIT 1) e`,
values: [key],
});
return res.rows[0].e;
};