Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-03-03 11:01:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: guard against incomplete objects when building context/chain

Browse Source
This commit is contained in:
Julian Lam
2026-02-06 14:45:23 -05:00
parent 725107347b
commit 13422bc822
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/activitypub/contexts.js
View File

@@ -124,7 +124,7 @@ async function parseString(uid, item) {
const { type, id } = await activitypub.helpers.resolveLocalId(item); const { type, id } = await activitypub.helpers.resolveLocalId(item);
const pid = type === 'post' && id ? id : item; const pid = type === 'post' && id ? id : item;
const postData = await posts.getPostData(pid); const postData = await posts.getPostData(pid);
if (postData) { if (postData && postData.pid) {
// Already cached // Already cached
return postData; return postData;
} }
@@ -157,7 +157,7 @@ async function parseItem(uid, item) {
const { type, id } = await activitypub.helpers.resolveLocalId(item.id); const { type, id } = await activitypub.helpers.resolveLocalId(item.id);
const pid = type === 'post' && id ? id : item.id; const pid = type === 'post' && id ? id : item.id;
const postData = await posts.getPostData(pid); const postData = await posts.getPostData(pid);
if (postData) { if (postData && postData.pid) {
// Already cached // Already cached
return postData; return postData;
} }

2
src/activitypub/notes.js
View File

@@ -536,7 +536,7 @@ Notes.getParentChain = async (uid, input) => {
} }
const postData = await posts.getPostData(id); const postData = await posts.getPostData(id);
if (postData) { if (postData && postData.pid) {
chain.add(postData); chain.add(postData);
if (postData.toPid) { if (postData.toPid) {
await traverse(uid, postData.toPid); await traverse(uid, postData.toPid);