From 13210a91e6428cbda12a89797904347f73f04cb6 Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Wed, 16 Mar 2016 10:45:41 -0400 Subject: [PATCH] Fixed case where plugin upgrade checker crashed ... if no extraneous plugins were installed. Hooray for not testing the null case! --- nodebb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/nodebb b/nodebb index 5f6f2a77c5..2c1a722d0a 100755 --- a/nodebb +++ b/nodebb @@ -118,8 +118,11 @@ var getRunningPid = function(callback) { version: async.apply(getCurrentVersion) }), function(payload, next) { - var toCheck = Object.keys(payload.plugins); + if (!payload.plugins.length) { + return next(null, []); // no extraneous plugins installed + } + var toCheck = Object.keys(payload.plugins); request({ method: 'GET', url: 'https://packages.nodebb.org/api/v1/suggest?version=' + payload.version + '&package[]=' + toCheck.join('&package[]='),