From a74ccad28299d142a7f597996c692fd24f74498d Mon Sep 17 00:00:00 2001 From: Andy Miller Date: Wed, 6 Nov 2019 17:50:35 -0700 Subject: [PATCH 1/3] fixed changelog date --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 60933af6c..13a82d36b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,5 @@ # v1.6.17 -## 10/06/2019 +## 11/06/2019 1. [](#new) * Added working ETag (304 Not Modified) support based on the final rendered HTML From fcc0c5e34509b7b081a76bd64b50d451e09cb403 Mon Sep 17 00:00:00 2001 From: Xaver Maierhofer Date: Sun, 10 Nov 2019 04:49:33 +0100 Subject: [PATCH 2/3] Correct download argument annotation (#2727) --- system/src/Grav/Console/Gpm/SelfupgradeCommand.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/src/Grav/Console/Gpm/SelfupgradeCommand.php b/system/src/Grav/Console/Gpm/SelfupgradeCommand.php index 1562f4b66..62c6120ce 100644 --- a/system/src/Grav/Console/Gpm/SelfupgradeCommand.php +++ b/system/src/Grav/Console/Gpm/SelfupgradeCommand.php @@ -177,7 +177,7 @@ class SelfupgradeCommand extends ConsoleCommand } /** - * @param Package $package + * @param array $package * * @return string */ From f59441eb5529732b55fdce1982cdd8a639f649ac Mon Sep 17 00:00:00 2001 From: Matias Griese Date: Thu, 14 Nov 2019 12:21:28 +0200 Subject: [PATCH 3/3] Fixed fatal error when `$page->id()` is null [#2731] --- CHANGELOG.md | 7 +++++++ system/src/Grav/Common/Page/Page.php | 8 ++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 13a82d36b..c079ed792 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,10 @@ +# v1.6.18 +## mm/dd/2019 + +1. [](#bugfix) + * Fixed fatal error when `$page->id()` is null [#2731](https://github.com/getgrav/grav/pull/2731) + * Fixed cache conflicts on pages with no set id + # v1.6.17 ## 11/06/2019 diff --git a/system/src/Grav/Common/Page/Page.php b/system/src/Grav/Common/Page/Page.php index ea10cd47b..a138a04bd 100644 --- a/system/src/Grav/Common/Page/Page.php +++ b/system/src/Grav/Common/Page/Page.php @@ -659,7 +659,7 @@ class Page implements PageInterface // Load cached content /** @var Cache $cache */ $cache = Grav::instance()['cache']; - $cache_id = md5('page' . $this->id()); + $cache_id = md5('page' . $this->getCacheKey()); $content_obj = $cache->fetch($cache_id); if (is_array($content_obj)) { @@ -865,7 +865,7 @@ class Page implements PageInterface public function cachePageContent() { $cache = Grav::instance()['cache']; - $cache_id = md5('page' . $this->id()); + $cache_id = md5('page' . $this->getCacheKey()); $cache->save($cache_id, ['content' => $this->content, 'content_meta' => $this->content_meta]); } @@ -2009,6 +2009,10 @@ class Page implements PageInterface */ public function id($var = null) { + if (null === $this->id) { + // We need to set unique id to avoid potential cache conflicts between pages. + $var = time() . md5($this->filePath()); + } if ($var !== null) { // store unique per language $active_lang = Grav::instance()['language']->getLanguage() ?: '';