From d67da7bed6e4d53bb369b15ae864fcd2ea0d2c5a Mon Sep 17 00:00:00 2001 From: Flavio Copes Date: Fri, 19 Feb 2016 11:21:29 +0100 Subject: [PATCH] Check version only if needed --- system/src/Grav/Console/Gpm/InstallCommand.php | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/system/src/Grav/Console/Gpm/InstallCommand.php b/system/src/Grav/Console/Gpm/InstallCommand.php index 18834d027..5e172f70f 100644 --- a/system/src/Grav/Console/Gpm/InstallCommand.php +++ b/system/src/Grav/Console/Gpm/InstallCommand.php @@ -222,16 +222,13 @@ class InstallCommand extends ConsoleCommand $dependencies = $this->calculateMergedDependenciesOfPackages($packages); foreach ($dependencies as $dependencySlug => $dependencyVersion) { - - $dependencyVersion = $this->calculateVersionNumberFromDependencyVersion($dependencyVersion); - if ($this->gpm->isPluginInstalled($dependencySlug)) { + $dependencyVersion = $this->calculateVersionNumberFromDependencyVersion($dependencyVersion); // check the version, if an update is not strictly required mark as 'ignore' $locator = self::getGrav()['locator']; $blueprints_path = $locator->findResource('plugins://' . $dependencySlug . DS . 'blueprints.yaml'); $package_yaml = Yaml::parse(file_get_contents($blueprints_path)); - $currentlyInstalledVersion = $package_yaml['version']; //if I already have the latest release, remove the dependency @@ -245,14 +242,12 @@ class InstallCommand extends ConsoleCommand if (version_compare($currentlyInstalledVersion, $dependencyVersion) == -1) { $dependencies[$dependencySlug] = 'update'; } else { - if ($currentlyInstalledVersion == $latestRelease) { unset($dependencies[$dependencySlug]); } else { $dependencies[$dependencySlug] = 'ignore'; } } - } else { $dependencies[$dependencySlug] = 'install'; }