From 651b354d3eaf1a69abb0080d004e50160b01bb4d Mon Sep 17 00:00:00 2001 From: Newb I the Newbd Date: Sat, 14 Sep 2019 18:10:24 +0200 Subject: [PATCH 1/4] Correct non-published collection filter evaluation (#2668) --- system/src/Grav/Common/Page/Page.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/src/Grav/Common/Page/Page.php b/system/src/Grav/Common/Page/Page.php index 6da3bbaed..173035981 100644 --- a/system/src/Grav/Common/Page/Page.php +++ b/system/src/Grav/Common/Page/Page.php @@ -2855,9 +2855,9 @@ class Page implements PageInterface $result = []; foreach ((array)$value as $key => $val) { if (is_int($key)) { - $result = $result + $this->evaluate($val)->toArray(); + $result = $result + $this->evaluate($val, $only_published)->toArray(); } else { - $result = $result + $this->evaluate([$key => $val])->toArray(); + $result = $result + $this->evaluate([$key => $val], $only_published)->toArray(); } } From e30ab9a043ab916083e5d7f65193fc408e337534 Mon Sep 17 00:00:00 2001 From: Matias Griese Date: Tue, 17 Sep 2019 11:37:09 +0300 Subject: [PATCH 2/4] Fixed Flex user creation if file storage is being used [#2444] --- CHANGELOG.md | 6 ++++++ system/src/Grav/Common/User/FlexUser/User.php | 10 ++++++++++ 2 files changed, 16 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a416b5029..6c7773c02 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +# v1.6.16 +## mm/dd/2019 + +1. [](#bugfix) + * Fixed Flex user creation if file storage is being used [#2444](https://github.com/getgrav/grav/issues/2444) + # v1.6.15 ## 08/20/2019 diff --git a/system/src/Grav/Common/User/FlexUser/User.php b/system/src/Grav/Common/User/FlexUser/User.php index e95992aae..0d83c5173 100644 --- a/system/src/Grav/Common/User/FlexUser/User.php +++ b/system/src/Grav/Common/User/FlexUser/User.php @@ -22,6 +22,7 @@ use Grav\Framework\File\Formatter\JsonFormatter; use Grav\Framework\File\Formatter\YamlFormatter; use Grav\Framework\Flex\FlexDirectory; use Grav\Framework\Flex\FlexObject; +use Grav\Framework\Flex\Storage\FileStorage; use Grav\Framework\Flex\Traits\FlexAuthorizeTrait; use Grav\Framework\Flex\Traits\FlexMediaTrait; use Grav\Framework\Form\FormFlashFile; @@ -446,6 +447,15 @@ class User extends FlexObject implements UserInterface, MediaManipulationInterfa */ public function save() { + // TODO: We may want to handle this in the storage layer in the future. + $key = $this->getStorageKey(); + if (!$key || strpos($key, '@@')) { + $storage = $this->getFlexDirectory()->getStorage(); + if ($storage instanceof FileStorage) { + $this->setStorageKey($this->getKey()); + } + } + $password = $this->getProperty('password'); if (null !== $password) { $this->unsetProperty('password'); From 5c9eb1cdb86b6186cf575a7eed7ccd78ae0a4f45 Mon Sep 17 00:00:00 2001 From: Matias Griese Date: Tue, 17 Sep 2019 22:02:21 +0300 Subject: [PATCH 3/4] Fixed `Badly encoded JSON data` warning when uploading files [#2663] --- CHANGELOG.md | 1 + system/src/Grav/Framework/Form/Traits/FormTrait.php | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6c7773c02..4bd867fd5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ 1. [](#bugfix) * Fixed Flex user creation if file storage is being used [#2444](https://github.com/getgrav/grav/issues/2444) + * Fixed `Badly encoded JSON data` warning when uploading files [#2663](https://github.com/getgrav/grav/issues/2663) # v1.6.15 ## 08/20/2019 diff --git a/system/src/Grav/Framework/Form/Traits/FormTrait.php b/system/src/Grav/Framework/Form/Traits/FormTrait.php index 31c4ff920..d47504817 100644 --- a/system/src/Grav/Framework/Form/Traits/FormTrait.php +++ b/system/src/Grav/Framework/Form/Traits/FormTrait.php @@ -640,7 +640,7 @@ trait FormTrait foreach ($data as $key => &$value) { if (\is_array($value)) { $value = $this->jsonDecode($value); - } elseif ($value === '') { + } elseif (trim($value) === '') { unset($data[$key]); } else { $value = json_decode($value, true); From dffb227df6d3bbc3275f49cc827839925c9b17a4 Mon Sep 17 00:00:00 2001 From: Andy Miller Date: Thu, 19 Sep 2019 16:42:21 -0600 Subject: [PATCH 4/4] prepare for release --- CHANGELOG.md | 2 +- system/defines.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4bd867fd5..ea3d60488 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,5 @@ # v1.6.16 -## mm/dd/2019 +## 09/19/2019 1. [](#bugfix) * Fixed Flex user creation if file storage is being used [#2444](https://github.com/getgrav/grav/issues/2444) diff --git a/system/defines.php b/system/defines.php index bee2c1caf..85d88d8f7 100644 --- a/system/defines.php +++ b/system/defines.php @@ -8,7 +8,7 @@ // Some standard defines define('GRAV', true); -define('GRAV_VERSION', '1.6.15'); +define('GRAV_VERSION', '1.6.16'); define('GRAV_TESTING', false); define('DS', '/');