From 0d0bb2c2297fb96d8ee1a2a28a999e15828d296e Mon Sep 17 00:00:00 2001 From: Matias Griese Date: Wed, 21 Aug 2019 12:28:05 +0300 Subject: [PATCH] Better follow protected Object Property interfaces in traits --- .../Grav/Framework/Object/Property/LazyPropertyTrait.php | 6 ------ .../Grav/Framework/Object/Property/MixedPropertyTrait.php | 6 ------ 2 files changed, 12 deletions(-) diff --git a/system/src/Grav/Framework/Object/Property/LazyPropertyTrait.php b/system/src/Grav/Framework/Object/Property/LazyPropertyTrait.php index 1066b9933..59aa9030b 100644 --- a/system/src/Grav/Framework/Object/Property/LazyPropertyTrait.php +++ b/system/src/Grav/Framework/Object/Property/LazyPropertyTrait.php @@ -69,7 +69,6 @@ trait LazyPropertyTrait /** * @param string $property Object property to be updated. * @param mixed $value New value. - * @return $this */ protected function doSetProperty($property, $value) { @@ -78,20 +77,15 @@ trait LazyPropertyTrait } else { $this->setArrayProperty($property, $value); } - - return $this; } /** * @param string $property Object property to be unset. - * @return $this */ protected function doUnsetProperty($property) { $this->hasObjectProperty($property) ? $this->unsetObjectProperty($property) : $this->unsetArrayProperty($property); - - return $this; } /** diff --git a/system/src/Grav/Framework/Object/Property/MixedPropertyTrait.php b/system/src/Grav/Framework/Object/Property/MixedPropertyTrait.php index 149ac40b3..48809ff5f 100644 --- a/system/src/Grav/Framework/Object/Property/MixedPropertyTrait.php +++ b/system/src/Grav/Framework/Object/Property/MixedPropertyTrait.php @@ -68,26 +68,20 @@ trait MixedPropertyTrait /** * @param string $property Object property to be updated. * @param mixed $value New value. - * @return $this */ protected function doSetProperty($property, $value) { $this->hasObjectProperty($property) ? $this->setObjectProperty($property, $value) : $this->setArrayProperty($property, $value); - - return $this; } /** * @param string $property Object property to be unset. - * @return $this */ protected function doUnsetProperty($property) { $this->hasObjectProperty($property) ? $this->unsetObjectProperty($property) : $this->unsetArrayProperty($property); - - return $this; } /**