Rename dependencies to dependenciesThatCanBeRemovedWhenRemoving, be more specific. Remove unused parameter

This commit is contained in:
Flavio Copes
2016-03-04 18:08:30 +01:00
parent 1eb25fbfba
commit fecb1b179a
2 changed files with 9 additions and 8 deletions

View File

@@ -485,7 +485,7 @@ class Admin
*
* @return array|bool
*/
public function dependencies($slug, $remove_duplicates = false, $keys_already_added = [])
public function dependenciesThatCanBeRemovedWhenRemoving($slug, $keys_already_added = [])
{
$gpm = $this->gpm();
@@ -507,13 +507,14 @@ class Admin
}
foreach ($package->dependencies as $dependency) {
$temp_dependencies = $this->dependencies($dependency, $keys_already_added);
if ($dependency)
if ($remove_duplicates) {
foreach($keys_already_added as $key => $value) {
if (is_string($value)) {
unset($temp_dependencies[$value]);
}
$temp_dependencies = $this->dependenciesThatCanBeRemovedWhenRemoving($dependency, $keys_already_added);
foreach($keys_already_added as $key => $value) {
if (is_string($value)) {
unset($temp_dependencies[$value]);
}
}