From c2c11453f02df72ccdbb7fd1ba5706c5359c696d Mon Sep 17 00:00:00 2001
From: Rotzbua <Rotzbua@users.noreply.github.com>
Date: Tue, 15 Jan 2019 01:56:34 +0100
Subject: [PATCH] add rel="noreferrer" to external links (#1577)

---
 themes/grav/templates/partials/base-root.html.twig     |  2 +-
 themes/grav/templates/partials/plugin-data.html.twig   | 10 +++++-----
 .../grav/templates/partials/themes-details.html.twig   | 10 +++++-----
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/themes/grav/templates/partials/base-root.html.twig b/themes/grav/templates/partials/base-root.html.twig
index d0b8f595..d697050e 100644
--- a/themes/grav/templates/partials/base-root.html.twig
+++ b/themes/grav/templates/partials/base-root.html.twig
@@ -62,7 +62,7 @@
                                 {%- block content %}{% endblock -%}
                             </div>
                             {% if config.plugins.admin.show_github_msg %}
-                            <div class="notice alert"><i class="fa fa-github"></i> <a href="https://github.com/getgrav/grav-plugin-admin/issues" target="_blank">{{ 'PLUGIN_ADMIN.ADMIN_REPORT_ISSUE'|tu }}</a></div>
+                            <div class="notice alert"><i class="fa fa-github"></i> <a href="https://github.com/getgrav/grav-plugin-admin/issues" target="_blank" rel="noopener noreferrer">{{ 'PLUGIN_ADMIN.ADMIN_REPORT_ISSUE'|tu }}</a></div>
                             {% endif %}
                             {% block content_bottom %}{% endblock %}
                         </div>
diff --git a/themes/grav/templates/partials/plugin-data.html.twig b/themes/grav/templates/partials/plugin-data.html.twig
index 9fa320d7..751a6355 100644
--- a/themes/grav/templates/partials/plugin-data.html.twig
+++ b/themes/grav/templates/partials/plugin-data.html.twig
@@ -4,7 +4,7 @@
         <td>{{ "PLUGIN_ADMIN.AUTHOR"|tu }}:</td>
         <td class="double">
             {% if plugin.author.url %}
-                <a href="{{ plugin.author.url }}" target="_blank">{{ plugin.author.name }}</a>
+                <a href="{{ plugin.author.url }}" target="_blank" rel="noopener noreferrer">{{ plugin.author.name }}</a>
             {% else %}
                 {{ plugin.author.name }}
             {% endif %}
@@ -17,19 +17,19 @@
     {% if plugin.homepage %}
         <tr>
             <td>{{ "PLUGIN_ADMIN.HOMEPAGE"|tu }}:</td>
-            <td class="double"><a href="{{ plugin.homepage }}" target="_blank">{{ plugin.homepage }}</a></td>
+            <td class="double"><a href="{{ plugin.homepage }}" target="_blank" rel="noopener noreferrer">{{ plugin.homepage }}</a></td>
         </tr>
     {% endif %}
     {% if plugin.demo %}
         <tr>
             <td>{{ "PLUGIN_ADMIN.DEMO"|tu }}:</td>
-            <td class="double"><a href="{{ plugin.demo }}" target="_blank">{{ plugin.demo }}</a></td>
+            <td class="double"><a href="{{ plugin.demo }}" target="_blank" rel="noopener noreferrer">{{ plugin.demo }}</a></td>
         </tr>
     {% endif %}
     {% if plugin.bugs %}
         <tr>
             <td>{{ "PLUGIN_ADMIN.BUG_TRACKER"|tu }}:</td>
-            <td class="double"><a href="{{ plugin.bugs }}" target="_blank">{{ plugin.bugs }}</a></td>
+            <td class="double"><a href="{{ plugin.bugs }}" target="_blank" rel="noopener noreferrer">{{ plugin.bugs }}</a></td>
         </tr>
     {% endif %}
     {% if plugin.keywords %}
@@ -56,7 +56,7 @@
         {% set readme_link = plugin.readme ?: plugin.docs|default(plugin.homepage ~ '/blob/master/README.md') %}
         <tr>
             <td>{{ "PLUGIN_ADMIN.README"|tu }}:</td>
-            <td class="double"><a href="{{ readme_link }}" target="_blank">{{ readme_link }}</a></td>
+            <td class="double"><a href="{{ readme_link }}" target="_blank" rel="noopener noreferrer">{{ readme_link }}</a></td>
         </tr>
     {% endif %}
 
diff --git a/themes/grav/templates/partials/themes-details.html.twig b/themes/grav/templates/partials/themes-details.html.twig
index 09742f57..bea4dec3 100644
--- a/themes/grav/templates/partials/themes-details.html.twig
+++ b/themes/grav/templates/partials/themes-details.html.twig
@@ -35,7 +35,7 @@
                 <td>{{ "PLUGIN_ADMIN.AUTHOR"|tu }}:</td>
                 <td class="double">
                     {% if theme.author.url %}
-                        <a href="{{ theme.author.url }}" target="_blank">{{ theme.author.name }}</a>
+                        <a href="{{ theme.author.url }}" target="_blank" rel="noopener noreferrer">{{ theme.author.name }}</a>
                     {% else %}
                         {{ theme.author.name }}
                     {% endif %}
@@ -48,19 +48,19 @@
         {% if theme.homepage %}
         <tr>
             <td>{{ "PLUGIN_ADMIN.HOMEPAGE"|tu }}:</td>
-            <td class="double"><a href="{{ theme.homepage }}" target="_blank">{{ theme.homepage }}</a></td>
+            <td class="double"><a href="{{ theme.homepage }}" target="_blank" rel="noopener noreferrer">{{ theme.homepage }}</a></td>
         </tr>
         {% endif %}
         {% if theme.demo %}
         <tr>
             <td>{{ "PLUGIN_ADMIN.DEMO"|tu }}:</td>
-            <td class="double"><a href="{{ theme.demo }}" target="_blank">{{ theme.demo }}</a></td>
+            <td class="double"><a href="{{ theme.demo }}" target="_blank" rel="noopener noreferrer">{{ theme.demo }}</a></td>
         </tr>
         {% endif %}
         {% if theme.bugs %}
             <tr>
                 <td>{{ "PLUGIN_ADMIN.BUG_TRACKER"|tu }}:</td>
-                <td class="double"><a href="{{ theme.bugs }}" target="_blank">{{ theme.bugs }}</a></td>
+                <td class="double"><a href="{{ theme.bugs }}" target="_blank" rel="noopener noreferrer">{{ theme.bugs }}</a></td>
             </tr>
         {% endif %}
         {% if theme.keywords %}
@@ -88,7 +88,7 @@
             {% set readme_link = theme.readme ?: theme.homepage ~ '/blob/master/README.md' %}
             <tr>
                 <td>{{ "PLUGIN_ADMIN.README"|tu }}:</td>
-                <td class="double"><a href="{{ readme_link }}" target="_blank">{{ readme_link }}</a></td>
+                <td class="double"><a href="{{ readme_link }}" target="_blank" rel="noopener noreferrer">{{ readme_link }}</a></td>
             </tr>
         {% endif %}
     </table>