diff --git a/CHANGELOG.md b/CHANGELOG.md index 6adc4477..1d7b6b60 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ * Improved configuration fields for hiding page types in Admin 1. [](#bugfix) * Fixed minor UI padding in Flex pages [#1825](https://github.com/getgrav/grav-plugin-admin/issues/1825) + * Fixed `column` and `section` fields loosing user entered value when form submit fails # v1.10.0-rc.6 ## 02/11/2020 diff --git a/themes/grav/templates/forms/fields/column/column.html.twig b/themes/grav/templates/forms/fields/column/column.html.twig index f244ecf1..0706a508 100644 --- a/themes/grav/templates/forms/fields/column/column.html.twig +++ b/themes/grav/templates/forms/fields/column/column.html.twig @@ -5,7 +5,7 @@
{% for child in field.fields %} {% if child.type and not child.validate.ignore %} - {% set value = child.name ? data.value(child.name) : data.toArray %} + {% set value = child.name ? (form.value(field.name) ?? data.value(field.name)) : data.toArray %} {% include ["forms/fields/#{child.type}/#{child.type}.html.twig", 'forms/fields/text/text.html.twig'] with {field: child} %} {% endif %} {% endfor %} diff --git a/themes/grav/templates/forms/fields/permissions/permissions.html.twig b/themes/grav/templates/forms/fields/permissions/permissions.html.twig index 2a6f1618..fa3d50a0 100644 --- a/themes/grav/templates/forms/fields/permissions/permissions.html.twig +++ b/themes/grav/templates/forms/fields/permissions/permissions.html.twig @@ -14,7 +14,7 @@ {% if depth > 0 %} {% set section_value = context.access.get(section.name)|string %} - {% set data = { + {% set params = { context: context, action_label: section_label, action_value: section_value, @@ -23,7 +23,7 @@ } %} - {{ macro.action_row(data) }} + {{ macro.action_row(params) }} {% endif %}
@@ -51,7 +51,7 @@ {% set action_label = action.label ?? action.name %} {% set action_value = context.access.get(action.name)|string %} - {% set data = { + {% set params = { context: context, action_label: action_label, action_value: action_value, @@ -60,7 +60,7 @@ } %} - {{ macro.action_row(data) }} + {{ macro.action_row(params) }} {% endmacro %} {% macro action_row(data) %} diff --git a/themes/grav/templates/forms/fields/section/section.html.twig b/themes/grav/templates/forms/fields/section/section.html.twig index b47aa299..d2c9f2ae 100644 --- a/themes/grav/templates/forms/fields/section/section.html.twig +++ b/themes/grav/templates/forms/fields/section/section.html.twig @@ -15,7 +15,7 @@
{% for field in field.fields %} {% if field.type %} - {% set value = field.name ? data.value(field.name) : data.toArray %} + {% set value = field.name ? (form.value(field.name) ?? data.value(field.name)) : data.toArray %} {% include ["forms/fields/#{field.type}/#{field.type}.html.twig", 'forms/fields/text/text.html.twig'] %} {% endif %} {% endfor %} diff --git a/themes/grav/templates/partials/blueprints-new-folder.html.twig b/themes/grav/templates/partials/blueprints-new-folder.html.twig index 918d0683..a73b7c1c 100644 --- a/themes/grav/templates/partials/blueprints-new-folder.html.twig +++ b/themes/grav/templates/partials/blueprints-new-folder.html.twig @@ -4,7 +4,7 @@
{% for field in blueprints.fields %} {% if field.type %} - {% set value = field.name ? data.value(field.name) : data.toArray %} + {% set value = field.name ? (form.value(field.name) ?? data.value(field.name)) : data.toArray %}
{% include ["forms/fields/#{field.type}/#{field.type}.html.twig", 'forms/fields/text/text.html.twig'] %}
diff --git a/themes/grav/templates/partials/blueprints-new.html.twig b/themes/grav/templates/partials/blueprints-new.html.twig index 1ac3f186..1cbab237 100644 --- a/themes/grav/templates/partials/blueprints-new.html.twig +++ b/themes/grav/templates/partials/blueprints-new.html.twig @@ -1,10 +1,10 @@ {% set form_id = form_id ? form_id : 'blueprints' %} {% set scope = scope ?: 'data.' %} - + {% for field in blueprints.fields %} {% if field.type %} - {% set value = field.name ? data.value(field.name) : data.toArray %} + {% set value = field.name ? (form.value(field.name) ?? data.value(field.name)) : data.toArray %}
{% include ["forms/fields/#{field.type}/#{field.type}.html.twig", 'forms/fields/text/text.html.twig'] %}
diff --git a/themes/grav/templates/partials/blueprints.html.twig b/themes/grav/templates/partials/blueprints.html.twig index ed8ece80..05486c08 100644 --- a/themes/grav/templates/partials/blueprints.html.twig +++ b/themes/grav/templates/partials/blueprints.html.twig @@ -7,7 +7,7 @@ {% set multipart = ' enctype="multipart/form-data"' %} {% endif %} - + {% for field in blueprints.fields %} {% if field.type %} {% set value = field.name ? (form.value(field.name) ?? data.value(field.name)) : data.toArray %} diff --git a/themes/grav/templates/partials/page-move.html.twig b/themes/grav/templates/partials/page-move.html.twig index d440742b..e9c5ac13 100644 --- a/themes/grav/templates/partials/page-move.html.twig +++ b/themes/grav/templates/partials/page-move.html.twig @@ -8,7 +8,7 @@ {% for field in blueprints.fields %} {% if field.type %} - {% set value = field.name ? data.value(field.name) : data.toArray %} + {% set value = field.name ? (form.value(field.name) ?? data.value(field.name)) : data.toArray %}
{% include ["forms/fields/#{field.type}/#{field.type}.html.twig", 'forms/fields/text/text.html.twig'] %}