Nemcio/Gogs
1
0
Fork 0
mirror of https://github.com/gogs/gogs.git synced 2026-03-02 02:00:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

autofix: function call can be replaced with helper function (#6805)

Browse Source 
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
This commit is contained in:
deepsource-autofix[bot]
2022-03-06 16:33:55 +08:00
committed by GitHub
parent deec3516d5
commit 5afca6ca8e
10 changed files with 22 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
internal/auth/ldap/config.go
View File

@@ -72,7 +72,7 @@ func (c *Config) sanitizedUserQuery(username string) (string, bool) {
return "", false
}
return strings.Replace(c.Filter, "%s", username, -1), true
return strings.ReplaceAll(c.Filter, "%s", username), true
}
func (c *Config) sanitizedUserDN(username string) (string, bool) {
@@ -83,7 +83,7 @@ func (c *Config) sanitizedUserDN(username string) (string, bool) {
return "", false
}
return strings.Replace(c.UserDN, "%s", username, -1), true
return strings.ReplaceAll(c.UserDN, "%s", username), true
}
func (c *Config) sanitizedGroupFilter(group string) (string, bool) {
@@ -112,7 +112,7 @@ func (c *Config) findUserDN(l *ldap.Conn, name string) (string, bool) {
log.Trace("Search for LDAP user: %s", name)
if len(c.BindDN) > 0 && len(c.BindPassword) > 0 {
// Replace placeholders with username
bindDN := strings.Replace(c.BindDN, "%s", name, -1)
bindDN := strings.ReplaceAll(c.BindDN, "%s", name)
err := l.Bind(bindDN, c.BindPassword)
if err != nil {
log.Trace("LDAP: Failed to bind as BindDN '%s': %v", bindDN, err)