mirror of
https://github.com/go-gitea/gitea.git
synced 2026-04-13 16:07:56 +02:00
8fcbdf05b0
1. Fix the "flash message" layout problem for different cases * I am sure most of the users should have ever seen the ugly center-aligned error message with multiple lines. 2. Fix inconsistent "Details" flash message EOL handling, sometimes `\n`, sometimes `<br>` * Now, always use "\n" and use `<pre>` to render 3. Remove SanitizeHTML template func because it is not useful and can be easily abused. * But it is still kept for mail templates, for example: https://github.com/go-gitea/gitea/issues/36049 4. Clarify PostProcessCommitMessage's behavior and add FIXME comment By the way: cleaned up some devtest pages, move embedded style block to CSS file
43 lines
753 B
Go
43 lines
753 B
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package utils
|
|
|
|
import (
|
|
"html/template"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestEscapeFlashErrorString(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
arg string
|
|
want template.HTML
|
|
}{
|
|
{
|
|
name: "no error",
|
|
arg: "",
|
|
want: "",
|
|
},
|
|
{
|
|
name: "normal error",
|
|
arg: "can not open file: \"abc.exe\"",
|
|
want: "can not open file: "abc.exe"",
|
|
},
|
|
{
|
|
name: "line break error",
|
|
arg: "some error:\n\nawesome!",
|
|
want: "some error:\n\nawesome!",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got := EscapeFlashErrorString(tt.arg)
|
|
assert.Equal(t, tt.want, got)
|
|
})
|
|
}
|
|
}
|