mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-31 02:46:04 +01:00 
			
		
		
		
	A testing cleanup. This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot. Reference: https://pkg.go.dev/testing#T.TempDir ```go func TestFoo(t *testing.T) { // before tmpDir, err := os.MkdirTemp("", "") require.NoError(t, err) defer os.RemoveAll(tmpDir) // now tmpDir := t.TempDir() } ``` Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
		
			
				
	
	
		
			52 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			52 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2022 The Gitea Authors. All rights reserved.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package integration
 | |
| 
 | |
| import (
 | |
| 	"net/http"
 | |
| 	"net/url"
 | |
| 	"testing"
 | |
| 
 | |
| 	api "code.gitea.io/gitea/modules/structs"
 | |
| 	"code.gitea.io/gitea/tests"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| func TestAPIGetRawFileOrLFS(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 
 | |
| 	// Test with raw file
 | |
| 	req := NewRequest(t, "GET", "/api/v1/repos/user2/repo1/media/README.md")
 | |
| 	resp := MakeRequest(t, req, http.StatusOK)
 | |
| 	assert.Equal(t, "# repo1\n\nDescription for repo1", resp.Body.String())
 | |
| 
 | |
| 	// Test with LFS
 | |
| 	onGiteaRun(t, func(t *testing.T, u *url.URL) {
 | |
| 		httpContext := NewAPITestContext(t, "user2", "repo-lfs-test")
 | |
| 		doAPICreateRepository(httpContext, false, func(t *testing.T, repository api.Repository) {
 | |
| 			u.Path = httpContext.GitPath()
 | |
| 			dstPath := t.TempDir()
 | |
| 
 | |
| 			u.Path = httpContext.GitPath()
 | |
| 			u.User = url.UserPassword("user2", userPassword)
 | |
| 
 | |
| 			t.Run("Clone", doGitClone(dstPath, u))
 | |
| 
 | |
| 			dstPath2 := t.TempDir()
 | |
| 
 | |
| 			t.Run("Partial Clone", doPartialGitClone(dstPath2, u))
 | |
| 
 | |
| 			lfs, _ := lfsCommitAndPushTest(t, dstPath)
 | |
| 
 | |
| 			reqLFS := NewRequest(t, "GET", "/api/v1/repos/user2/repo1/media/"+lfs)
 | |
| 			respLFS := MakeRequestNilResponseRecorder(t, reqLFS, http.StatusOK)
 | |
| 			assert.Equal(t, littleSize, respLFS.Length)
 | |
| 
 | |
| 			doAPIDeleteRepository(httpContext)
 | |
| 		})
 | |
| 	})
 | |
| }
 |