mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-31 19:06:18 +01:00 
			
		
		
		
	Enable [forbidigo](https://github.com/ashanbrown/forbidigo) linter which forbids print statements. Will check how to integrate this with the smallest impact possible, so a few `nolint` comments will likely be required. Plan is to just go through the issues and either: - Remove the print if it is nonsensical - Add a `//nolint` directive if it makes sense I don't plan on investigating the individual issues any further. <details> <summary>Initial Lint Results</summary> ``` modules/log/event.go:348:6: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println(err) ^ modules/log/event.go:382:6: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println(err) ^ modules/queue/unique_queue_disk_channel_test.go:20:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("TempDir %s\n", tmpDir) ^ contrib/backport/backport.go:168:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("* Backporting %s to %s as %s\n", pr, localReleaseBranch, backportBranch) ^ contrib/backport/backport.go:216:4: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("* Navigate to %s to open PR\n", url) ^ contrib/backport/backport.go:223:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("* `xdg-open %s`\n", url) ^ contrib/backport/backport.go:233:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("* `git push -u %s %s`\n", remote, backportBranch) ^ contrib/backport/backport.go:243:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("* Amending commit to prepend `Backport #%s` to body\n", pr) ^ contrib/backport/backport.go:272:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println("* Attempting git cherry-pick --continue") ^ contrib/backport/backport.go:281:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("* Attempting git cherry-pick %s\n", sha) ^ contrib/backport/backport.go:297:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("* Current branch is %s\n", currentBranch) ^ contrib/backport/backport.go:299:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("* Current branch is %s - not checking out\n", currentBranch) ^ contrib/backport/backport.go:304:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("* Branch %s already exists. Checking it out...\n", backportBranch) ^ contrib/backport/backport.go:308:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("* `git checkout -b %s %s`\n", backportBranch, releaseBranch) ^ contrib/backport/backport.go:313:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("* `git fetch %s main`\n", remote) ^ contrib/backport/backport.go:316:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println(string(out)) ^ contrib/backport/backport.go:319:2: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println(string(out)) ^ contrib/backport/backport.go:321:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("* `git fetch %s %s`\n", remote, releaseBranch) ^ contrib/backport/backport.go:324:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println(string(out)) ^ contrib/backport/backport.go:327:2: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println(string(out)) ^ models/unittest/fixtures.go:50:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println("Unsupported RDBMS for integration tests") ^ models/unittest/fixtures.go:89:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("LoadFixtures failed after retries: %v\n", err) ^ models/unittest/fixtures.go:110:4: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Failed to generate sequence update: %v\n", err) ^ models/unittest/fixtures.go:117:6: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Failed to update sequence: %s Error: %v\n", value, err) ^ models/migrations/base/tests.go:118:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println("Environment variable $GITEA_ROOT not set") ^ models/migrations/base/tests.go:127:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Could not find gitea binary at %s\n", setting.AppPath) ^ models/migrations/base/tests.go:134:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Environment variable $GITEA_CONF not set - defaulting to %s\n", giteaConf) ^ models/migrations/base/tests.go:145:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Unable to create temporary data path %v\n", err) ^ models/migrations/base/tests.go:154:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Unable to InitFull: %v\n", err) ^ models/migrations/v1_11/v112.go:34:5: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Error: %v", err) ^ contrib/fixtures/fixture_generation.go:36:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("CreateTestEngine: %+v", err) ^ contrib/fixtures/fixture_generation.go:40:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("PrepareTestDatabase: %+v\n", err) ^ contrib/fixtures/fixture_generation.go:46:5: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("generate '%s': %+v\n", r, err) ^ contrib/fixtures/fixture_generation.go:53:5: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("generate '%s': %+v\n", g.name, err) ^ contrib/fixtures/fixture_generation.go:71:4: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("%s created.\n", path) ^ services/gitdiff/gitdiff_test.go:543:2: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) println(result) ^ services/gitdiff/gitdiff_test.go:560:2: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) println(result) ^ services/gitdiff/gitdiff_test.go:577:2: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) println(result) ^ modules/web/routing/logger_manager.go:34:2: use of `print` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) print Printer ^ modules/doctor/paths.go:109:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Warning: can't remove temporary file: '%s'\n", tmpFile.Name()) ^ tests/test_utils.go:33:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf(format+"\n", args...) ^ tests/test_utils.go:61:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Environment variable $GITEA_CONF not set, use default: %s\n", giteaConf) ^ cmd/actions.go:54:9: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) _, _ = fmt.Printf("%s\n", respText) ^ cmd/admin_user_change_password.go:74:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("%s's password has been successfully updated!\n", user.Name) ^ cmd/admin_user_create.go:109:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("generated random password is '%s'\n", password) ^ cmd/admin_user_create.go:164:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Access token was successfully created... %s\n", t.Token) ^ cmd/admin_user_create.go:167:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("New user '%s' has been successfully created!\n", username) ^ cmd/admin_user_generate_access_token.go:74:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("%s\n", t.Token) ^ cmd/admin_user_generate_access_token.go:76:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Access token was successfully created: %s\n", t.Token) ^ cmd/admin_user_must_change_password.go:56:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Updated %d users setting MustChangePassword to %t\n", n, mustChangePassword) ^ cmd/convert.go:44:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println("Converted successfully, please confirm your database's character set is now utf8mb4") ^ cmd/convert.go:50:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println("Converted successfully, please confirm your database's all columns character is NVARCHAR now") ^ cmd/convert.go:52:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println("This command can only be used with a MySQL or MSSQL database") ^ cmd/doctor.go:104:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println(err) ^ cmd/doctor.go:105:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println("Check if you are using the right config file. You can use a --config directive to specify one.") ^ cmd/doctor.go:243:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println(err) ^ cmd/embedded.go:154:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println(a.path) ^ cmd/embedded.go:198:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println("Using app.ini at", setting.CustomConf) ^ cmd/embedded.go:217:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Extracting to %s:\n", destdir) ^ cmd/embedded.go:253:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("%s already exists; skipped.\n", dest) ^ cmd/embedded.go:275:2: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println(dest) ^ cmd/generate.go:63:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("%s", internalToken) ^ cmd/generate.go:66:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("\n") ^ cmd/generate.go:78:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("%s", JWTSecretBase64) ^ cmd/generate.go:81:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("\n") ^ cmd/generate.go:93:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("%s", secretKey) ^ cmd/generate.go:96:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("\n") ^ cmd/keys.go:74:2: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println(strings.TrimSpace(authorizedString)) ^ cmd/mailer.go:32:4: use of `fmt.Print` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Print("warning: Content is empty") ^ cmd/mailer.go:35:3: use of `fmt.Print` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Print("Proceed with sending email? [Y/n] ") ^ cmd/mailer.go:40:4: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Println("The mail was not sent") ^ cmd/mailer.go:49:9: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) _, _ = fmt.Printf("Sent %s email(s) to all users\n", respText) ^ cmd/serv.go:147:3: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) println("Gitea: SSH has been disabled") ^ cmd/serv.go:153:4: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("error showing subcommand help: %v\n", err) ^ cmd/serv.go:175:4: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) println("Hi there! You've successfully authenticated with the deploy key named " + key.Name + ", but Gitea does not provide shell access.") ^ cmd/serv.go:177:4: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) println("Hi there! You've successfully authenticated with the principal " + key.Content + ", but Gitea does not provide shell access.") ^ cmd/serv.go:179:4: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) println("Hi there, " + user.Name + "! You've successfully authenticated with the key named " + key.Name + ", but Gitea does not provide shell access.") ^ cmd/serv.go:181:3: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) println("If this is unexpected, please log in with password and setup Gitea under another user.") ^ cmd/serv.go:196:5: use of `fmt.Print` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Print(`{"type":"gitea","version":1}`) ^ tests/e2e/e2e_test.go:54:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Error initializing test database: %v\n", err) ^ tests/e2e/e2e_test.go:63:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("util.RemoveAll: %v\n", err) ^ tests/e2e/e2e_test.go:67:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Unable to remove repo indexer: %v\n", err) ^ tests/e2e/e2e_test.go:109:6: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("%v", stdout.String()) ^ tests/e2e/e2e_test.go:110:6: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("%v", stderr.String()) ^ tests/e2e/e2e_test.go:113:6: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("%v", stdout.String()) ^ tests/integration/integration_test.go:124:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Error initializing test database: %v\n", err) ^ tests/integration/integration_test.go:135:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("util.RemoveAll: %v\n", err) ^ tests/integration/integration_test.go:139:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("Unable to remove repo indexer: %v\n", err) ^ tests/integration/repo_test.go:357:4: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo) fmt.Printf("%s", resp.Body) ^ ``` </details> --------- Co-authored-by: Giteabot <teabot@gitea.io>
		
			
				
	
	
		
			470 lines
		
	
	
		
			13 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			470 lines
		
	
	
		
			13 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2017 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| //nolint:forbidigo
 | |
| package integration
 | |
| 
 | |
| import (
 | |
| 	"bytes"
 | |
| 	"context"
 | |
| 	"fmt"
 | |
| 	"hash"
 | |
| 	"hash/fnv"
 | |
| 	"io"
 | |
| 	"net/http"
 | |
| 	"net/http/cookiejar"
 | |
| 	"net/http/httptest"
 | |
| 	"net/url"
 | |
| 	"os"
 | |
| 	"path/filepath"
 | |
| 	"strings"
 | |
| 	"sync/atomic"
 | |
| 	"testing"
 | |
| 	"time"
 | |
| 
 | |
| 	"code.gitea.io/gitea/models/auth"
 | |
| 	"code.gitea.io/gitea/models/unittest"
 | |
| 	gitea_context "code.gitea.io/gitea/modules/context"
 | |
| 	"code.gitea.io/gitea/modules/graceful"
 | |
| 	"code.gitea.io/gitea/modules/json"
 | |
| 	"code.gitea.io/gitea/modules/log"
 | |
| 	"code.gitea.io/gitea/modules/setting"
 | |
| 	"code.gitea.io/gitea/modules/util"
 | |
| 	"code.gitea.io/gitea/modules/web"
 | |
| 	"code.gitea.io/gitea/routers"
 | |
| 	"code.gitea.io/gitea/tests"
 | |
| 
 | |
| 	"github.com/PuerkitoBio/goquery"
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| 	"github.com/xeipuuv/gojsonschema"
 | |
| )
 | |
| 
 | |
| var c *web.Route
 | |
| 
 | |
| type NilResponseRecorder struct {
 | |
| 	httptest.ResponseRecorder
 | |
| 	Length int
 | |
| }
 | |
| 
 | |
| func (n *NilResponseRecorder) Write(b []byte) (int, error) {
 | |
| 	n.Length += len(b)
 | |
| 	return len(b), nil
 | |
| }
 | |
| 
 | |
| // NewRecorder returns an initialized ResponseRecorder.
 | |
| func NewNilResponseRecorder() *NilResponseRecorder {
 | |
| 	return &NilResponseRecorder{
 | |
| 		ResponseRecorder: *httptest.NewRecorder(),
 | |
| 	}
 | |
| }
 | |
| 
 | |
| type NilResponseHashSumRecorder struct {
 | |
| 	httptest.ResponseRecorder
 | |
| 	Hash   hash.Hash
 | |
| 	Length int
 | |
| }
 | |
| 
 | |
| func (n *NilResponseHashSumRecorder) Write(b []byte) (int, error) {
 | |
| 	_, _ = n.Hash.Write(b)
 | |
| 	n.Length += len(b)
 | |
| 	return len(b), nil
 | |
| }
 | |
| 
 | |
| // NewRecorder returns an initialized ResponseRecorder.
 | |
| func NewNilResponseHashSumRecorder() *NilResponseHashSumRecorder {
 | |
| 	return &NilResponseHashSumRecorder{
 | |
| 		Hash:             fnv.New32(),
 | |
| 		ResponseRecorder: *httptest.NewRecorder(),
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestMain(m *testing.M) {
 | |
| 	defer log.Close()
 | |
| 
 | |
| 	managerCtx, cancel := context.WithCancel(context.Background())
 | |
| 	graceful.InitManager(managerCtx)
 | |
| 	defer cancel()
 | |
| 
 | |
| 	tests.InitTest(true)
 | |
| 	c = routers.NormalRoutes(context.TODO())
 | |
| 
 | |
| 	// integration test settings...
 | |
| 	if setting.CfgProvider != nil {
 | |
| 		testingCfg := setting.CfgProvider.Section("integration-tests")
 | |
| 		tests.SlowTest = testingCfg.Key("SLOW_TEST").MustDuration(tests.SlowTest)
 | |
| 		tests.SlowFlush = testingCfg.Key("SLOW_FLUSH").MustDuration(tests.SlowFlush)
 | |
| 	}
 | |
| 
 | |
| 	if os.Getenv("GITEA_SLOW_TEST_TIME") != "" {
 | |
| 		duration, err := time.ParseDuration(os.Getenv("GITEA_SLOW_TEST_TIME"))
 | |
| 		if err == nil {
 | |
| 			tests.SlowTest = duration
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	if os.Getenv("GITEA_SLOW_FLUSH_TIME") != "" {
 | |
| 		duration, err := time.ParseDuration(os.Getenv("GITEA_SLOW_FLUSH_TIME"))
 | |
| 		if err == nil {
 | |
| 			tests.SlowFlush = duration
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	os.Unsetenv("GIT_AUTHOR_NAME")
 | |
| 	os.Unsetenv("GIT_AUTHOR_EMAIL")
 | |
| 	os.Unsetenv("GIT_AUTHOR_DATE")
 | |
| 	os.Unsetenv("GIT_COMMITTER_NAME")
 | |
| 	os.Unsetenv("GIT_COMMITTER_EMAIL")
 | |
| 	os.Unsetenv("GIT_COMMITTER_DATE")
 | |
| 
 | |
| 	err := unittest.InitFixtures(
 | |
| 		unittest.FixturesOptions{
 | |
| 			Dir: filepath.Join(filepath.Dir(setting.AppPath), "models/fixtures/"),
 | |
| 		},
 | |
| 	)
 | |
| 	if err != nil {
 | |
| 		fmt.Printf("Error initializing test database: %v\n", err)
 | |
| 		os.Exit(1)
 | |
| 	}
 | |
| 
 | |
| 	// FIXME: the console logger is deleted by mistake, so if there is any `log.Fatal`, developers won't see any error message.
 | |
| 	// Instead, "No tests were found",  last nonsense log is "According to the configuration, subsequent logs will not be printed to the console"
 | |
| 	exitCode := m.Run()
 | |
| 
 | |
| 	tests.WriterCloser.Reset()
 | |
| 
 | |
| 	if err = util.RemoveAll(setting.Indexer.IssuePath); err != nil {
 | |
| 		fmt.Printf("util.RemoveAll: %v\n", err)
 | |
| 		os.Exit(1)
 | |
| 	}
 | |
| 	if err = util.RemoveAll(setting.Indexer.RepoPath); err != nil {
 | |
| 		fmt.Printf("Unable to remove repo indexer: %v\n", err)
 | |
| 		os.Exit(1)
 | |
| 	}
 | |
| 
 | |
| 	os.Exit(exitCode)
 | |
| }
 | |
| 
 | |
| type TestSession struct {
 | |
| 	jar http.CookieJar
 | |
| }
 | |
| 
 | |
| func (s *TestSession) GetCookie(name string) *http.Cookie {
 | |
| 	baseURL, err := url.Parse(setting.AppURL)
 | |
| 	if err != nil {
 | |
| 		return nil
 | |
| 	}
 | |
| 
 | |
| 	for _, c := range s.jar.Cookies(baseURL) {
 | |
| 		if c.Name == name {
 | |
| 			return c
 | |
| 		}
 | |
| 	}
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| func (s *TestSession) MakeRequest(t testing.TB, req *http.Request, expectedStatus int) *httptest.ResponseRecorder {
 | |
| 	t.Helper()
 | |
| 	baseURL, err := url.Parse(setting.AppURL)
 | |
| 	assert.NoError(t, err)
 | |
| 	for _, c := range s.jar.Cookies(baseURL) {
 | |
| 		req.AddCookie(c)
 | |
| 	}
 | |
| 	resp := MakeRequest(t, req, expectedStatus)
 | |
| 
 | |
| 	ch := http.Header{}
 | |
| 	ch.Add("Cookie", strings.Join(resp.Header()["Set-Cookie"], ";"))
 | |
| 	cr := http.Request{Header: ch}
 | |
| 	s.jar.SetCookies(baseURL, cr.Cookies())
 | |
| 
 | |
| 	return resp
 | |
| }
 | |
| 
 | |
| func (s *TestSession) MakeRequestNilResponseRecorder(t testing.TB, req *http.Request, expectedStatus int) *NilResponseRecorder {
 | |
| 	t.Helper()
 | |
| 	baseURL, err := url.Parse(setting.AppURL)
 | |
| 	assert.NoError(t, err)
 | |
| 	for _, c := range s.jar.Cookies(baseURL) {
 | |
| 		req.AddCookie(c)
 | |
| 	}
 | |
| 	resp := MakeRequestNilResponseRecorder(t, req, expectedStatus)
 | |
| 
 | |
| 	ch := http.Header{}
 | |
| 	ch.Add("Cookie", strings.Join(resp.Header()["Set-Cookie"], ";"))
 | |
| 	cr := http.Request{Header: ch}
 | |
| 	s.jar.SetCookies(baseURL, cr.Cookies())
 | |
| 
 | |
| 	return resp
 | |
| }
 | |
| 
 | |
| func (s *TestSession) MakeRequestNilResponseHashSumRecorder(t testing.TB, req *http.Request, expectedStatus int) *NilResponseHashSumRecorder {
 | |
| 	t.Helper()
 | |
| 	baseURL, err := url.Parse(setting.AppURL)
 | |
| 	assert.NoError(t, err)
 | |
| 	for _, c := range s.jar.Cookies(baseURL) {
 | |
| 		req.AddCookie(c)
 | |
| 	}
 | |
| 	resp := MakeRequestNilResponseHashSumRecorder(t, req, expectedStatus)
 | |
| 
 | |
| 	ch := http.Header{}
 | |
| 	ch.Add("Cookie", strings.Join(resp.Header()["Set-Cookie"], ";"))
 | |
| 	cr := http.Request{Header: ch}
 | |
| 	s.jar.SetCookies(baseURL, cr.Cookies())
 | |
| 
 | |
| 	return resp
 | |
| }
 | |
| 
 | |
| const userPassword = "password"
 | |
| 
 | |
| func emptyTestSession(t testing.TB) *TestSession {
 | |
| 	t.Helper()
 | |
| 	jar, err := cookiejar.New(nil)
 | |
| 	assert.NoError(t, err)
 | |
| 
 | |
| 	return &TestSession{jar: jar}
 | |
| }
 | |
| 
 | |
| func getUserToken(t testing.TB, userName string, scope ...auth.AccessTokenScope) string {
 | |
| 	return getTokenForLoggedInUser(t, loginUser(t, userName), scope...)
 | |
| }
 | |
| 
 | |
| func loginUser(t testing.TB, userName string) *TestSession {
 | |
| 	t.Helper()
 | |
| 
 | |
| 	return loginUserWithPassword(t, userName, userPassword)
 | |
| }
 | |
| 
 | |
| func loginUserWithPassword(t testing.TB, userName, password string) *TestSession {
 | |
| 	t.Helper()
 | |
| 	req := NewRequest(t, "GET", "/user/login")
 | |
| 	resp := MakeRequest(t, req, http.StatusOK)
 | |
| 
 | |
| 	doc := NewHTMLParser(t, resp.Body)
 | |
| 	req = NewRequestWithValues(t, "POST", "/user/login", map[string]string{
 | |
| 		"_csrf":     doc.GetCSRF(),
 | |
| 		"user_name": userName,
 | |
| 		"password":  password,
 | |
| 	})
 | |
| 	resp = MakeRequest(t, req, http.StatusSeeOther)
 | |
| 
 | |
| 	ch := http.Header{}
 | |
| 	ch.Add("Cookie", strings.Join(resp.Header()["Set-Cookie"], ";"))
 | |
| 	cr := http.Request{Header: ch}
 | |
| 
 | |
| 	session := emptyTestSession(t)
 | |
| 
 | |
| 	baseURL, err := url.Parse(setting.AppURL)
 | |
| 	assert.NoError(t, err)
 | |
| 	session.jar.SetCookies(baseURL, cr.Cookies())
 | |
| 
 | |
| 	return session
 | |
| }
 | |
| 
 | |
| // token has to be unique this counter take care of
 | |
| var tokenCounter int64
 | |
| 
 | |
| // getTokenForLoggedInUser returns a token for a logged in user.
 | |
| // The scope is an optional list of snake_case strings like the frontend form fields,
 | |
| // but without the "scope_" prefix.
 | |
| func getTokenForLoggedInUser(t testing.TB, session *TestSession, scopes ...auth.AccessTokenScope) string {
 | |
| 	t.Helper()
 | |
| 	var token string
 | |
| 	req := NewRequest(t, "GET", "/user/settings/applications")
 | |
| 	resp := session.MakeRequest(t, req, http.StatusOK)
 | |
| 	var csrf string
 | |
| 	for _, cookie := range resp.Result().Cookies() {
 | |
| 		if cookie.Name != "_csrf" {
 | |
| 			continue
 | |
| 		}
 | |
| 		csrf = cookie.Value
 | |
| 		break
 | |
| 	}
 | |
| 	if csrf == "" {
 | |
| 		doc := NewHTMLParser(t, resp.Body)
 | |
| 		csrf = doc.GetCSRF()
 | |
| 	}
 | |
| 	assert.NotEmpty(t, csrf)
 | |
| 	urlValues := url.Values{}
 | |
| 	urlValues.Add("_csrf", csrf)
 | |
| 	urlValues.Add("name", fmt.Sprintf("api-testing-token-%d", atomic.AddInt64(&tokenCounter, 1)))
 | |
| 	for _, scope := range scopes {
 | |
| 		urlValues.Add("scope", string(scope))
 | |
| 	}
 | |
| 	req = NewRequestWithURLValues(t, "POST", "/user/settings/applications", urlValues)
 | |
| 	resp = session.MakeRequest(t, req, http.StatusSeeOther)
 | |
| 
 | |
| 	// Log the flash values on failure
 | |
| 	if !assert.Equal(t, resp.Result().Header["Location"], []string{"/user/settings/applications"}) {
 | |
| 		for _, cookie := range resp.Result().Cookies() {
 | |
| 			if cookie.Name != gitea_context.CookieNameFlash {
 | |
| 				continue
 | |
| 			}
 | |
| 			flash, _ := url.ParseQuery(cookie.Value)
 | |
| 			for key, value := range flash {
 | |
| 				t.Logf("Flash %q: %q", key, value)
 | |
| 			}
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	req = NewRequest(t, "GET", "/user/settings/applications")
 | |
| 	resp = session.MakeRequest(t, req, http.StatusOK)
 | |
| 	htmlDoc := NewHTMLParser(t, resp.Body)
 | |
| 	token = htmlDoc.doc.Find(".ui.info p").Text()
 | |
| 	assert.NotEmpty(t, token)
 | |
| 	return token
 | |
| }
 | |
| 
 | |
| func NewRequest(t testing.TB, method, urlStr string) *http.Request {
 | |
| 	t.Helper()
 | |
| 	return NewRequestWithBody(t, method, urlStr, nil)
 | |
| }
 | |
| 
 | |
| func NewRequestf(t testing.TB, method, urlFormat string, args ...interface{}) *http.Request {
 | |
| 	t.Helper()
 | |
| 	return NewRequest(t, method, fmt.Sprintf(urlFormat, args...))
 | |
| }
 | |
| 
 | |
| func NewRequestWithValues(t testing.TB, method, urlStr string, values map[string]string) *http.Request {
 | |
| 	t.Helper()
 | |
| 	urlValues := url.Values{}
 | |
| 	for key, value := range values {
 | |
| 		urlValues[key] = []string{value}
 | |
| 	}
 | |
| 	return NewRequestWithURLValues(t, method, urlStr, urlValues)
 | |
| }
 | |
| 
 | |
| func NewRequestWithURLValues(t testing.TB, method, urlStr string, urlValues url.Values) *http.Request {
 | |
| 	t.Helper()
 | |
| 	req := NewRequestWithBody(t, method, urlStr, bytes.NewBufferString(urlValues.Encode()))
 | |
| 	req.Header.Add("Content-Type", "application/x-www-form-urlencoded")
 | |
| 	return req
 | |
| }
 | |
| 
 | |
| func NewRequestWithJSON(t testing.TB, method, urlStr string, v interface{}) *http.Request {
 | |
| 	t.Helper()
 | |
| 
 | |
| 	jsonBytes, err := json.Marshal(v)
 | |
| 	assert.NoError(t, err)
 | |
| 	req := NewRequestWithBody(t, method, urlStr, bytes.NewBuffer(jsonBytes))
 | |
| 	req.Header.Add("Content-Type", "application/json")
 | |
| 	return req
 | |
| }
 | |
| 
 | |
| func NewRequestWithBody(t testing.TB, method, urlStr string, body io.Reader) *http.Request {
 | |
| 	t.Helper()
 | |
| 	if !strings.HasPrefix(urlStr, "http") && !strings.HasPrefix(urlStr, "/") {
 | |
| 		urlStr = "/" + urlStr
 | |
| 	}
 | |
| 	request, err := http.NewRequest(method, urlStr, body)
 | |
| 	assert.NoError(t, err)
 | |
| 	request.RequestURI = urlStr
 | |
| 	return request
 | |
| }
 | |
| 
 | |
| func AddBasicAuthHeader(request *http.Request, username string) *http.Request {
 | |
| 	request.SetBasicAuth(username, userPassword)
 | |
| 	return request
 | |
| }
 | |
| 
 | |
| const NoExpectedStatus = -1
 | |
| 
 | |
| func MakeRequest(t testing.TB, req *http.Request, expectedStatus int) *httptest.ResponseRecorder {
 | |
| 	t.Helper()
 | |
| 	recorder := httptest.NewRecorder()
 | |
| 	if req.RemoteAddr == "" {
 | |
| 		req.RemoteAddr = "test-mock:12345"
 | |
| 	}
 | |
| 	c.ServeHTTP(recorder, req)
 | |
| 	if expectedStatus != NoExpectedStatus {
 | |
| 		if !assert.EqualValues(t, expectedStatus, recorder.Code, "Request: %s %s", req.Method, req.URL.String()) {
 | |
| 			logUnexpectedResponse(t, recorder)
 | |
| 		}
 | |
| 	}
 | |
| 	return recorder
 | |
| }
 | |
| 
 | |
| func MakeRequestNilResponseRecorder(t testing.TB, req *http.Request, expectedStatus int) *NilResponseRecorder {
 | |
| 	t.Helper()
 | |
| 	recorder := NewNilResponseRecorder()
 | |
| 	c.ServeHTTP(recorder, req)
 | |
| 	if expectedStatus != NoExpectedStatus {
 | |
| 		if !assert.EqualValues(t, expectedStatus, recorder.Code,
 | |
| 			"Request: %s %s", req.Method, req.URL.String()) {
 | |
| 			logUnexpectedResponse(t, &recorder.ResponseRecorder)
 | |
| 		}
 | |
| 	}
 | |
| 	return recorder
 | |
| }
 | |
| 
 | |
| func MakeRequestNilResponseHashSumRecorder(t testing.TB, req *http.Request, expectedStatus int) *NilResponseHashSumRecorder {
 | |
| 	t.Helper()
 | |
| 	recorder := NewNilResponseHashSumRecorder()
 | |
| 	c.ServeHTTP(recorder, req)
 | |
| 	if expectedStatus != NoExpectedStatus {
 | |
| 		if !assert.EqualValues(t, expectedStatus, recorder.Code,
 | |
| 			"Request: %s %s", req.Method, req.URL.String()) {
 | |
| 			logUnexpectedResponse(t, &recorder.ResponseRecorder)
 | |
| 		}
 | |
| 	}
 | |
| 	return recorder
 | |
| }
 | |
| 
 | |
| // logUnexpectedResponse logs the contents of an unexpected response.
 | |
| func logUnexpectedResponse(t testing.TB, recorder *httptest.ResponseRecorder) {
 | |
| 	t.Helper()
 | |
| 	respBytes := recorder.Body.Bytes()
 | |
| 	if len(respBytes) == 0 {
 | |
| 		return
 | |
| 	} else if len(respBytes) < 500 {
 | |
| 		// if body is short, just log the whole thing
 | |
| 		t.Log("Response: ", string(respBytes))
 | |
| 		return
 | |
| 	} else {
 | |
| 		t.Log("Response length: ", len(respBytes))
 | |
| 	}
 | |
| 
 | |
| 	// log the "flash" error message, if one exists
 | |
| 	// we must create a new buffer, so that we don't "use up" resp.Body
 | |
| 	htmlDoc, err := goquery.NewDocumentFromReader(bytes.NewBuffer(respBytes))
 | |
| 	if err != nil {
 | |
| 		return // probably a non-HTML response
 | |
| 	}
 | |
| 	errMsg := htmlDoc.Find(".ui.negative.message").Text()
 | |
| 	if len(errMsg) > 0 {
 | |
| 		t.Log("A flash error message was found:", errMsg)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func DecodeJSON(t testing.TB, resp *httptest.ResponseRecorder, v interface{}) {
 | |
| 	t.Helper()
 | |
| 
 | |
| 	decoder := json.NewDecoder(resp.Body)
 | |
| 	assert.NoError(t, decoder.Decode(v))
 | |
| }
 | |
| 
 | |
| func VerifyJSONSchema(t testing.TB, resp *httptest.ResponseRecorder, schemaFile string) {
 | |
| 	t.Helper()
 | |
| 
 | |
| 	schemaFilePath := filepath.Join(filepath.Dir(setting.AppPath), "tests", "integration", "schemas", schemaFile)
 | |
| 	_, schemaFileErr := os.Stat(schemaFilePath)
 | |
| 	assert.Nil(t, schemaFileErr)
 | |
| 
 | |
| 	schema, schemaFileReadErr := os.ReadFile(schemaFilePath)
 | |
| 	assert.Nil(t, schemaFileReadErr)
 | |
| 	assert.True(t, len(schema) > 0)
 | |
| 
 | |
| 	nodeinfoSchema := gojsonschema.NewStringLoader(string(schema))
 | |
| 	nodeinfoString := gojsonschema.NewStringLoader(resp.Body.String())
 | |
| 	result, schemaValidationErr := gojsonschema.Validate(nodeinfoSchema, nodeinfoString)
 | |
| 	assert.Nil(t, schemaValidationErr)
 | |
| 	assert.Empty(t, result.Errors())
 | |
| 	assert.True(t, result.Valid())
 | |
| }
 | |
| 
 | |
| func GetCSRF(t testing.TB, session *TestSession, urlStr string) string {
 | |
| 	t.Helper()
 | |
| 	req := NewRequest(t, "GET", urlStr)
 | |
| 	resp := session.MakeRequest(t, req, http.StatusOK)
 | |
| 	doc := NewHTMLParser(t, resp.Body)
 | |
| 	return doc.GetCSRF()
 | |
| }
 |