mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-11-03 20:36:07 +01:00 
			
		
		
		
	Add form field id generation, remove duplicated ids (#30546)
Fixes: https://github.com/go-gitea/gitea/issues/30384 On repo settings page, there id `repo_name` was used 5 times on the same page, some in modal and such. I think we are better off just auto-generating these IDs in the future so that labels link up with their form element. Ideally this id generation would be done in backend in a subtemplate, but seeing that we already have similar JS patches for checkboxes, I took the easy path for now. I also checked that these `#repo_name` were not in use in JS and the only case where this id appears in JS is on the migration page where it's still there. --------- Co-authored-by: Giteabot <teabot@gitea.io>
This commit is contained in:
		
							
								
								
									
										13
									
								
								web_src/js/modules/fomantic/form.js
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										13
									
								
								web_src/js/modules/fomantic/form.js
									
									
									
									
									
										Normal file
									
								
							@@ -0,0 +1,13 @@
 | 
			
		||||
import {linkLabelAndInput} from './base.js';
 | 
			
		||||
 | 
			
		||||
export function initAriaFormFieldPatch() {
 | 
			
		||||
  // link the label and the input element so it's clickable and accessible
 | 
			
		||||
  for (const el of document.querySelectorAll('.ui.form .field')) {
 | 
			
		||||
    if (el.hasAttribute('data-field-patched')) continue;
 | 
			
		||||
    const label = el.querySelector(':scope > label');
 | 
			
		||||
    const input = el.querySelector(':scope > input');
 | 
			
		||||
    if (!label || !input) continue;
 | 
			
		||||
    linkLabelAndInput(label, input);
 | 
			
		||||
    el.setAttribute('data-field-patched', 'true');
 | 
			
		||||
  }
 | 
			
		||||
}
 | 
			
		||||
		Reference in New Issue
	
	Block a user