mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-11-03 20:36:07 +01:00 
			
		
		
		
	Executable check always returns true for windows (#20637)
* Executable check always returns true for windows Windows doesn't have the concept of "executable" POSIX bits so for now always return true to minimise doctor and logging noise. Addresses #20636 * gofmt tweak * Update modules/repository/hooks.go Co-authored-by: silverwind <me@silverwind.io> * gofmt comment line Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Lauris BH <lauris@nix.lv>
This commit is contained in:
		@@ -8,6 +8,7 @@ import (
 | 
			
		||||
	"fmt"
 | 
			
		||||
	"os"
 | 
			
		||||
	"path/filepath"
 | 
			
		||||
	"runtime"
 | 
			
		||||
 | 
			
		||||
	"code.gitea.io/gitea/modules/git"
 | 
			
		||||
	"code.gitea.io/gitea/modules/setting"
 | 
			
		||||
@@ -153,6 +154,10 @@ func createDelegateHooks(repoPath string) (err error) {
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func checkExecutable(filename string) bool {
 | 
			
		||||
	// windows has no concept of a executable bit
 | 
			
		||||
	if runtime.GOOS == "windows" {
 | 
			
		||||
		return true
 | 
			
		||||
	}
 | 
			
		||||
	fileInfo, err := os.Stat(filename)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		return false
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user