From 0ea9d0dfad1c85953e289efc253eb76e4eab9c7b Mon Sep 17 00:00:00 2001 From: Lukas Domnick Date: Fri, 13 Sep 2013 08:01:12 +0200 Subject: [PATCH] Added Error Handling when no more commits are available --- src/GitList/Controller/NetworkController.php | 13 +++++++++++++ web/js/networkGraph.js | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/GitList/Controller/NetworkController.php b/src/GitList/Controller/NetworkController.php index 6f3e167..2814e9c 100644 --- a/src/GitList/Controller/NetworkController.php +++ b/src/GitList/Controller/NetworkController.php @@ -55,6 +55,7 @@ class NetworkController implements ControllerProviderInterface } $nextPageUrl = null; + if ($pager['last'] !== $pager['current']) { $nextPageUrl = $app['url_generator']->generate( 'networkData', @@ -65,6 +66,18 @@ class NetworkController implements ControllerProviderInterface ) ); } + + // when no commits are given, return an empty response - issue #369 + if( count($commits) === 0 ) { + return $app->json( array( + 'repo' => $repo, + 'commitishPath' => $commitishPath, + 'nextPage' => null, + 'start' => null, + 'commits' => $jsonFormattedCommits + ), 200 + ); + } return $app->json( array( 'repo' => $repo, diff --git a/web/js/networkGraph.js b/web/js/networkGraph.js index 3201b7b..b7bcea1 100644 --- a/web/js/networkGraph.js +++ b/web/js/networkGraph.js @@ -351,7 +351,7 @@ } function handleNoAvailableData() { - console.log('No Data available'); + window.console && console.log('No (more) Data available'); } var awaitedParents = {};