Nemcio/GitBucket
1
0
Fork 0
mirror of https://github.com/gitbucket/gitbucket.git synced 2025-11-07 22:15:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix emoji conversion

Browse Source
This commit is contained in:
Naoki Takezoe
2016-07-10 02:03:25 +09:00
parent 9c4cc12a02
commit fd181b9a0c
4 changed files with 50 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/test/scala/gitbucket/core/view/HelpersSpec.scala
View File

@@ -1,58 +1,62 @@
package gitbucket.core.view
import gitbucket.core.controller.Context
import gitbucket.core.service.RepositoryService.RepositoryInfo
import org.scalatest.FunSpec
import org.scalatest.mock.MockitoSugar
class HelpersSpec extends FunSpec {
class HelpersSpec extends FunSpec with MockitoSugar {
implicit val context = mock[Context]
import helpers._
describe("detect and render links") {
it("should pass identical string when no link is present") {
val before = "Description"
val after = detectAndRenderLinks(before).toString()
val after = detectAndRenderLinks(before)
assert(after == before)
}
it("should convert a single link") {
val before = "http://example.com"
val after = detectAndRenderLinks(before).toString()
val after = detectAndRenderLinks(before)
assert(after == """<a href="http://example.com">http://example.com</a>""")
}
it("should convert a single link within trailing text") {
val before = "Example Project. http://example.com"
val after = detectAndRenderLinks(before).toString()
val after = detectAndRenderLinks(before)
assert(after == """Example Project. <a href="http://example.com">http://example.com</a>""")
}
it("should convert a mulitple links within text") {
val before = "Example Project. http://example.com. (See also https://github.com/)"
val after = detectAndRenderLinks(before).toString()
val after = detectAndRenderLinks(before)
assert(after == """Example Project. <a href="http://example.com">http://example.com</a>. (See also <a href="https://github.com/">https://github.com/</a>)""")
}
it("should properly escape html metacharacters") {
val before = "<>&"
val after = detectAndRenderLinks(before).toString()
val after = detectAndRenderLinks(before)
assert(after == """&lt;&gt;&amp;""")
}
it("should escape html metacharacters adjacent to a link") {
val before = "<http://example.com>"
val after = detectAndRenderLinks(before).toString()
val after = detectAndRenderLinks(before)
assert(after == """&lt;<a href="http://example.com">http://example.com</a>&gt;""")
}
it("should stop link recognition at a metacharacter") {
val before = "http://exa<mple.com"
val after = detectAndRenderLinks(before).toString()
val after = detectAndRenderLinks(before)
assert(after == """<a href="http://exa">http://exa</a>&lt;mple.com""")
}
it("should make sure there are no double quotes in the href attribute") {
val before = "http://exa\"mple.com"
val after = detectAndRenderLinks(before).toString()
val after = detectAndRenderLinks(before)
assert(after == """<a href="http://exa&quot;mple.com">http://exa"mple.com</a>""")
}
}