diff --git a/src/main/scala/gitbucket/core/service/AccountService.scala b/src/main/scala/gitbucket/core/service/AccountService.scala index b44546851..78f97284b 100644 --- a/src/main/scala/gitbucket/core/service/AccountService.scala +++ b/src/main/scala/gitbucket/core/service/AccountService.scala @@ -47,7 +47,7 @@ trait AccountService { case _ => None } case account if (!account.isGroupAccount && account.password == sha1(password)) => Some(account) - } getOrElse None + }.flatten } /** diff --git a/src/main/scala/gitbucket/core/service/RepositoryCreationService.scala b/src/main/scala/gitbucket/core/service/RepositoryCreationService.scala index 5d553c867..fe8c8131a 100644 --- a/src/main/scala/gitbucket/core/service/RepositoryCreationService.scala +++ b/src/main/scala/gitbucket/core/service/RepositoryCreationService.scala @@ -40,7 +40,7 @@ object RepositoryCreationService { } def getCreationError(owner: String, repository: String): Option[String] = { - Option(Creating.remove(s"${owner}/${repository}")).getOrElse(None) + Option(Creating.remove(s"${owner}/${repository}")).flatten } } diff --git a/src/main/scala/gitbucket/core/service/RepositoryService.scala b/src/main/scala/gitbucket/core/service/RepositoryService.scala index da7ef91c0..72faa4b9b 100644 --- a/src/main/scala/gitbucket/core/service/RepositoryService.scala +++ b/src/main/scala/gitbucket/core/service/RepositoryService.scala @@ -766,7 +766,8 @@ trait RepositoryService { JGitUtil.getContentFromId(git, file.id, true).collect { case bytes if FileUtil.isText(bytes) => StringUtil.convertFromByteArray(bytes) } - } getOrElse None + } + .flatten } getOrElse "" } }