Merge pull request #2115 from gitbucket/fix-file-remove

BugFix for the file remove page
This commit is contained in:
Naoki Takezoe
2018-07-23 10:58:07 +09:00
committed by GitHub
4 changed files with 10 additions and 8 deletions

View File

@@ -427,8 +427,10 @@ trait RepositoryViewerControllerBase extends ControllerBase {
commit = form.commit commit = form.commit
) )
println(form.path)
redirect( redirect(
s"/${repository.owner}/${repository.name}/tree/${form.branch}${if (form.path.length == 0) "" else form.path}" s"/${repository.owner}/${repository.name}/tree/${form.branch}${if (form.path.length == 0) "" else "/" + form.path}"
) )
}) })

View File

@@ -103,8 +103,8 @@
} else { } else {
@if(diff.newContent != None || diff.oldContent != None){ @if(diff.newContent != None || diff.oldContent != None){
<div id="diffText-@i" class="diffText"></div> <div id="diffText-@i" class="diffText"></div>
<textarea id="newText-@i" style="display: none;" data-file-name="@diff.oldPath" data-val='@diff.newContent.getOrElse("")'></textarea> <input type="hidden" id="newText-@i" data-file-name="@diff.oldPath" value="@diff.newContent">
<textarea id="oldText-@i" style="display: none;" data-file-name="@diff.newPath" data-val='@diff.oldContent.getOrElse("")'></textarea> <input type="hidden" id="oldText-@i" data-file-name="@diff.newPath" value="@diff.oldContent">
} else { } else {
@if(diff.newIsImage || diff.oldIsImage){ @if(diff.newIsImage || diff.oldIsImage){
<div class="diff-image-render diff2up"> <div class="diff-image-render diff2up">

View File

@@ -32,8 +32,8 @@
<tr> <tr>
<td> <td>
<div id="diffText"></div> <div id="diffText"></div>
<textarea id="newText" style="display: none;" data-file-name="@fileName"></textarea> <input type="hidden" id="newText" data-file-name="@fileName" value="">
<textarea id="oldText" style="display: none;" data-file-name="@fileName">@content.content</textarea> <input type="hidden" id="oldText" data-file-name="@fileName" value="@content.content">
</td> </td>
</tr> </tr>
</table> </table>
@@ -46,7 +46,7 @@
<input type="text" name="message" class="form-control"/> <input type="text" name="message" class="form-control"/>
</div> </div>
<div style="text-align: right;"> <div style="text-align: right;">
<a href="@helpers.url(repository)/blob/@helpers.encodeRefName((branch :: pathList).mkString("/"))" class="btn btn-default">Cancel</a> <a href="@helpers.url(repository)/blob/@helpers.encodeRefName((branch :: pathList ::: List(fileName)).mkString("/"))" class="btn btn-default">Cancel</a>
<input type="submit" id="commitButton" class="btn btn-success" value="Commit changes"/> <input type="submit" id="commitButton" class="btn btn-success" value="Commit changes"/>
</div> </div>
</div> </div>

View File

@@ -78,9 +78,9 @@ function displayErrors(data, elem){
function diffUsingJS(oldTextId, newTextId, outputId, viewType, ignoreSpace) { function diffUsingJS(oldTextId, newTextId, outputId, viewType, ignoreSpace) {
var old = $('#'+oldTextId), head = $('#' + newTextId); var old = $('#'+oldTextId), head = $('#' + newTextId);
var render = new JsDiffRender({ var render = new JsDiffRender({
oldText: old.attr('data-val'), oldText: old.val(),
oldTextName: old.attr('data-file-name'), oldTextName: old.attr('data-file-name'),
newText: head.attr('data-val'), newText: head.val(),
newTextName: head.attr('data-file-name'), newTextName: head.attr('data-file-name'),
ignoreSpace: ignoreSpace, ignoreSpace: ignoreSpace,
contextSize: 4 contextSize: 4