From ebb57a80e3c09be9b47cf527282fe1fda1628d45 Mon Sep 17 00:00:00 2001 From: Hidetake Iwata Date: Mon, 21 Aug 2017 17:55:25 +0900 Subject: [PATCH] Fix branch API did not accept branch name with slash --- .../core/controller/ApiController.scala | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/main/scala/gitbucket/core/controller/ApiController.scala b/src/main/scala/gitbucket/core/controller/ApiController.scala index 42cffb30c..a68050867 100644 --- a/src/main/scala/gitbucket/core/controller/ApiController.scala +++ b/src/main/scala/gitbucket/core/controller/ApiController.scala @@ -5,14 +5,15 @@ import gitbucket.core.model._ import gitbucket.core.service.IssuesService.IssueSearchCondition import gitbucket.core.service.PullRequestService._ import gitbucket.core.service._ -import gitbucket.core.util.SyntaxSugars._ import gitbucket.core.util.Directory._ -import gitbucket.core.util.JGitUtil._ -import gitbucket.core.util._ import gitbucket.core.util.Implicits._ -import gitbucket.core.view.helpers.{renderMarkup, isRenderable} +import gitbucket.core.util.JGitUtil._ +import gitbucket.core.util.SyntaxSugars._ +import gitbucket.core.util._ +import gitbucket.core.view.helpers.{isRenderable, renderMarkup} import org.eclipse.jgit.api.Git -import org.scalatra.{NoContent, UnprocessableEntity, Created} +import org.scalatra.{Created, NoContent, UnprocessableEntity} + import scala.collection.JavaConverters._ class ApiController extends ApiControllerBase @@ -124,10 +125,10 @@ trait ApiControllerBase extends ControllerBase { /** * https://developer.github.com/v3/repos/branches/#get-branch */ - get ("/api/v3/repos/:owner/:repo/branches/:branch")(referrersOnly { repository => + get ("/api/v3/repos/:owner/:repo/branches/*")(referrersOnly { repository => //import gitbucket.core.api._ (for{ - branch <- params.get("branch") if repository.branchList.contains(branch) + branch <- params.get("splat") if repository.branchList.contains(branch) br <- getBranches(repository.owner, repository.name, repository.repository.defaultBranch, repository.repository.originUserName.isEmpty).find(_.name == branch) } yield { val protection = getProtectedBranchInfo(repository.owner, repository.name, branch) @@ -286,10 +287,10 @@ trait ApiControllerBase extends ControllerBase { /** * https://developer.github.com/v3/repos/#enabling-and-disabling-branch-protection */ - patch("/api/v3/repos/:owner/:repo/branches/:branch")(ownerOnly { repository => + patch("/api/v3/repos/:owner/:repo/branches/*")(ownerOnly { repository => import gitbucket.core.api._ (for{ - branch <- params.get("branch") if repository.branchList.contains(branch) + branch <- params.get("splat") if repository.branchList.contains(branch) protection <- extractFromJsonBody[ApiBranchProtection.EnablingAndDisabling].map(_.protection) br <- getBranches(repository.owner, repository.name, repository.repository.defaultBranch, repository.repository.originUserName.isEmpty).find(_.name == branch) } yield {