From ddeaffb705876b11cfb5f8dbd4b9960ec4c12369 Mon Sep 17 00:00:00 2001 From: Naoki Takezoe Date: Sat, 12 May 2018 16:37:30 +0900 Subject: [PATCH 1/3] Move Fork button to the header --- src/main/twirl/gitbucket/core/menu.scala.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/twirl/gitbucket/core/menu.scala.html b/src/main/twirl/gitbucket/core/menu.scala.html index 04d9de031..ac2d6f2af 100644 --- a/src/main/twirl/gitbucket/core/menu.scala.html +++ b/src/main/twirl/gitbucket/core/menu.scala.html @@ -53,9 +53,6 @@ @menuitem(externalWikiUrl, "wiki", "Wiki", "book") } } - @if(repository.repository.options.allowFork) { - @menuitem("/network/members", "fork", "Forks", "repo-forked", repository.forkedCount) - } @if(context.loginAccount.isDefined && (context.loginAccount.get.isAdmin || repository.managers.contains(context.loginAccount.get.userName))){ @menuitem("/settings", "settings", "Settings", "gear") } @@ -78,6 +75,9 @@ @gitbucket.core.plugin.PluginRegistry().getRepositoryHeaders.map { repositoryHeaderComponent => @repositoryHeaderComponent(repository, context) } + + Fork: @repository.forkedCount + @gitbucket.core.helper.html.repositoryicon(repository, true) @repository.owner / @repository.name From 6e4a203f815d8abd099e2c45e8fc0cd49672b352 Mon Sep 17 00:00:00 2001 From: Naoki Takezoe Date: Mon, 18 Jun 2018 16:02:12 +0900 Subject: [PATCH 2/3] Hide fork button if its option is disabled --- src/main/twirl/gitbucket/core/menu.scala.html | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/main/twirl/gitbucket/core/menu.scala.html b/src/main/twirl/gitbucket/core/menu.scala.html index ac2d6f2af..355fec6e6 100644 --- a/src/main/twirl/gitbucket/core/menu.scala.html +++ b/src/main/twirl/gitbucket/core/menu.scala.html @@ -75,9 +75,11 @@ @gitbucket.core.plugin.PluginRegistry().getRepositoryHeaders.map { repositoryHeaderComponent => @repositoryHeaderComponent(repository, context) } - - Fork: @repository.forkedCount - + @if(repository.repository.options.allowFork) { + + Fork: @repository.forkedCount + + } @gitbucket.core.helper.html.repositoryicon(repository, true) @repository.owner / @repository.name From e578f9548b6bf7eb7bf4dedd4ad524f263ab7071 Mon Sep 17 00:00:00 2001 From: Naoki Takezoe Date: Mon, 25 Jun 2018 19:42:57 +0900 Subject: [PATCH 3/3] Add a button to show forked repos to the fork account select dialog --- .../core/helper/forkrepository.scala.html | 33 ++++++++-------- src/main/twirl/gitbucket/core/menu.scala.html | 30 ++++++++++++-- .../gitbucket/core/repo/forked.scala.html | 39 +------------------ 3 files changed, 45 insertions(+), 57 deletions(-) diff --git a/src/main/twirl/gitbucket/core/helper/forkrepository.scala.html b/src/main/twirl/gitbucket/core/helper/forkrepository.scala.html index e7de31a7c..628428b01 100644 --- a/src/main/twirl/gitbucket/core/helper/forkrepository.scala.html +++ b/src/main/twirl/gitbucket/core/helper/forkrepository.scala.html @@ -1,23 +1,24 @@ @(repository: gitbucket.core.service.RepositoryService.RepositoryInfo, groupAndPerm: Seq[(String, Boolean)])(implicit context: gitbucket.core.controller.Context) @import gitbucket.core.view.helpers -

Where should we fork this repository?

+

+ Where should we fork this repository? + Show forks +

-
-
- @helpers.avatar(context.loginAccount.get.userName, 24) @@@context.loginAccount.get.userName -
- @for((groupName, isManager) <- groupAndPerm) { - @if(isManager) { -
- @helpers.avatar(groupName, 24) @@@groupName -
- } else { -
- @helpers.avatar(groupName, 24) @@@groupName -
- } - } +
+ @helpers.avatar(context.loginAccount.get.userName, 24) @@@context.loginAccount.get.userName
+ @for((groupName, isManager) <- groupAndPerm) { + @if(isManager) { +
+ @helpers.avatar(groupName, 24) @@@groupName +
+ } else { +
+ @helpers.avatar(groupName, 24) @@@groupName +
+ } + } diff --git a/src/main/twirl/gitbucket/core/menu.scala.html b/src/main/twirl/gitbucket/core/menu.scala.html index 355fec6e6..4873cb7de 100644 --- a/src/main/twirl/gitbucket/core/menu.scala.html +++ b/src/main/twirl/gitbucket/core/menu.scala.html @@ -76,10 +76,19 @@ @repositoryHeaderComponent(repository, context) } @if(repository.repository.options.allowFork) { - - Fork: @repository.forkedCount - + @if(context.loginAccount.isEmpty){ + + Fork: @repository.forkedCount + + } else { + + Fork: @repository.forkedCount + + } } +
@gitbucket.core.helper.html.repositoryicon(repository, true) @repository.owner / @repository.name @@ -97,4 +106,19 @@ @body + + diff --git a/src/main/twirl/gitbucket/core/repo/forked.scala.html b/src/main/twirl/gitbucket/core/repo/forked.scala.html index 1bd9988b6..b143526d4 100644 --- a/src/main/twirl/gitbucket/core/repo/forked.scala.html +++ b/src/main/twirl/gitbucket/core/repo/forked.scala.html @@ -5,23 +5,7 @@ @import gitbucket.core.view.helpers @gitbucket.core.html.main(s"${repository.owner}/${repository.name}", Some(repository)) { @gitbucket.core.html.menu("fork", repository){ -

- Forked repositories - @if(context.loginAccount.isEmpty){ - Fork - } else { - @if(groupNames.isEmpty) { - Fork - } else { - Fork - } - } -

- @if(context.loginAccount.isDefined && groupNames.isEmpty){ - - } +

Forked repositories

@if(originRepository.isDefined){ @helpers.avatarLink(originRepository.get.owner, 20) @@ -46,24 +30,3 @@ } } } -