Nemcio/GitBucket
1
0
Fork 0
mirror of https://github.com/gitbucket/gitbucket.git synced 2025-11-10 23:45:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

Encode parameters in url generation helpers

Browse Source
This commit is contained in:
Naoki Takezoe
2018-05-28 12:30:07 +09:00
parent df9c34bcec
commit d064ca85fb
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/scala/gitbucket/core/view/helpers.scala
View File

@@ -250,12 +250,12 @@ object helpers extends AvatarImageProvider with LinkConverter with RequestCache
* Generates the url to the repository. * Generates the url to the repository.
*/ */
def url(repository: RepositoryService.RepositoryInfo)(implicit context: Context): String = def url(repository: RepositoryService.RepositoryInfo)(implicit context: Context): String =
s"${context.path}/${repository.owner}/${repository.name}" s"${context.path}/${encodeRefName(repository.owner)}/${encodeRefName(repository.name)}"
/** /**
* Generates the url to the account page. * Generates the url to the account page.
*/ */
def url(userName: String)(implicit context: Context): String = s"${context.path}/${StringUtil.urlEncode(userName)}" def url(userName: String)(implicit context: Context): String = s"${context.path}/${encodeRefName(userName)}"
/** /**
* Returns the url to the root of assets. * Returns the url to the root of assets.
@@ -273,7 +273,7 @@ object helpers extends AvatarImageProvider with LinkConverter with RequestCache
* If user does not exist or disabled, this method returns user name as text without link. * If user does not exist or disabled, this method returns user name as text without link.
*/ */
def user(userName: String, mailAddress: String = "", styleClass: String = "")(implicit context: Context): Html = def user(userName: String, mailAddress: String = "", styleClass: String = "")(implicit context: Context): Html =
userWithContent(userName, mailAddress, styleClass)(Html(userName)) userWithContent(userName, mailAddress, styleClass)(Html(StringUtil.escapeHtml(userName)))
/** /**
* Generates the avatar link to the account page. * Generates the avatar link to the account page.