Nemcio/GitBucket
1
0
Fork 0
mirror of https://github.com/gitbucket/gitbucket.git synced 2025-11-08 22:45:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

(refs #464)Add drop tables capability when plugin is uninstalled

Browse Source
This commit is contained in:
Naoki Takezoe
2014-08-14 01:56:47 +09:00
parent e6b666a66a
commit b78d584d8a
1 changed files with 20 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/main/scala/plugin/PluginSystem.scala
View File

@@ -1,19 +1,19 @@
package plugin package plugin
import app.Context
import javax.servlet.http.{HttpServletResponse, HttpServletRequest} import javax.servlet.http.{HttpServletResponse, HttpServletRequest}
import org.slf4j.LoggerFactory import org.slf4j.LoggerFactory
import java.util.concurrent.atomic.AtomicBoolean import java.util.concurrent.atomic.AtomicBoolean
import util.Directory._ import util.Directory._
import util.ControlUtil._ import util.ControlUtil._
import org.apache.commons.io.{IOUtils, FileUtils} import org.apache.commons.io.{IOUtils, FileUtils}
import service.RepositoryService.RepositoryInfo
import Security._ import Security._
import service.PluginService import service.PluginService
import model.Profile._ import model.Profile._
import profile.simple._ import profile.simple._
import java.io.FileInputStream import java.io.FileInputStream
import java.sql.Connection import java.sql.Connection
import app.Context
import service.RepositoryService.RepositoryInfo
/** /**
* Provides extension points to plug-ins. * Provides extension points to plug-ins.
@@ -34,7 +34,19 @@ object PluginSystem extends PluginService {
def uninstall(id: String)(implicit session: Session): Unit = { def uninstall(id: String)(implicit session: Session): Unit = {
pluginsMap.remove(id) pluginsMap.remove(id)
// Delete from PLUGIN table
deletePlugin(id) deletePlugin(id)
// Drop tables
val pluginDir = new java.io.File(PluginHome)
val sqlFile = new java.io.File(pluginDir, s"${id}/sql/drop.sql")
if(sqlFile.exists){
val sql = IOUtils.toString(new FileInputStream(sqlFile), "UTF-8")
using(session.conn.createStatement()){ stmt =>
stmt.executeUpdate(sql)
}
}
} }
def repositories: List[PluginRepository] = repositoriesList.toList def repositories: List[PluginRepository] = repositoriesList.toList
@@ -63,7 +75,7 @@ object PluginSystem extends PluginService {
val scalaFile = new java.io.File(pluginDir, id + "/plugin.scala") val scalaFile = new java.io.File(pluginDir, id + "/plugin.scala")
if(scalaFile.exists && scalaFile.isFile){ if(scalaFile.exists && scalaFile.isFile){
val properties = new java.util.Properties() val properties = new java.util.Properties()
using(new java.io.FileInputStream(new java.io.File(pluginDir, id + "/plugin.properties"))){ in => using(new java.io.FileInputStream(new java.io.File(pluginDir, s"${id}/plugin.properties"))){ in =>
properties.load(in) properties.load(in)
} }
@@ -108,13 +120,15 @@ object PluginSystem extends PluginService {
val dim = current.split("\\.") val dim = current.split("\\.")
val currentVersion = Version(dim(0).toInt, dim(1).toInt) val currentVersion = Version(dim(0).toInt, dim(1).toInt)
val sqlDir = new java.io.File(pluginDir, pluginId + "/sql") val sqlDir = new java.io.File(pluginDir, s"${pluginId}/sql")
if(sqlDir.exists && sqlDir.isDirectory){ if(sqlDir.exists && sqlDir.isDirectory){
sqlDir.listFiles.filter(_.getName.endsWith(".sql")).map { file => sqlDir.listFiles.filter(_.getName.endsWith(".sql")).map { file =>
val array = file.getName.replaceFirst("\\.sql", "").split("_") val array = file.getName.replaceFirst("\\.sql", "").split("_")
Version(array(0).toInt, array(1).toInt) Version(array(0).toInt, array(1).toInt)
}.sorted.reverse.takeWhile(_ > currentVersion).reverse.foreach { version => }
val sqlFile = new java.io.File(pluginDir, pluginId + "/sql/" + version.major + "_" + version.minor + ".sql") .sorted.reverse.takeWhile(_ > currentVersion)
.reverse.foreach { version =>
val sqlFile = new java.io.File(pluginDir, s"${pluginId}/sql/${version.major}_${version.minor}.sql")
val sql = IOUtils.toString(new FileInputStream(sqlFile), "UTF-8") val sql = IOUtils.toString(new FileInputStream(sqlFile), "UTF-8")
using(conn.createStatement()){ stmt => using(conn.createStatement()){ stmt =>
stmt.executeUpdate(sql) stmt.executeUpdate(sql)