From 7ab260e68849114ef25e0b87008d96e5ec94e046 Mon Sep 17 00:00:00 2001
From: Naoki Takezoe <takezoe@gmail.com>
Date: Tue, 22 Mar 2016 14:22:20 +0900
Subject: [PATCH] Simplify issue and pull request creation form

---
 .../gitbucket/core/issues/create.scala.html   | 35 ++++++-------
 .../gitbucket/core/pulls/compare.scala.html   | 51 +++++++++----------
 .../webapp/assets/common/css/gitbucket.css    |  9 ----
 3 files changed, 38 insertions(+), 57 deletions(-)

diff --git a/src/main/twirl/gitbucket/core/issues/create.scala.html b/src/main/twirl/gitbucket/core/issues/create.scala.html
index 392377160..3e4110ada 100644
--- a/src/main/twirl/gitbucket/core/issues/create.scala.html
+++ b/src/main/twirl/gitbucket/core/issues/create.scala.html
@@ -10,26 +10,21 @@
     <form action="@url(repository)/issues/new" method="POST" validate="true" class="form-group">
       <div class="row">
         <div class="col-md-9">
-          <div class="issue-avatar-image">@avatarLink(loginAccount.get.userName, 48)</div>
-          <div class="panel panel-default issue-box">
-            <div class="panel-body">
-              <span id="error-title" class="error"></span>
-              <input type="text" id="issue-title" name="title" class="form-control" value="" placeholder="Title" autofocus/>
-              @helper.html.preview(
-                repository         = repository,
-                content            = "",
-                enableWikiLink     = false,
-                enableRefsLink     = true,
-                enableLineBreaks   = true,
-                enableTaskList     = true,
-                hasWritePermission = hasWritePermission,
-                style              = "height: 200px; max-height: 250px;",
-                elastic            = true
-              )
-              <div class="align-right">
-                <input type="submit" class="btn btn-success" value="Submit new issue"/>
-              </div>
-            </div>
+          <span id="error-title" class="error"></span>
+          <input type="text" id="issue-title" name="title" class="form-control" value="" placeholder="Title" style="margin-bottom: 6px;" autofocus/>
+          @helper.html.preview(
+            repository         = repository,
+            content            = "",
+            enableWikiLink     = false,
+            enableRefsLink     = true,
+            enableLineBreaks   = true,
+            enableTaskList     = true,
+            hasWritePermission = hasWritePermission,
+            style              = "height: 200px; max-height: 250px;",
+            elastic            = true
+          )
+          <div class="align-right">
+            <input type="submit" class="btn btn-success" value="Submit new issue"/>
           </div>
         </div>
         <div class="col-md-3">
diff --git a/src/main/twirl/gitbucket/core/pulls/compare.scala.html b/src/main/twirl/gitbucket/core/pulls/compare.scala.html
index 4d2c7c36a..0ba815f42 100644
--- a/src/main/twirl/gitbucket/core/pulls/compare.scala.html
+++ b/src/main/twirl/gitbucket/core/pulls/compare.scala.html
@@ -54,36 +54,31 @@
       <div id="pull-request-form" @*class="box"*@ style="display: none; margin-bottom: 20px;">
         <form method="POST" action="@path/@originRepository.owner/@originRepository.name/pulls/new" validate="true">
           <div class="row">
-            <div class="col-md-10">
-              <div class="issue-avatar-image">@avatarLink(loginAccount.get.userName, 48)</div>
-              <div class="panel panel-default issue-box">
-                <div class="panel-body">
-                  <span class="error" id="error-title"></span>
-                  <input type="text" name="title" class="form-control input-lg" placeholder="Title"/>
-                  @helper.html.preview(
-                    repository         = repository,
-                    content            = "",
-                    enableWikiLink     = false,
-                    enableRefsLink     = true,
-                    enableLineBreaks   = true,
-                    enableTaskList     = true,
-                    hasWritePermission = true,
-                    style              = "height: 200px;"
-                  )
-                  <input type="hidden" name="targetUserName" value="@originRepository.owner"/>
-                  <input type="hidden" name="targetBranch" value="@originId"/>
-                  <input type="hidden" name="requestUserName" value="@forkedRepository.owner"/>
-                  <input type="hidden" name="requestRepositoryName" value="@forkedRepository.name"/>
-                  <input type="hidden" name="requestBranch" value="@forkedId"/>
-                  <input type="hidden" name="commitIdFrom" value="@sourceId"/>
-                  <input type="hidden" name="commitIdTo" value="@commitId"/>
-                  <div class="align-right">
-                    <input type="submit" class="btn btn-success" value="Create pull request"/>
-                  </div>
-                </div>
+            <div class="col-md-9">
+              <span class="error" id="error-title"></span>
+              <input type="text" name="title" class="form-control" style="margin-bottom: 6px;" placeholder="Title"/>
+              @helper.html.preview(
+                repository         = repository,
+                content            = "",
+                enableWikiLink     = false,
+                enableRefsLink     = true,
+                enableLineBreaks   = true,
+                enableTaskList     = true,
+                hasWritePermission = true,
+                style              = "height: 200px;"
+              )
+              <input type="hidden" name="targetUserName" value="@originRepository.owner"/>
+              <input type="hidden" name="targetBranch" value="@originId"/>
+              <input type="hidden" name="requestUserName" value="@forkedRepository.owner"/>
+              <input type="hidden" name="requestRepositoryName" value="@forkedRepository.name"/>
+              <input type="hidden" name="requestBranch" value="@forkedId"/>
+              <input type="hidden" name="commitIdFrom" value="@sourceId"/>
+              <input type="hidden" name="commitIdTo" value="@commitId"/>
+              <div class="align-right">
+                <input type="submit" class="btn btn-success" value="Create pull request"/>
               </div>
             </div>
-            <div class="col-md-2">
+            <div class="col-md-3">
               @issues.html.issueinfo(None, Nil, Nil, collaborators, milestones.map((_, 0, 0)), labels, hasOriginWritePermission, repository)
             </div>
           </div>
diff --git a/src/main/webapp/assets/common/css/gitbucket.css b/src/main/webapp/assets/common/css/gitbucket.css
index 471ba7d39..2ac9a696c 100644
--- a/src/main/webapp/assets/common/css/gitbucket.css
+++ b/src/main/webapp/assets/common/css/gitbucket.css
@@ -874,11 +874,6 @@ div.issue-avatar-image {
   float: left;
 }
 
-div.issue-box {
-  margin-bottom: 5px;
-  margin-left: 50px;
-}
-
 div.issue-participants {
   margin-bottom: 15px;
   margin-left: 50px;
@@ -891,10 +886,6 @@ div.issue-comment-box, div.commit-comment-box {
   /*padding: 8px;*/
 }
 
-div.issue-box > div.panel-body {
-  padding: 4px;
-}
-
 div.issue-comment-box > div.panel-body,
 div.commit-comment-box > div.panel-body {
   padding: 8px;