From c49eff6e54a22764e6e740511887164b91f4caf2 Mon Sep 17 00:00:00 2001 From: Masaya Nakamura Date: Thu, 24 Nov 2016 17:35:49 +0900 Subject: [PATCH 1/2] Link milestone label to its issue list --- src/main/twirl/gitbucket/core/issues/issueinfo.scala.html | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/twirl/gitbucket/core/issues/issueinfo.scala.html b/src/main/twirl/gitbucket/core/issues/issueinfo.scala.html index 794b3f9a0..06796b682 100644 --- a/src/main/twirl/gitbucket/core/issues/issueinfo.scala.html +++ b/src/main/twirl/gitbucket/core/issues/issueinfo.scala.html @@ -74,7 +74,7 @@ @issue.flatMap(_.milestoneId).map { milestoneId => @milestones.collect { case (milestone, _, _) if(milestone.milestoneId == milestoneId) => - @milestone.title + @milestone.title } }.getOrElse { No milestone @@ -210,7 +210,8 @@ $(function(){ $('#label-milestone').html($('').text('No milestone')); $('#milestone-progress-area').empty(); } else { - $('#label-milestone').html($('').text(title)); + $('#label-milestone').html($('').text(title) + .attr('href', '@helpers.url(repository)/issues?milestone=' + title + '&state=open')); if(progress){ $('#milestone-progress-area').html(progress); } From 29f390e48c65a7350a3a20a8d80702568771e1bd Mon Sep 17 00:00:00 2001 From: Masaya Nakamura Date: Fri, 25 Nov 2016 11:14:51 +0900 Subject: [PATCH 2/2] Use helpers.urlEncode()/encodeURIComponent() --- src/main/twirl/gitbucket/core/issues/issueinfo.scala.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/twirl/gitbucket/core/issues/issueinfo.scala.html b/src/main/twirl/gitbucket/core/issues/issueinfo.scala.html index 06796b682..0e61892cc 100644 --- a/src/main/twirl/gitbucket/core/issues/issueinfo.scala.html +++ b/src/main/twirl/gitbucket/core/issues/issueinfo.scala.html @@ -74,7 +74,7 @@ @issue.flatMap(_.milestoneId).map { milestoneId => @milestones.collect { case (milestone, _, _) if(milestone.milestoneId == milestoneId) => - @milestone.title + @milestone.title } }.getOrElse { No milestone @@ -211,7 +211,7 @@ $(function(){ $('#milestone-progress-area').empty(); } else { $('#label-milestone').html($('').text(title) - .attr('href', '@helpers.url(repository)/issues?milestone=' + title + '&state=open')); + .attr('href', '@helpers.url(repository)/issues?milestone=' + encodeURIComponent(title) + '&state=open')); if(progress){ $('#milestone-progress-area').html(progress); }