From 3e4e278778a6e8a143b7c6da7a0a320e3f4b0d0e Mon Sep 17 00:00:00 2001 From: KOUNOIKE Yuusuke Date: Mon, 13 Mar 2017 23:58:49 +0900 Subject: [PATCH] Add Cache-Control header for _avatar and /plugin-assets contents for reduce network connection and CPU usage. --- src/main/scala/gitbucket/core/controller/AccountController.scala | 1 + src/main/scala/gitbucket/core/servlet/PluginAssetsServlet.scala | 1 + 2 files changed, 2 insertions(+) diff --git a/src/main/scala/gitbucket/core/controller/AccountController.scala b/src/main/scala/gitbucket/core/controller/AccountController.scala index 19c553a41..3d449f84e 100644 --- a/src/main/scala/gitbucket/core/controller/AccountController.scala +++ b/src/main/scala/gitbucket/core/controller/AccountController.scala @@ -149,6 +149,7 @@ trait AccountControllerBase extends AccountManagementControllerBase { get("/:userName/_avatar"){ val userName = params("userName") + response.setHeader("Cache-Control", "max-age=3600") getAccountByUserName(userName).flatMap(_.image).map { image => RawData(FileUtil.getMimeType(image), new java.io.File(getUserUploadDir(userName), image)) } getOrElse { diff --git a/src/main/scala/gitbucket/core/servlet/PluginAssetsServlet.scala b/src/main/scala/gitbucket/core/servlet/PluginAssetsServlet.scala index 0d43af3b1..6fe1ed34e 100644 --- a/src/main/scala/gitbucket/core/servlet/PluginAssetsServlet.scala +++ b/src/main/scala/gitbucket/core/servlet/PluginAssetsServlet.scala @@ -26,6 +26,7 @@ class PluginAssetsServlet extends HttpServlet { val bytes = IOUtils.toByteArray(in) resp.setContentLength(bytes.length) resp.setContentType(FileUtil.getContentType(path, bytes)) + resp.setHeader("Cache-Control", "max-age=3600") resp.getOutputStream.write(bytes) } finally { in.close()