From 373685b86d677bc6dcac9e334424fbe62a60ab75 Mon Sep 17 00:00:00 2001
From: takezoe <takezoe@gmail.com>
Date: Tue, 2 Jul 2013 10:57:37 +0900
Subject: [PATCH 1/3] Assign, milestone and labels are available in Issue
 creation.

---
 src/main/scala/app/IssuesController.scala  | 38 ++++++++++++++++++----
 src/main/scala/service/IssuesService.scala | 11 ++++---
 src/main/twirl/issues/create.scala.html    |  5 ++-
 3 files changed, 40 insertions(+), 14 deletions(-)

diff --git a/src/main/scala/app/IssuesController.scala b/src/main/scala/app/IssuesController.scala
index ebeac25bd..31ae34646 100644
--- a/src/main/scala/app/IssuesController.scala
+++ b/src/main/scala/app/IssuesController.scala
@@ -14,13 +14,26 @@ trait IssuesControllerBase extends ControllerBase {
   self: IssuesService with RepositoryService with LabelsService with MilestonesService
     with UsersOnlyAuthenticator =>
 
-  case class IssueForm(title: String, content: Option[String])
+  case class IssueCreateForm(title: String, content: Option[String],
+    assignedUserName: Option[String], milestoneId: Option[Int], labelNames: Option[String])
+
+  case class IssueEditForm(title: String, content: Option[String])
+
   case class CommentForm(issueId: Int, content: String)
 
-  val form = mapping(
+  val issueCreateForm = mapping(
+      "title"            -> trim(label("Title", text(required))),
+      "content"          -> trim(optional(text())),
+      "assignedUserName" -> trim(optional(text())),
+      "milestoneId"      -> trim(optional(number())),
+      "labelNames"       -> trim(optional(text()))
+    )(IssueCreateForm.apply)
+
+  val issueEditForm = mapping(
       "title"   -> trim(label("Title", text(required))),
       "content" -> trim(optional(text()))
-    )(IssueForm.apply)
+    )(IssueEditForm.apply)
+
   val commentForm = mapping(
       "issueId" -> label("Issue Id", number()),
       "content" -> trim(label("Comment", text(required)))
@@ -63,16 +76,27 @@ trait IssuesControllerBase extends ControllerBase {
   })
 
   // TODO requires users only and readable repository checking
-  post("/:owner/:repository/issues/new", form)( usersOnly { form =>
+  post("/:owner/:repository/issues/new", issueCreateForm)( usersOnly { form =>
     val owner = params("owner")
     val repository = params("repository")
 
-    redirect("/%s/%s/issues/%d".format(owner, repository,
-        createIssue(owner, repository, context.loginAccount.get.userName, form.title, form.content)))
+    val issueId = createIssue(owner, repository, context.loginAccount.get.userName,
+      form.title, form.content, form.assignedUserName, form.milestoneId)
+
+    form.labelNames.map { value =>
+      val labels = getLabels(owner, repository)
+      value.split(",").foreach { labelName =>
+        labels.find(_.labelName == labelName).map { label =>
+          registerIssueLabel(owner, repository, issueId, label.labelId)
+        }
+      }
+    }
+
+    redirect("/%s/%s/issues/%d".format(owner, repository, issueId))
   })
 
   // TODO Authenticator
-  ajaxPost("/:owner/:repository/issues/edit/:id", form){ form =>
+  ajaxPost("/:owner/:repository/issues/edit/:id", issueEditForm){ form =>
     val owner = params("owner")
     val repository = params("repository")
     val issueId = params("id").toInt
diff --git a/src/main/scala/service/IssuesService.scala b/src/main/scala/service/IssuesService.scala
index 424afd41a..167fa4676 100644
--- a/src/main/scala/service/IssuesService.scala
+++ b/src/main/scala/service/IssuesService.scala
@@ -160,8 +160,8 @@ trait IssuesService {
       } exists, condition.labels.nonEmpty)
     }
 
-  def createIssue(owner: String, repository: String, loginUser: String,
-      title: String, content: Option[String]) =
+  def createIssue(owner: String, repository: String, loginUser: String, title: String, content: Option[String],
+                  assignedUserName: Option[String], milestoneId: Option[Int]) =
     // next id number
     sql"SELECT ISSUE_ID + 1 FROM ISSUE_ID WHERE USER_NAME = $owner AND REPOSITORY_NAME = $repository FOR UPDATE".as[Int]
         .firstOption.filter { id =>
@@ -170,8 +170,8 @@ trait IssuesService {
           repository,
           id,
           loginUser,
-          None,
-          None,
+          milestoneId,
+          assignedUserName,
           title,
           content,
           false,
@@ -184,6 +184,9 @@ trait IssuesService {
       }.map(_.issueId).update(id) > 0
     } get
 
+  def registerIssueLabel(owner: String, repository: String, issueId: Int, labelId: Int): Unit =
+    IssueLabels.* insert (IssueLabel(owner, repository, issueId, labelId))
+
   def createComment(owner: String, repository: String, loginUser: String,
       issueId: Int, content: String, action: Option[String]) =
     IssueComments.autoInc insert (
diff --git a/src/main/twirl/issues/create.scala.html b/src/main/twirl/issues/create.scala.html
index 2512f279b..123cde04f 100644
--- a/src/main/twirl/issues/create.scala.html
+++ b/src/main/twirl/issues/create.scala.html
@@ -4,10 +4,9 @@
 @html.main("New Issue - " + repository.owner + "/" + repository.name){
   @html.header("issues", repository)
   @tab("", repository)
-
+  <form action="@url(repository)/issues/new" method="POST" validate="true">
   <div class="row-fluid">
     <div class="span9">
-      <form action="@url(repository)/issues/new" method="POST" validate="true">
       <div class="box">
         <div class="box-content">
           <span id="error-title" class="error"></span>
@@ -51,7 +50,6 @@
         </div>
       </div>
       <input type="submit" class="btn btn-success" value="Submit new issue"/>
-      </form>
     </div>
     <div class="span3">
       <strong>Add Labels</strong>
@@ -72,6 +70,7 @@
       </div>
     </div>
   </div>
+  </form>
 }
 <script>
 $(function(){

From 312dbc3ae9d4350fafc93cbcd683ab0f840de04e Mon Sep 17 00:00:00 2001
From: takezoe <takezoe@gmail.com>
Date: Tue, 2 Jul 2013 11:02:38 +0900
Subject: [PATCH 2/3] Fix label presentation.

---
 src/main/twirl/issues/list.scala.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/twirl/issues/list.scala.html b/src/main/twirl/issues/list.scala.html
index eb148ad7a..0834e7e79 100644
--- a/src/main/twirl/issues/list.scala.html
+++ b/src/main/twirl/issues/list.scala.html
@@ -131,7 +131,7 @@
           <td>
             <a href="@url(repository)/issues/@issue.issueId" class="issue-title">@issue.title</a>
             @labels.map { label =>
-              <span class="label-color" style="background-color: #@label.color; color: #@label.fontColor;">@label.labelName</span>
+              <span class="label-color small" style="background-color: #@label.color; color: #@label.fontColor; padding-left: 4px; padding-right: 4px">@label.labelName</span>
             }
             <span class="pull-right muted">#@issue.issueId</span>
             <div class="small muted">

From f2a4792008aa64588e8b57404e85cc9effc6e51b Mon Sep 17 00:00:00 2001
From: takezoe <takezoe@gmail.com>
Date: Tue, 2 Jul 2013 11:06:22 +0900
Subject: [PATCH 3/3] Add TODO.

---
 src/main/scala/app/IssuesController.scala | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/main/scala/app/IssuesController.scala b/src/main/scala/app/IssuesController.scala
index 31ae34646..cfb940417 100644
--- a/src/main/scala/app/IssuesController.scala
+++ b/src/main/scala/app/IssuesController.scala
@@ -80,9 +80,11 @@ trait IssuesControllerBase extends ControllerBase {
     val owner = params("owner")
     val repository = params("repository")
 
+    // TODO User and milestone are assigned by only collaborators.
     val issueId = createIssue(owner, repository, context.loginAccount.get.userName,
       form.title, form.content, form.assignedUserName, form.milestoneId)
 
+    // TODO labels are assigned by only collaborators
     form.labelNames.map { value =>
       val labels = getLabels(owner, repository)
       value.split(",").foreach { labelName =>