From 1d6507defba09a26ad806bf01fb425632f1ea258 Mon Sep 17 00:00:00 2001 From: takezoe Date: Tue, 2 Jul 2013 14:25:15 +0900 Subject: [PATCH] Move common view templates to 'helper' package. --- .../twirl/{ => helper}/datepicker.scala.html | 0 src/main/twirl/{ => helper}/diff.scala.html | 0 src/main/twirl/helper/dropdown.scala.html | 10 +++++ .../twirl/{ => helper}/paginator.scala.html | 0 .../twirl/{ => helper}/preview.scala.html | 0 src/main/twirl/issues/create.scala.html | 42 +++++++------------ src/main/twirl/issues/issue.scala.html | 2 +- src/main/twirl/issues/list.scala.html | 28 +++++-------- .../twirl/issues/milestones/edit.scala.html | 2 +- src/main/twirl/repo/commit.scala.html | 2 +- src/main/twirl/wiki/compare.scala.html | 2 +- src/main/twirl/wiki/edit.scala.html | 2 +- 12 files changed, 41 insertions(+), 49 deletions(-) rename src/main/twirl/{ => helper}/datepicker.scala.html (100%) rename src/main/twirl/{ => helper}/diff.scala.html (100%) create mode 100644 src/main/twirl/helper/dropdown.scala.html rename src/main/twirl/{ => helper}/paginator.scala.html (100%) rename src/main/twirl/{ => helper}/preview.scala.html (100%) diff --git a/src/main/twirl/datepicker.scala.html b/src/main/twirl/helper/datepicker.scala.html similarity index 100% rename from src/main/twirl/datepicker.scala.html rename to src/main/twirl/helper/datepicker.scala.html diff --git a/src/main/twirl/diff.scala.html b/src/main/twirl/helper/diff.scala.html similarity index 100% rename from src/main/twirl/diff.scala.html rename to src/main/twirl/helper/diff.scala.html diff --git a/src/main/twirl/helper/dropdown.scala.html b/src/main/twirl/helper/dropdown.scala.html new file mode 100644 index 000000000..d5e2c11c1 --- /dev/null +++ b/src/main/twirl/helper/dropdown.scala.html @@ -0,0 +1,10 @@ +@(body: Html) +
+ + +
diff --git a/src/main/twirl/paginator.scala.html b/src/main/twirl/helper/paginator.scala.html similarity index 100% rename from src/main/twirl/paginator.scala.html rename to src/main/twirl/helper/paginator.scala.html diff --git a/src/main/twirl/preview.scala.html b/src/main/twirl/helper/preview.scala.html similarity index 100% rename from src/main/twirl/preview.scala.html rename to src/main/twirl/helper/preview.scala.html diff --git a/src/main/twirl/issues/create.scala.html b/src/main/twirl/issues/create.scala.html index 123cde04f..9e4043070 100644 --- a/src/main/twirl/issues/create.scala.html +++ b/src/main/twirl/issues/create.scala.html @@ -14,39 +14,27 @@
No one is assigned -
- - -
+ @helper.html.dropdown { +
  • Clear assignee
  • +
  • + @collaborators.map { collaborator => +
  • @collaborator
  • + } + }
    No milestone -
    - - -
    + @helper.html.dropdown { +
  • No milestone
  • +
  • + @milestones.map { milestone => +
  • @milestone.title
  • + } + }

    - @html.preview(repository, "", false, true, true, "width: 650px; height: 200px;") + @helper.html.preview(repository, "", false, true, true, "width: 650px; height: 200px;") diff --git a/src/main/twirl/issues/issue.scala.html b/src/main/twirl/issues/issue.scala.html index 749a703b1..5eb863453 100644 --- a/src/main/twirl/issues/issue.scala.html +++ b/src/main/twirl/issues/issue.scala.html @@ -48,7 +48,7 @@
    - @html.preview(repository, "", false, true, true, "width: 730px; height: 100px;") + @helper.html.preview(repository, "", false, true, true, "width: 730px; height: 100px;")
    diff --git a/src/main/twirl/issues/list.scala.html b/src/main/twirl/issues/list.scala.html index 0834e7e79..51fba6f9b 100644 --- a/src/main/twirl/issues/list.scala.html +++ b/src/main/twirl/issues/list.scala.html @@ -41,21 +41,15 @@ Milestone: @milestones.find(_.milestoneId == condition.milestoneId.get.get).map(_.title) } } -
    - - -
    + @helper.html.dropdown { + @if(condition.milestoneId.isDefined){ +
  • Clear milestone filter
  • + } +
  • Issues with no milestone
  • + @milestones.map { milestone => +
  • @milestone.title
  • + } + } @if(condition.milestoneId.isDefined && condition.milestoneId.get.isDefined){
    @if(closedCount > 0){ @@ -97,7 +91,7 @@ }
    - @html.paginator(page, (if(condition.state == "open") openCount else closedCount), service.IssuesService.IssueLimit, 7, condition.toURL) + @helper.html.paginator(page, (if(condition.state == "open") openCount else closedCount), service.IssuesService.IssueLimit, 7, condition.toURL)
    @openCount Open @@ -160,7 +154,7 @@ }
    - @html.paginator(page, (if(condition.state == "open") openCount else closedCount), service.IssuesService.IssueLimit, 10, condition.toURL) + @helper.html.paginator(page, (if(condition.state == "open") openCount else closedCount), service.IssuesService.IssueLimit, 10, condition.toURL)
    diff --git a/src/main/twirl/issues/milestones/edit.scala.html b/src/main/twirl/issues/milestones/edit.scala.html index 1e2513f64..02461c3d7 100644 --- a/src/main/twirl/issues/milestones/edit.scala.html +++ b/src/main/twirl/issues/milestones/edit.scala.html @@ -17,7 +17,7 @@
    - @html.datepicker("dueDate", milestone.flatMap(_.dueDate)) + @helper.html.datepicker("dueDate", milestone.flatMap(_.dueDate))

    diff --git a/src/main/twirl/repo/commit.scala.html b/src/main/twirl/repo/commit.scala.html index f646de314..479baa462 100644 --- a/src/main/twirl/repo/commit.scala.html +++ b/src/main/twirl/repo/commit.scala.html @@ -93,7 +93,7 @@ } - @html.diff(diffs, repository, Some(commit.id)) + @helper.html.diff(diffs, repository, Some(commit.id)) }