Improve pull request comments presentation

This commit is contained in:
Naoki Takezoe
2018-04-18 18:47:00 +09:00
parent 255aa7476c
commit 1a0f282f23

View File

@@ -1,6 +1,6 @@
package gitbucket.core.controller package gitbucket.core.controller
import gitbucket.core.model.WebHook import gitbucket.core.model.{CommitComment, IssueComment, WebHook}
import gitbucket.core.plugin.PluginRegistry import gitbucket.core.plugin.PluginRegistry
import gitbucket.core.pulls.html import gitbucket.core.pulls.html
import gitbucket.core.service.CommitStatusService import gitbucket.core.service.CommitStatusService
@@ -117,14 +117,25 @@ trait PullRequestsControllerBase extends ControllerBase {
git => git =>
val (commits, diffs) = val (commits, diffs) =
getRequestCompareInfo(owner, name, pullreq.commitIdFrom, owner, name, pullreq.commitIdTo) getRequestCompareInfo(owner, name, pullreq.commitIdFrom, owner, name, pullreq.commitIdTo)
html.pullreq(
issue, val comments = (commits.flatten
pullreq,
(commits.flatten
.map(commit => getCommitComments(owner, name, commit.id, true)) .map(commit => getCommitComments(owner, name, commit.id, true))
.flatten .flatten
.toList ::: getComments(owner, name, issueId)) .toList ::: getComments(owner, name, issueId))
.sortWith((a, b) => a.registeredDate before b.registeredDate), .groupBy {
case x: IssueComment => (None, None, None)
case x: CommitComment => (x.fileName, x.oldLine, x.newLine)
}
.toSeq
.sortWith {
case ((key1, comments1), (key2, comments2)) =>
comments1.head.registeredDate before comments2.head.registeredDate
}
html.pullreq(
issue,
pullreq,
comments,
getIssueLabels(owner, name, issueId), getIssueLabels(owner, name, issueId),
getAssignableUserNames(owner, name), getAssignableUserNames(owner, name),
getMilestonesWithIssueCount(owner, name), getMilestonesWithIssueCount(owner, name),