From ae38ac4de8dedfdb1316b0739943a03f27c1c30a Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sat, 14 Mar 2026 09:11:59 +0000 Subject: [PATCH 1/2] fix(deps): update dependency knockout to v3.5.2 --- apps/client/package.json | 2 +- pnpm-lock.yaml | 14 +++++--------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/apps/client/package.json b/apps/client/package.json index 521c9fb0aa..a908112ff6 100644 --- a/apps/client/package.json +++ b/apps/client/package.json @@ -59,7 +59,7 @@ "jquery.fancytree": "2.38.5", "jsplumb": "2.15.6", "katex": "0.16.38", - "knockout": "3.5.1", + "knockout": "3.5.2", "leaflet": "1.9.4", "leaflet-gpx": "2.2.0", "mark.js": "8.11.1", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index e7761a6608..19c01ddf02 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -312,8 +312,8 @@ importers: specifier: 0.16.38 version: 0.16.38 knockout: - specifier: 3.5.1 - version: 3.5.1 + specifier: 3.5.2 + version: 3.5.2 leaflet: specifier: 1.9.4 version: 1.9.4 @@ -11475,8 +11475,8 @@ packages: resolution: {integrity: sha512-dhG34DXATL5hSxJbIexCft8FChFXtmskoZYnoPWjXQuebWYCNkVeV3KkGegCK9CP1oswI/vQibS2GY7Em/sJJA==} engines: {node: '>= 8'} - knockout@3.5.1: - resolution: {integrity: sha512-wRJ9I4az0QcsH7A4v4l0enUpkS++MBx0BnL/68KaLzJg7x1qmbjSlwEoCNol7KTYZ+pmtI7Eh2J0Nu6/2Z5J/Q==} + knockout@3.5.2: + resolution: {integrity: sha512-AcJS2PqsYspjtOAlnnVS8hAuBnHMEqRVEwdvmQTeXj/9zfjV//KHurzdYc8MtBd/Pu8bZLMGHc7x0cj8qUvKxQ==} known-css-properties@0.37.0: resolution: {integrity: sha512-JCDrsP4Z1Sb9JwG0aJ8Eo2r7k4Ou5MwmThS/6lcIe1ICyb7UBJKGRIUUdqc2ASdE/42lgz6zFUnzAIhtXnBVrQ==} @@ -17501,8 +17501,6 @@ snapshots: '@ckeditor/ckeditor5-utils': 47.4.0 ckeditor5: 47.4.0 es-toolkit: 1.39.5 - transitivePeerDependencies: - - supports-color '@ckeditor/ckeditor5-editor-multi-root@47.4.0': dependencies: @@ -17552,8 +17550,6 @@ snapshots: '@ckeditor/ckeditor5-core': 47.4.0 '@ckeditor/ckeditor5-engine': 47.4.0 '@ckeditor/ckeditor5-utils': 47.4.0 - transitivePeerDependencies: - - supports-color '@ckeditor/ckeditor5-essentials@47.4.0': dependencies: @@ -29899,7 +29895,7 @@ snapshots: klona@2.0.6: {} - knockout@3.5.1: {} + knockout@3.5.2: {} known-css-properties@0.37.0: {} From 5b16ff8be1ba47aee129dc28622dd98ec7928282 Mon Sep 17 00:00:00 2001 From: Elian Doran Date: Sat, 14 Mar 2026 11:32:44 +0200 Subject: [PATCH 2/2] chore(client): fix type error after update of knockout --- apps/client/src/setup.ts | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/apps/client/src/setup.ts b/apps/client/src/setup.ts index 29fbd15c00..3b3a40c336 100644 --- a/apps/client/src/setup.ts +++ b/apps/client/src/setup.ts @@ -1,7 +1,9 @@ import "jquery"; -import utils from "./services/utils.js"; + import ko from "knockout"; +import utils from "./services/utils.js"; + // TriliumNextTODO: properly make use of below types // type SetupModelSetupType = "new-document" | "sync-from-desktop" | "sync-from-server" | ""; // type SetupModelStep = "sync-in-progress" | "setup-type" | "new-document-in-progress" | "sync-from-desktop"; @@ -74,9 +76,9 @@ class SetupModel { // not using server.js because it loads too many dependencies const resp = await $.post("api/setup/sync-from-server", { - syncServerHost: syncServerHost, - syncProxy: syncProxy, - password: password + syncServerHost, + syncProxy, + password }); if (resp.result === "success") { @@ -123,6 +125,8 @@ function getSyncInProgress() { } addEventListener("DOMContentLoaded", (event) => { - ko.applyBindings(new SetupModel(getSyncInProgress()), document.getElementById("setup-dialog")); + const rootNode = document.getElementById("setup-dialog"); + if (!rootNode) return; + ko.applyBindings(new SetupModel(getSyncInProgress()), rootNode); $("#setup-dialog").show(); });