From bf0213907e5e1ac4f8b775884693c5c48e9ca1a8 Mon Sep 17 00:00:00 2001
From: Elian Doran <contact@eliandoran.me>
Date: Fri, 22 Aug 2025 15:40:15 +0300
Subject: [PATCH] chore(react/ribbon): finalize language switcher

---
 apps/client/src/widgets/note_language.ts      | 103 ------------------
 apps/client/src/widgets/react/FormToggle.tsx  |  10 +-
 apps/client/src/widgets/react/HelpButton.tsx  |  21 ++++
 .../src/widgets/ribbon/BasicPropertiesTab.tsx |  14 ++-
 .../ribbon_widgets/basic_properties.ts        |  72 ------------
 5 files changed, 34 insertions(+), 186 deletions(-)
 delete mode 100644 apps/client/src/widgets/note_language.ts
 create mode 100644 apps/client/src/widgets/react/HelpButton.tsx
 delete mode 100644 apps/client/src/widgets/ribbon_widgets/basic_properties.ts

diff --git a/apps/client/src/widgets/note_language.ts b/apps/client/src/widgets/note_language.ts
deleted file mode 100644
index b6be77230..000000000
--- a/apps/client/src/widgets/note_language.ts
+++ /dev/null
@@ -1,103 +0,0 @@
-import { Dropdown } from "bootstrap";
-import NoteContextAwareWidget from "./note_context_aware_widget.js";
-import { getAvailableLocales, getLocaleById, t } from "../services/i18n.js";
-import type { EventData } from "../components/app_context.js";
-import type FNote from "../entities/fnote.js";
-import attributes from "../services/attributes.js";
-import type { Locale } from "@triliumnext/commons";
-import options from "../services/options.js";
-import appContext from "../components/app_context.js";
-
-const TPL = /*html*/`\
-<div class="dropdown note-language-widget">
-    <button type="button" data-bs-toggle="dropdown" aria-haspopup="true" aria-expanded="false" class="btn btn-sm dropdown-toggle select-button note-language-button">
-        <span class="note-language-desc"></span>
-        <span class="caret"></span>
-    </button>
-    <div class="note-language-dropdown dropdown-menu dropdown-menu-left tn-dropdown-list"></div>
-    <button class="language-help-button icon-action bx bx-help-circle" type="button" data-in-app-help="B0lcI9xz1r8K" title="${t("open-help-page")}"></button>
-
-    <style>
-        .note-language-widget {
-            display: flex;
-            align-items: center;
-        }
-
-        .language-help-button {
-            margin-left: 4px;
-        }
-
-        .note-language-dropdown [dir=rtl] {
-            text-align: right;
-        }
-
-        .dropdown-item.rtl > .check {
-            order: 1;
-        }
-    </style>
-</div>
-`;
-
-export default class NoteLanguageWidget extends NoteContextAwareWidget {
-
-    private dropdown!: Dropdown;
-    private $noteLanguageDropdown!: JQuery<HTMLElement>;
-    private $noteLanguageDesc!: JQuery<HTMLElement>;
-    private locales: (Locale | "---")[];
-    private currentLanguageId?: string;
-
-    constructor() {
-        super();
-        this.locales = NoteLanguageWidget.#buildLocales();
-    }
-
-    doRender() {
-        this.$widget = $(TPL);
-        this.dropdown = Dropdown.getOrCreateInstance(this.$widget.find("[data-bs-toggle='dropdown']")[0]);
-
-        this.$noteLanguageDropdown = this.$widget.find(".note-language-dropdown")
-        this.$noteLanguageDesc = this.$widget.find(".note-language-desc");
-    }
-
-    renderDropdown() {
-        this.$noteLanguageDropdown.empty();
-
-        if (!this.note) {
-            return;
-        }
-
-        const $configureLink = $('<a class="dropdown-item">')
-            .on("click", () => ));
-        this.$noteLanguageDropdown.append($configureLink);
-    }
-
-    async save(languageId: string) {
-        if (!this.note) {
-            return;
-        }
-
-        attributes.setAttribute(this.note, "label", "language", languageId);
-    }
-
-    async refreshWithNote(note: FNote) {
-        const language = getLocaleById(currentLanguageId) ?? DEFAULT_LOCALE;
-        this.currentLanguageId = currentLanguageId;
-        this.$noteLanguageDesc.text(language.name);
-        this.dropdown.hide();
-    }
-
-    async entitiesReloadedEvent({ loadResults }: EventData<"entitiesReloaded">) {
-        if (loadResults.isOptionReloaded("languages")) {
-            this.locales = NoteLanguageWidget.#buildLocales();
-        }
-
-        if (loadResults.getAttributeRows().find((a) => a.noteId === this.noteId && a.name === "language")) {
-            this.refresh();
-        }
-    }
-
-    static #buildLocales() {
-
-    }
-
-}
diff --git a/apps/client/src/widgets/react/FormToggle.tsx b/apps/client/src/widgets/react/FormToggle.tsx
index c41ea6750..813947ac6 100644
--- a/apps/client/src/widgets/react/FormToggle.tsx
+++ b/apps/client/src/widgets/react/FormToggle.tsx
@@ -1,6 +1,7 @@
 import { t } from "../../services/i18n";
 import { openInAppHelpFromUrl } from "../../services/utils";
 import "./FormToggle.css";
+import HelpButton from "./HelpButton";
 
 interface FormToggleProps {
     currentValue: boolean | null;
@@ -36,14 +37,7 @@ export default function FormToggle({ currentValue, helpPage, switchOnName, switc
                 </div>
             </label>
 
-            { helpPage && (
-                <button
-                    class="switch-help-button icon-action bx bx-help-circle"
-                    type="button"
-                    onClick={() => openInAppHelpFromUrl(helpPage)}
-                    title={t("open-help-page")}
-                />
-            )}
+            { helpPage && <HelpButton className="switch-help-button" helpPage={helpPage} />}
         </div>
     )
 }
\ No newline at end of file
diff --git a/apps/client/src/widgets/react/HelpButton.tsx b/apps/client/src/widgets/react/HelpButton.tsx
new file mode 100644
index 000000000..065252264
--- /dev/null
+++ b/apps/client/src/widgets/react/HelpButton.tsx
@@ -0,0 +1,21 @@
+import { CSSProperties } from "preact/compat";
+import { t } from "../../services/i18n";
+import { openInAppHelpFromUrl } from "../../services/utils";
+
+interface HelpButtonProps {
+    className?: string;
+    helpPage: string;
+    style?: CSSProperties;
+}
+
+export default function HelpButton({ className, helpPage, style }: HelpButtonProps) {
+    return (
+        <button
+            class={`${className ?? ""} icon-action bx bx-help-circle`}
+            type="button"
+            onClick={() => openInAppHelpFromUrl(helpPage)}
+            title={t("open-help-page")}
+            style={style}
+        />
+    );
+}
\ No newline at end of file
diff --git a/apps/client/src/widgets/ribbon/BasicPropertiesTab.tsx b/apps/client/src/widgets/ribbon/BasicPropertiesTab.tsx
index f82223c0a..8c34ccff1 100644
--- a/apps/client/src/widgets/ribbon/BasicPropertiesTab.tsx
+++ b/apps/client/src/widgets/ribbon/BasicPropertiesTab.tsx
@@ -16,6 +16,7 @@ import toast from "../../services/toast";
 import branches from "../../services/branches";
 import sync from "../../services/sync";
 import appContext from "../../components/app_context";
+import HelpButton from "../react/HelpButton";
 
 export default function BasicPropertiesTab() {
     const { note } = useNoteContext();
@@ -307,10 +308,15 @@ function NoteLanguageSwitch({ note }: { note?: FNote | null }) {
         return locales;
     }, [ languages ]);
 
-    
-    return (
+    const currentLocale = useMemo(() => {
+        return locales.find(locale => typeof locale === "object" && locale.id === currentNoteLanguage) as Locale | undefined;
+    }, [ currentNoteLanguage ]);
+
+    return (        
         <div className="note-language-container">
-            <Dropdown>
+            <span>{t("basic_properties.language")}:</span>
+            &nbsp;
+            <Dropdown text={currentLocale?.name ?? DEFAULT_LOCALE.name}>
                 {locales.map(locale => {
                     if (typeof locale === "object") {
                         const checked = locale.id === (currentNoteLanguage ?? "");
@@ -328,6 +334,8 @@ function NoteLanguageSwitch({ note }: { note?: FNote | null }) {
                     onClick={() => appContext.tabManager.openContextWithNote("_optionsLocalization", { activate: true })}
                 >{t("note_language.configure-languages")}</FormListItem>           
             </Dropdown>
+
+            <HelpButton helpPage="B0lcI9xz1r8K" style={{ marginLeft: "4px" }} />
         </div>
     )
 }
diff --git a/apps/client/src/widgets/ribbon_widgets/basic_properties.ts b/apps/client/src/widgets/ribbon_widgets/basic_properties.ts
deleted file mode 100644
index 5f0fc9ffa..000000000
--- a/apps/client/src/widgets/ribbon_widgets/basic_properties.ts
+++ /dev/null
@@ -1,72 +0,0 @@
-import NoteContextAwareWidget from "../note_context_aware_widget.js";
-import NoteTypeWidget from "../note_type.js";
-import ProtectedNoteSwitchWidget from "../protected_note_switch.js";
-import EditabilitySelectWidget from "../editability_select.js";
-import BookmarkSwitchWidget from "../bookmark_switch.js";
-import SharedSwitchWidget from "../shared_switch.js";
-import { t } from "../../services/i18n.js";
-import TemplateSwitchWidget from "../template_switch.js";
-import type FNote from "../../entities/fnote.js";
-import NoteLanguageWidget from "../note_language.js";
-
-const TPL = /*html*/`
-    <div class="note-language-container">
-        <span>${t("basic_properties.language")}:</span> &nbsp;
-    </div>
-`;
-
-export default class BasicPropertiesWidget extends NoteContextAwareWidget {
-
-    private sharedSwitchWidget: SharedSwitchWidget;
-    private templateSwitchWidget: TemplateSwitchWidget;
-    private noteLanguageWidget: NoteLanguageWidget;
-
-    constructor() {
-        super();
-
-        this.templateSwitchWidget = new TemplateSwitchWidget().contentSized();
-        this.noteLanguageWidget = new NoteLanguageWidget().contentSized();
-
-        this.child(
-            this.sharedSwitchWidget,
-            this.templateSwitchWidget,
-            this.noteLanguageWidget);
-    }
-
-    get name() {
-        return "basicProperties";
-    }
-
-    get toggleCommand() {
-        return "toggleRibbonBasicProperties";
-    }
-
-    getTitle() {
-        return {
-            show: !this.note?.isLaunchBarConfig(),
-        };
-    }
-
-    doRender() {
-        this.$widget = $(TPL);
-        this.contentSized();
-
-        this.$widget.find(".note-type-container").append(this.noteTypeWidget.render());
-        this.$widget.find(".protected-note-switch-container").append(this.protectedNoteSwitchWidget.render());
-        this.$widget.find(".editability-select-container").append(this.editabilitySelectWidget.render());
-        this.$widget.find(".bookmark-switch-container").append(this.bookmarkSwitchWidget.render());
-        this.$widget.find(".shared-switch-container").append(this.sharedSwitchWidget.render());
-        this.$widget.find(".template-switch-container").append(this.templateSwitchWidget.render());
-        this.$widget.find(".").append(this.noteLanguageWidget.render());
-    }
-
-    async refreshWithNote(note: FNote) {
-        await super.refreshWithNote(note);
-        if (!this.note) {
-            return;
-        }
-
-        this.$widget.find(".editability-select-container").toggle(this.note && ["text", "code", "mermaid"].includes(this.note.type));
-        this.$widget.find(".note-language-container").toggle(this.note && ["text"].includes(this.note.type));
-    }
-}