ETAPI delete/patch, refactoring

src/etapi/branches.js

@@ -0,0 +1,78 @@
+const becca = require("../becca/becca.js");
+const ru = require("./route_utils");
+const mappers = require("./mappers");
+const Branch = require("../becca/entities/branch");
+const noteService = require("../services/notes");
+const TaskContext = require("../services/task_context");
+const entityChangesService = require("../services/entity_changes");
+const validators = require("./validators.js");
+
+function register(router) {
+    ru.route(router, 'get', '/etapi/branches/:branchId', (req, res, next) => {
+        const branch = ru.getAndCheckBranch(req.params.branchId);
+
+        res.json(mappers.mapBranchToPojo(branch));
+    });
+
+    ru.route(router, 'post' ,'/etapi/branches', (req, res, next) => {
+        const params = req.body;
+
+        ru.getAndCheckNote(params.noteId);
+        ru.getAndCheckNote(params.parentNoteId);
+
+        const existing = becca.getBranchFromChildAndParent(params.noteId, params.parentNoteId);
+
+        if (existing) {
+            existing.notePosition = params.notePosition;
+            existing.prefix = params.prefix;
+            existing.save();
+
+            return res.json(mappers.mapBranchToPojo(existing));
+        }
+
+        try {
+            const branch = new Branch(params).save();
+
+            res.json(mappers.mapBranchToPojo(branch));
+        }
+        catch (e) {
+            throw new ru.EtapiError(400, ru.GENERIC_CODE, e.message);
+        }
+    });
+
+    const ALLOWED_PROPERTIES_FOR_PATCH = {
+        'notePosition': validators.isInteger, 
+        'prefix': validators.isStringOrNull, 
+        'isExpanded': validators.isBoolean
+    };
+
+    ru.route(router, 'patch' ,'/etapi/branches/:branchId', (req, res, next) => {
+        const branch = ru.getAndCheckBranch(req.params.branchId);
+
+        ru.validateAndPatch(branch, req.body, ALLOWED_PROPERTIES_FOR_PATCH);
+
+        res.json(mappers.mapBranchToPojo(branch));
+    });
+
+    ru.route(router, 'delete' ,'/etapi/branches/:branchId', (req, res, next) => {
+        const branch = becca.getBranch(req.params.branchId);
+
+        if (!branch) {
+            return res.sendStatus(204);
+        }
+
+        noteService.deleteBranch(branch, null, new TaskContext('no-progress-reporting'));
+
+        res.sendStatus(204);
+    });
+
+    ru.route(router, 'post' ,'/etapi/refresh-note-ordering/:parentNoteId', (req, res, next) => {
+        ru.getAndCheckNote(req.params.parentNoteId);
+
+        entityChangesService.addNoteReorderingEntityChange(req.params.parentNoteId, "etapi");
+    });
+}
+
+module.exports = {
+    register
+};