use notePath instead of noteId for note creation to correctly work with cloned ancestors

This commit is contained in:
zadam
2021-03-03 22:48:06 +01:00
parent 8192b51b8a
commit 721e5da672
8 changed files with 25 additions and 21 deletions

View File

@@ -491,7 +491,7 @@ export default class AttributeEditorWidget extends TabAwareWidget {
}
async createNoteForReferenceLink(title) {
const {note} = await noteCreateService.createNote(this.noteId, {
const {note} = await noteCreateService.createNote(this.notePath, {
activate: false,
title: title
});

View File

@@ -26,7 +26,7 @@ class MobileDetailMenuWidget extends BasicWidget {
],
selectMenuItemHandler: async ({command}) => {
if (command === "insertChildNote") {
noteCreateService.createNote(note.noteId);
noteCreateService.createNote(appContext.tabManager.getActiveTabNotePath());
}
else if (command === "delete") {
const notePath = appContext.tabManager.getActiveTabNotePath();

View File

@@ -318,7 +318,7 @@ export default class NoteDetailWidget extends TabAwareWidget {
}
// without await as this otherwise causes deadlock through component mutex
noteCreateService.createNote(note.noteId, {
noteCreateService.createNote(appContext.tabManager.getActiveTabNotePath(), {
isProtected: note.isProtected,
saveSelection: true
});

View File

@@ -203,8 +203,9 @@ export default class NoteTreeWidget extends TabAwareWidget {
this.$tree.on("mousedown", ".refresh-search-button", e => this.refreshSearch(e));
this.$tree.on("mousedown", ".add-note-button", e => {
const node = $.ui.fancytree.getNode(e);
const parentNotePath = treeService.getNotePath(node);
noteCreateService.createNote(node.data.noteId, {
noteCreateService.createNote(parentNotePath, {
isProtected: node.data.isProtected
});
});

View File

@@ -274,7 +274,7 @@ export default class EditableTextTypeWidget extends AbstractTextTypeWidget {
}
async createNoteForReferenceLink(title) {
const {note} = await noteCreateService.createNote(this.noteId, {
const {note} = await noteCreateService.createNote(this.notePath, {
activate: false,
title: title
});