Dockery/Trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-11-06 21:36:05 +01:00
Code Issues Packages Projects Releases Activity

got rid of .renderTo(), tab caching widgets use hidden marker element

Browse Source
This commit is contained in:
zadam
2020-01-19 15:36:42 +01:00
parent 6de4914ea6
commit 416d733510
11 changed files with 59 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/public/javascripts/widgets/tab_caching_widget.js
View File

@@ -5,13 +5,12 @@ export default class TabCachingWidget extends TabAwareWidget {
super(appContext);
this.widgetFactory = widgetFactory;
/** @type {JQuery} */
this.$parent = null;
this.widgets = {};
}
renderTo($parent) {
this.$parent = $parent;
doRender() {
this.$widget = $(`<div class="marker" style="display: none;">`);
return this.$widget;
}
activeTabChangedListener() {
@@ -26,7 +25,7 @@ export default class TabCachingWidget extends TabAwareWidget {
if (!widget) {
widget = this.widgets[this.tabContext.tabId] = this.widgetFactory();
this.children.push(widget);
widget.renderTo(this.$parent);
this.$widget.after(widget.render());
widget.eventReceived('setTabContext', {tabContext: this.tabContext});
}