From 3bfb163a3998ce149d2d9e0583f64f2d643c9100 Mon Sep 17 00:00:00 2001
From: Elian Doran <contact@eliandoran.me>
Date: Sat, 21 Dec 2024 23:54:47 +0200
Subject: [PATCH] refactor(client/ts): use discriminated unions for triggering
 events

---
 src/public/app/components/app_context.ts | 26 +++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/src/public/app/components/app_context.ts b/src/public/app/components/app_context.ts
index b4c3bf0e2..79dc334da 100644
--- a/src/public/app/components/app_context.ts
+++ b/src/public/app/components/app_context.ts
@@ -100,7 +100,26 @@ type CommandMappings = {
     closeProtectedSessionPasswordDialog: NoData;
 }
 
+type EventMappings = {
+    initialRenderComplete: {};
+    frocaReloaded: {};
+    protectedSessionStarted: {};
+    notesReloaded: {
+        noteIds: string[];
+    };
+    refreshIncludedNote: {
+        noteId: string;
+    };
+    apiLogMessages: {
+        noteId: string;
+        messages: string[];
+    };
+}
+
+type CommandAndEventMappings = (CommandMappings & EventMappings);
+
 export type CommandNames = keyof CommandMappings;
+type EventNames = keyof EventMappings;
 
 class AppContext extends Component {
 
@@ -195,8 +214,9 @@ class AppContext extends Component {
         this.triggerEvent('initialRenderComplete');
     }
 
-    // TODO: Update signature once all client code is updated, to use a map similar to triggerCommand.
-    triggerEvent(name: string, data: unknown = {}) {
+    // TODO: Remove ignore once all commands are mapped out.
+    //@ts-ignore
+    triggerEvent<K extends EventNames | CommandNames>(name: K, data: CommandAndEventMappings[K] = {}) {
         return this.handleEvent(name, data);
     }
 
@@ -215,7 +235,7 @@ class AppContext extends Component {
         // in the component tree to communicate with each other
         console.debug(`Unhandled command ${name}, converting to event.`);
 
-        return this.triggerEvent(name, data);
+        return this.triggerEvent(name, data as CommandAndEventMappings[K]);
     }
 
     getComponentByEl(el: HTMLElement) {