Trilium/apps/client/src/widgets/react/FormCheckbox.tsx

import { Tooltip } from "bootstrap";
import { useEffect, useRef, useMemo, useCallback } from "preact/hooks";
import { escapeQuotes } from "../../services/utils";
import { ComponentChildren } from "preact";
import { memo } from "preact/compat";

interface FormCheckboxProps {
    name: string;
    label: string | ComponentChildren;
    /**
     * If set, the checkbox label will be underlined and dotted, indicating a hint. When hovered, it will show the hint text.
     */
    hint?: string;
    currentValue: boolean;
    disabled?: boolean;
    onChange(newValue: boolean): void;
}

const FormCheckbox = memo(({ name, disabled, label, currentValue, onChange, hint }: FormCheckboxProps) => {
    const labelRef = useRef<HTMLLabelElement>(null);

    // Fix: Move useEffect outside conditional
    useEffect(() => {
        if (!hint || !labelRef.current) return;
        
        const tooltipInstance = Tooltip.getOrCreateInstance(labelRef.current, {
            html: true,
            template: '<div class="tooltip tooltip-top" role="tooltip"><div class="arrow"></div><div class="tooltip-inner"></div></div>'
        });
        
        return () => tooltipInstance?.dispose();
    }, [hint]); // Proper dependency

    // Memoize style object
    const labelStyle = useMemo(() => 
        hint ? { textDecoration: "underline dotted var(--main-text-color)" } : undefined,
        [hint]
    );
    
    // Memoize onChange handler
    const handleChange = useCallback((e: Event) => {
        onChange((e.target as HTMLInputElement).checked);
    }, [onChange]);
    
    // Memoize title attribute
    const titleText = useMemo(() => hint ? escapeQuotes(hint) : undefined, [hint]);

    return (
        <div className="form-checkbox">
            <label
                className="form-check-label tn-checkbox"
                style={labelStyle}
                title={titleText}
                ref={labelRef}
            >
                <input
                    className="form-check-input"
                    type="checkbox"
                    name={name}
                    checked={currentValue || false}
                    value="1"
                    disabled={disabled}
                    onChange={handleChange} />
                {label}
            </label>
        </div>
    );
});

export default FormCheckbox;