From 0565d9985e4f4c62ccc96cf3de8de14062715041 Mon Sep 17 00:00:00 2001 From: winkidney Date: Mon, 25 Feb 2019 13:37:21 +0800 Subject: [PATCH] Refactor: Use thisPin instead this in pin-event binding --- pinry/static/js/pinry.js | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/pinry/static/js/pinry.js b/pinry/static/js/pinry.js index f6b35e9..d34d91c 100644 --- a/pinry/static/js/pinry.js +++ b/pinry/static/js/pinry.js @@ -51,30 +51,30 @@ $(window).load(function() { // Open add-to-board panel $('.glyphicon-heart').each(function() { var thisPin = $(this); - $(this).off('click'); - $(this).click(function() { - $(this).off('click'); - pinForm($(this).data('id')); + thisPin.off('click'); + thisPin.click(function() { + thisPin.off('click'); + pinForm($(thisPin).data('id')); }); }); // Edit pin if pencil icon clicked $('.glyphicon-pencil').each(function() { var thisPin = $(this); - $(this).off('click'); - $(this).click(function() { - $(this).off('click'); - pinForm($(this).data('id')); + thisPin.off('click'); + thisPin.click(function() { + thisPin.off('click'); + pinForm(thisPin.data('id')); }); }); // Delete pin if trash icon clicked $('.glyphicon-trash').each(function() { var thisPin = $(this); - $(this).off('click'); - $(this).click(function() { - $(this).off('click'); - var promise = deletePinData($(this).data('id')); + thisPin.off('click'); + thisPin.click(function() { + thisPin.off('click'); + var promise = deletePinData(thisPin.data('id')); promise.success(function() { thisPin.closest('.pin').remove(); tileLayout();