mirror of
https://github.com/ajnart/homarr.git
synced 2026-02-28 01:10:54 +01:00
* wip: add provider field to sqlite user table * feat: disable invites when credentials provider is not used * wip: add migration for provider field in user table with sqlite * wip: remove fields that can not be modified by non credential users * wip: make username, mail and avatar disabled instead of hidden * wip: external users membership of group cannot be managed manually * feat: add alerts to inform about disabled fields and managing group members * wip: add mysql migration for provider on user table * chore: fix format issues * chore: address pull request feedback * fix: build issue * fix: deepsource issues * fix: tests not working * feat: restrict login to specific auth providers * chore: address pull request feedback * fix: deepsource issue
260 lines
7.2 KiB
TypeScript
260 lines
7.2 KiB
TypeScript
import { CredentialsSignin } from "@auth/core/errors";
|
|
import { describe, expect, test, vi } from "vitest";
|
|
|
|
import type { Database } from "@homarr/db";
|
|
import { and, createId, eq } from "@homarr/db";
|
|
import { users } from "@homarr/db/schema/sqlite";
|
|
import { createDb } from "@homarr/db/test";
|
|
|
|
import { createSaltAsync, hashPasswordAsync } from "../../security";
|
|
import { authorizeWithLdapCredentialsAsync } from "../credentials/authorization/ldap-authorization";
|
|
import * as ldapClient from "../credentials/ldap-client";
|
|
|
|
vi.mock("../../env.mjs", () => ({
|
|
env: {
|
|
AUTH_LDAP_BIND_DN: "bind_dn",
|
|
AUTH_LDAP_BIND_PASSWORD: "bind_password",
|
|
AUTH_LDAP_USER_MAIL_ATTRIBUTE: "mail",
|
|
},
|
|
}));
|
|
|
|
describe("authorizeWithLdapCredentials", () => {
|
|
test("should fail when wrong ldap base credentials", async () => {
|
|
// Arrange
|
|
const spy = vi.spyOn(ldapClient, "LdapClient");
|
|
spy.mockImplementation(
|
|
() =>
|
|
({
|
|
bindAsync: vi.fn(() => Promise.reject(new Error("bindAsync"))),
|
|
}) as unknown as ldapClient.LdapClient,
|
|
);
|
|
|
|
// Act
|
|
const act = () =>
|
|
authorizeWithLdapCredentialsAsync(null as unknown as Database, {
|
|
name: "test",
|
|
password: "test",
|
|
credentialType: "ldap",
|
|
});
|
|
|
|
// Assert
|
|
await expect(act()).rejects.toThrow(CredentialsSignin);
|
|
});
|
|
|
|
test("should fail when user not found", async () => {
|
|
// Arrange
|
|
const spy = vi.spyOn(ldapClient, "LdapClient");
|
|
spy.mockImplementation(
|
|
() =>
|
|
({
|
|
bindAsync: vi.fn(() => Promise.resolve()),
|
|
searchAsync: vi.fn(() => Promise.resolve([])),
|
|
}) as unknown as ldapClient.LdapClient,
|
|
);
|
|
|
|
// Act
|
|
const act = () =>
|
|
authorizeWithLdapCredentialsAsync(null as unknown as Database, {
|
|
name: "test",
|
|
password: "test",
|
|
credentialType: "ldap",
|
|
});
|
|
|
|
// Assert
|
|
await expect(act()).rejects.toThrow(CredentialsSignin);
|
|
});
|
|
|
|
test("should fail when user has invalid email", async () => {
|
|
// Arrange
|
|
const spy = vi.spyOn(ldapClient, "LdapClient");
|
|
spy.mockImplementation(
|
|
() =>
|
|
({
|
|
bindAsync: vi.fn(() => Promise.resolve()),
|
|
searchAsync: vi.fn(() =>
|
|
Promise.resolve([
|
|
{
|
|
dn: "test",
|
|
mail: "test",
|
|
},
|
|
]),
|
|
),
|
|
}) as unknown as ldapClient.LdapClient,
|
|
);
|
|
|
|
// Act
|
|
const act = () =>
|
|
authorizeWithLdapCredentialsAsync(null as unknown as Database, {
|
|
name: "test",
|
|
password: "test",
|
|
credentialType: "ldap",
|
|
});
|
|
|
|
// Assert
|
|
await expect(act()).rejects.toThrow(CredentialsSignin);
|
|
});
|
|
|
|
test("should fail when user password is incorrect", async () => {
|
|
// Arrange
|
|
const searchSpy = vi.fn(() =>
|
|
Promise.resolve([
|
|
{
|
|
dn: "test",
|
|
mail: "test@gmail.com",
|
|
},
|
|
]),
|
|
);
|
|
const spy = vi.spyOn(ldapClient, "LdapClient");
|
|
spy.mockImplementation(
|
|
() =>
|
|
({
|
|
bindAsync: vi.fn((props: ldapClient.BindOptions) =>
|
|
props.distinguishedName === "test" ? Promise.reject(new Error("bindAsync")) : Promise.resolve(),
|
|
),
|
|
searchAsync: searchSpy,
|
|
}) as unknown as ldapClient.LdapClient,
|
|
);
|
|
|
|
// Act
|
|
const act = () =>
|
|
authorizeWithLdapCredentialsAsync(null as unknown as Database, {
|
|
name: "test",
|
|
password: "test",
|
|
credentialType: "ldap",
|
|
});
|
|
|
|
// Assert
|
|
await expect(act()).rejects.toThrow(CredentialsSignin);
|
|
expect(searchSpy).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
test("should authorize user with correct credentials and create user", async () => {
|
|
// Arrange
|
|
const db = createDb();
|
|
const spy = vi.spyOn(ldapClient, "LdapClient");
|
|
spy.mockImplementation(
|
|
() =>
|
|
({
|
|
bindAsync: vi.fn(() => Promise.resolve()),
|
|
searchAsync: vi.fn(() =>
|
|
Promise.resolve([
|
|
{
|
|
dn: "test",
|
|
mail: "test@gmail.com",
|
|
},
|
|
]),
|
|
),
|
|
disconnectAsync: vi.fn(),
|
|
}) as unknown as ldapClient.LdapClient,
|
|
);
|
|
|
|
// Act
|
|
const result = await authorizeWithLdapCredentialsAsync(db, {
|
|
name: "test",
|
|
password: "test",
|
|
credentialType: "ldap",
|
|
});
|
|
|
|
// Assert
|
|
expect(result.name).toBe("test");
|
|
const dbUser = await db.query.users.findFirst({
|
|
where: eq(users.name, "test"),
|
|
});
|
|
expect(dbUser).toBeDefined();
|
|
expect(dbUser?.id).toBe(result.id);
|
|
expect(dbUser?.email).toBe("test@gmail.com");
|
|
expect(dbUser?.emailVerified).not.toBeNull();
|
|
expect(dbUser?.provider).toBe("ldap");
|
|
});
|
|
|
|
test("should authorize user with correct credentials and create user with same email when credentials user already exists", async () => {
|
|
// Arrange
|
|
const db = createDb();
|
|
const spy = vi.spyOn(ldapClient, "LdapClient");
|
|
const salt = await createSaltAsync();
|
|
spy.mockImplementation(
|
|
() =>
|
|
({
|
|
bindAsync: vi.fn(() => Promise.resolve()),
|
|
searchAsync: vi.fn(() =>
|
|
Promise.resolve([
|
|
{
|
|
dn: "test",
|
|
mail: "test@gmail.com",
|
|
},
|
|
]),
|
|
),
|
|
disconnectAsync: vi.fn(),
|
|
}) as unknown as ldapClient.LdapClient,
|
|
);
|
|
await db.insert(users).values({
|
|
id: createId(),
|
|
name: "test",
|
|
salt,
|
|
password: await hashPasswordAsync("test", salt),
|
|
email: "test@gmail.com",
|
|
provider: "credentials",
|
|
});
|
|
|
|
// Act
|
|
const result = await authorizeWithLdapCredentialsAsync(db, {
|
|
name: "test",
|
|
password: "test",
|
|
credentialType: "ldap",
|
|
});
|
|
|
|
// Assert
|
|
expect(result.name).toBe("test");
|
|
const dbUser = await db.query.users.findFirst({
|
|
where: and(eq(users.name, "test"), eq(users.provider, "ldap")),
|
|
});
|
|
expect(dbUser).toBeDefined();
|
|
expect(dbUser?.id).toBe(result.id);
|
|
expect(dbUser?.email).toBe("test@gmail.com");
|
|
expect(dbUser?.emailVerified).not.toBeNull();
|
|
expect(dbUser?.provider).toBe("ldap");
|
|
|
|
const credentialsUser = await db.query.users.findFirst({
|
|
where: and(eq(users.name, "test"), eq(users.provider, "credentials")),
|
|
});
|
|
|
|
expect(credentialsUser).toBeDefined();
|
|
expect(credentialsUser?.id).not.toBe(result.id);
|
|
});
|
|
|
|
test("should authorize user with correct credentials and update name", async () => {
|
|
// Arrange
|
|
const userId = createId();
|
|
const db = createDb();
|
|
const salt = await createSaltAsync();
|
|
await db.insert(users).values({
|
|
id: userId,
|
|
name: "test-old",
|
|
salt,
|
|
password: await hashPasswordAsync("test", salt),
|
|
email: "test@gmail.com",
|
|
provider: "ldap",
|
|
});
|
|
|
|
// Act
|
|
const result = await authorizeWithLdapCredentialsAsync(db, {
|
|
name: "test",
|
|
password: "test",
|
|
credentialType: "ldap",
|
|
});
|
|
|
|
// Assert
|
|
expect(result).toEqual({ id: userId, name: "test" });
|
|
|
|
const dbUser = await db.query.users.findFirst({
|
|
where: eq(users.id, userId),
|
|
});
|
|
|
|
expect(dbUser).toBeDefined();
|
|
expect(dbUser?.id).toBe(userId);
|
|
expect(dbUser?.name).toBe("test");
|
|
expect(dbUser?.email).toBe("test@gmail.com");
|
|
expect(dbUser?.provider).toBe("ldap");
|
|
});
|
|
});
|