From 4970c3a1b2545feb3bc20cc6605f8f16a28a8220 Mon Sep 17 00:00:00 2001
From: Meier Lukas <meierschlumpf@gmail.com>
Date: Sat, 20 Apr 2024 12:52:02 +0200
Subject: [PATCH] fix: defaultTitle invalid attribute on div (#350)

---
 packages/modals/src/index.tsx | 50 +++++++++++++++++++----------------
 1 file changed, 27 insertions(+), 23 deletions(-)

diff --git a/packages/modals/src/index.tsx b/packages/modals/src/index.tsx
index 155af31b5..01b476082 100644
--- a/packages/modals/src/index.tsx
+++ b/packages/modals/src/index.tsx
@@ -80,29 +80,33 @@ export const ModalProvider = ({ children }: PropsWithChildren) => {
 
   return (
     <ModalContext.Provider value={{ openModalInner, closeModal }}>
-      {activeModals.map((modal) => (
-        <Modal
-          key={modal.id}
-          zIndex={getDefaultZIndex("modal") + 1}
-          display={modal.id === state.current?.id ? undefined : "none"}
-          style={{
-            userSelect: modal.id === state.current?.id ? undefined : "none",
-          }}
-          styles={{
-            title: {
-              fontSize: "1.25rem",
-              fontWeight: 500,
-            },
-          }}
-          trapFocus={modal.id === state.current?.id}
-          {...modal.reference.modalProps}
-          title={translateIfNecessary(t, modal.props.defaultTitle)}
-          opened={state.modals.length > 0}
-          onClose={handleCloseModal}
-        >
-          {modal.reference.content}
-        </Modal>
-      ))}
+      {activeModals.map((modal) => {
+        const { defaultTitle: _ignored, ...otherModalProps } =
+          modal.reference.modalProps;
+        return (
+          <Modal
+            key={modal.id}
+            zIndex={getDefaultZIndex("modal") + 1}
+            display={modal.id === state.current?.id ? undefined : "none"}
+            style={{
+              userSelect: modal.id === state.current?.id ? undefined : "none",
+            }}
+            styles={{
+              title: {
+                fontSize: "1.25rem",
+                fontWeight: 500,
+              },
+            }}
+            trapFocus={modal.id === state.current?.id}
+            {...otherModalProps}
+            title={translateIfNecessary(t, modal.props.defaultTitle)}
+            opened={state.modals.length > 0}
+            onClose={handleCloseModal}
+          >
+            {modal.reference.content}
+          </Modal>
+        );
+      })}
 
       {children}
     </ModalContext.Provider>