From 452308336a2cde0eca8875993ed2489ce5af9eec Mon Sep 17 00:00:00 2001
From: Manuel <30572287+manuel-rw@users.noreply.github.com>
Date: Sat, 1 Jun 2024 22:04:42 +0200
Subject: [PATCH] refactor: clean up workflows (#596)

---
 .github/workflows/build.yml                   | 31 -------------------
 .github/workflows/code-quality.yml            | 16 ++++++++--
 ...s.yml => conventions-semantic-commits.yml} |  4 +--
 ...=> conventions-semantic-pull-requests.yml} |  5 ++-
 ...-image.yml => deployment-docker-image.yml} |  4 +--
 ...ease.yml => deployment-weekly-release.yml} |  2 ++
 .../workflows/renovate-automatic-approval.yml |  2 +-
 7 files changed, 22 insertions(+), 42 deletions(-)
 delete mode 100644 .github/workflows/build.yml
 rename .github/workflows/{conventional-commits.yml => conventions-semantic-commits.yml} (88%)
 rename .github/workflows/{pr-conventional-commits.yml => conventions-semantic-pull-requests.yml} (81%)
 rename .github/workflows/{docker-image.yml => deployment-docker-image.yml} (96%)
 rename .github/workflows/{automatic-release.yml => deployment-weekly-release.yml} (98%)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
deleted file mode 100644
index b8fbfaa9d..000000000
--- a/.github/workflows/build.yml
+++ /dev/null
@@ -1,31 +0,0 @@
-name: Build apps and migration script
-
-on:
-  pull_request:
-    branches: ["*"]
-  push:
-    branches: ["main"]
-  merge_group:
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}
-
-env:
-  FORCE_COLOR: 3
-
-jobs:
-  build:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Setup
-        uses: ./tooling/github/setup
-
-      - name: Copy env
-        shell: bash
-        run: cp .env.example .env
-
-      - name: Build
-        run: pnpm build
diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml
index 228dd9989..a75c144b7 100644
--- a/.github/workflows/code-quality.yml
+++ b/.github/workflows/code-quality.yml
@@ -1,4 +1,4 @@
-name: Code quality analysis
+name: "[Quality] Code Analysis"
 
 on:
   pull_request:
@@ -8,7 +8,7 @@ on:
   merge_group:
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
+  group: "${{ github.workflow }}-${{ github.ref }}"
   cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}
 
 # You can leverage Vercel Remote Caching with Turbo to speed up your builds
@@ -72,3 +72,15 @@ jobs:
         # Only works if you set `reportOnFailure: true` in your vite config as specified above
         if: always() 
         uses:  davelosert/vitest-coverage-report-action@v2
+
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Setup
+        uses: ./tooling/github/setup
+      - name: Copy env
+        shell: bash
+        run: cp .env.example .env
+      - name: Build
+        run: pnpm build
diff --git a/.github/workflows/conventional-commits.yml b/.github/workflows/conventions-semantic-commits.yml
similarity index 88%
rename from .github/workflows/conventional-commits.yml
rename to .github/workflows/conventions-semantic-commits.yml
index 00d14191a..d26307ba0 100644
--- a/.github/workflows/conventional-commits.yml
+++ b/.github/workflows/conventions-semantic-commits.yml
@@ -1,7 +1,5 @@
-
 # https://github.com/webiny/action-conventional-commits?tab=readme-ov-file
-
-name: Conventional Commits
+name: "[Conventions] Semantic Commits"
 
 on:
   pull_request:
diff --git a/.github/workflows/pr-conventional-commits.yml b/.github/workflows/conventions-semantic-pull-requests.yml
similarity index 81%
rename from .github/workflows/pr-conventional-commits.yml
rename to .github/workflows/conventions-semantic-pull-requests.yml
index e3dfb587b..cec459930 100644
--- a/.github/workflows/pr-conventional-commits.yml
+++ b/.github/workflows/conventions-semantic-pull-requests.yml
@@ -1,4 +1,4 @@
-name: "Lint PR"
+name: "[Conventions] Semantic PRs"
 
 on:
   pull_request_target:
@@ -11,8 +11,7 @@ permissions:
   pull-requests: read
 
 jobs:
-  main:
-    name: Validate PR title
+  validate-pull-request-title:
     runs-on: ubuntu-latest
     steps:
       - uses: amannn/action-semantic-pull-request@v5
diff --git a/.github/workflows/docker-image.yml b/.github/workflows/deployment-docker-image.yml
similarity index 96%
rename from .github/workflows/docker-image.yml
rename to .github/workflows/deployment-docker-image.yml
index 046523358..539b0ebb2 100644
--- a/.github/workflows/docker-image.yml
+++ b/.github/workflows/deployment-docker-image.yml
@@ -1,4 +1,4 @@
-name: Docker image
+name: "[Deployment] Release"
 
 on:
   pull_request:
@@ -70,7 +70,7 @@ jobs:
         id: meta
         uses: docker/metadata-action@v5
         with:
-          images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
+          images: "${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}"
           tags: |
             type=raw,value=latest
             type=raw,value=${{ steps.semver.outputs.next }}
diff --git a/.github/workflows/automatic-release.yml b/.github/workflows/deployment-weekly-release.yml
similarity index 98%
rename from .github/workflows/automatic-release.yml
rename to .github/workflows/deployment-weekly-release.yml
index 99c644f65..acfd46aab 100644
--- a/.github/workflows/automatic-release.yml
+++ b/.github/workflows/deployment-weekly-release.yml
@@ -1,3 +1,5 @@
+name: "[Deployment] Automatic Weekly Release"
+
 on:
   schedule:
     - cron: "0 19 * * 5" # https://crontab.guru/#0_19_*_*_5
diff --git a/.github/workflows/renovate-automatic-approval.yml b/.github/workflows/renovate-automatic-approval.yml
index b9334bf69..5ebb99b72 100644
--- a/.github/workflows/renovate-automatic-approval.yml
+++ b/.github/workflows/renovate-automatic-approval.yml
@@ -1,4 +1,4 @@
-name: Approve Renovate PRs
+name: "[Dependency Updates] Auto Approve"
 on:
   pull_request:
     types: [opened, synchronize]