From b2cbb1a3885fd3ce8efd5ccd661d9e2b45af16b3 Mon Sep 17 00:00:00 2001 From: Manuel Date: Sat, 12 Aug 2023 23:23:04 +0200 Subject: [PATCH 1/2] fix: allow note only in edit mode --- src/server/api/routers/notebook.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/server/api/routers/notebook.ts b/src/server/api/routers/notebook.ts index c0df1beb1..d7eb065cb 100644 --- a/src/server/api/routers/notebook.ts +++ b/src/server/api/routers/notebook.ts @@ -12,13 +12,20 @@ export const notebookRouter = createTRPCRouter({ update: publicProcedure .input(z.object({ widgetId: z.string(), content: z.string(), configName: z.string() })) .mutation(async ({ input }) => { + if (!process.env.DISABLE_EDIT_MODE) { + throw new TRPCError({ + code: 'METHOD_NOT_SUPPORTED', + message: 'Edit is not allowed, because edit mode is disabled' + }); + } + const config = getConfig(input.configName); const widget = config.widgets.find((widget) => widget.id === input.widgetId) as | INotebookWidget | undefined; if (!widget) { - return new TRPCError({ + throw new TRPCError({ code: 'BAD_REQUEST', message: 'Specified widget was not found', }); From a98630e2c4851db9b7b08699f840f576b039a5ac Mon Sep 17 00:00:00 2001 From: ajnart Date: Mon, 21 Aug 2023 18:01:58 +0200 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=92=A1=20Add=20comment=20about=20envi?= =?UTF-8?q?ron?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/server/api/routers/notebook.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/server/api/routers/notebook.ts b/src/server/api/routers/notebook.ts index d7eb065cb..057c64031 100644 --- a/src/server/api/routers/notebook.ts +++ b/src/server/api/routers/notebook.ts @@ -12,6 +12,7 @@ export const notebookRouter = createTRPCRouter({ update: publicProcedure .input(z.object({ widgetId: z.string(), content: z.string(), configName: z.string() })) .mutation(async ({ input }) => { + //TODO: #1305 Remove use of DISABLE_EDIT_MODE for auth update if (!process.env.DISABLE_EDIT_MODE) { throw new TRPCError({ code: 'METHOD_NOT_SUPPORTED',