🐛 Remove DISABLE_EDIT_MODE and replace with admin-procedure (#1439)

This commit is contained in:
Meier Lukas
2023-09-30 00:30:55 +02:00
committed by GitHub
parent 6c43a19fa1
commit 32e40f3342
2 changed files with 3 additions and 17 deletions

View File

@@ -5,12 +5,12 @@ import fs from 'fs';
import path from 'path'; import path from 'path';
import { z } from 'zod'; import { z } from 'zod';
import { configExists } from '~/tools/config/configExists'; import { configExists } from '~/tools/config/configExists';
import { getConfig } from '~/tools/config/getConfig';
import { getFrontendConfig } from '~/tools/config/getFrontendConfig'; import { getFrontendConfig } from '~/tools/config/getFrontendConfig';
import { BackendConfigType, ConfigType } from '~/types/config'; import { BackendConfigType, ConfigType } from '~/types/config';
import { boardCustomizationSchema } from '~/validations/boards'; import { boardCustomizationSchema } from '~/validations/boards';
import { IRssWidget } from '~/widgets/rss/RssWidgetTile'; import { IRssWidget } from '~/widgets/rss/RssWidgetTile';
import { getConfig } from '~/tools/config/getConfig';
import { adminProcedure, createTRPCRouter, publicProcedure } from '../trpc'; import { adminProcedure, createTRPCRouter, publicProcedure } from '../trpc';
export const configNameSchema = z.string().regex(/^[a-zA-Z0-9-_]+$/); export const configNameSchema = z.string().regex(/^[a-zA-Z0-9-_]+$/);
@@ -67,12 +67,6 @@ export const configRouter = createTRPCRouter({
}) })
) )
.mutation(async ({ input }) => { .mutation(async ({ input }) => {
if (process.env.DISABLE_EDIT_MODE?.toLowerCase() === 'true') {
throw new TRPCError({
code: 'METHOD_NOT_SUPPORTED',
message: 'Edit is not allowed, because edit mode is disabled'
});
}
Consola.info(`Saving updated configuration of '${input.name}' config.`); Consola.info(`Saving updated configuration of '${input.name}' config.`);
const previousConfig = getConfig(input.name); const previousConfig = getConfig(input.name);

View File

@@ -6,20 +6,12 @@ import { getConfig } from '~/tools/config/getConfig';
import { BackendConfigType } from '~/types/config'; import { BackendConfigType } from '~/types/config';
import { INotebookWidget } from '~/widgets/notebook/NotebookWidgetTile'; import { INotebookWidget } from '~/widgets/notebook/NotebookWidgetTile';
import { createTRPCRouter, publicProcedure } from '../trpc'; import { adminProcedure, createTRPCRouter, publicProcedure } from '../trpc';
export const notebookRouter = createTRPCRouter({ export const notebookRouter = createTRPCRouter({
update: publicProcedure update: adminProcedure
.input(z.object({ widgetId: z.string(), content: z.string(), configName: z.string() })) .input(z.object({ widgetId: z.string(), content: z.string(), configName: z.string() }))
.mutation(async ({ input }) => { .mutation(async ({ input }) => {
//TODO: #1305 Remove use of DISABLE_EDIT_MODE for auth update
if (process.env.DISABLE_EDIT_MODE?.toLowerCase() === 'true') {
throw new TRPCError({
code: 'METHOD_NOT_SUPPORTED',
message: 'Edit is not allowed, because edit mode is disabled'
});
}
const config = getConfig(input.configName); const config = getConfig(input.configName);
const widget = config.widgets.find((widget) => widget.id === input.widgetId) as const widget = config.widgets.find((widget) => widget.id === input.widgetId) as
| INotebookWidget | INotebookWidget