From 051f439434e9c152c5d74f8131a8fd21b9048454 Mon Sep 17 00:00:00 2001 From: ajnart Date: Wed, 15 May 2024 21:33:25 +0200 Subject: [PATCH 1/3] Add `key` for custom favicon --- src/components/layout/Meta/BoardHeadOverride.tsx | 3 +-- src/components/layout/Meta/CommonHead.tsx | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/components/layout/Meta/BoardHeadOverride.tsx b/src/components/layout/Meta/BoardHeadOverride.tsx index cc9728360..72d34e137 100644 --- a/src/components/layout/Meta/BoardHeadOverride.tsx +++ b/src/components/layout/Meta/BoardHeadOverride.tsx @@ -1,5 +1,4 @@ import Head from 'next/head'; -import React from 'react'; import { useConfigContext } from '~/config/provider'; import { firstUpperCase } from '~/tools/shared/strings'; @@ -15,7 +14,7 @@ export const BoardHeadOverride = () => { return ( {title} - + {faviconUrl && faviconUrl.length > 0 && ( <> diff --git a/src/components/layout/Meta/CommonHead.tsx b/src/components/layout/Meta/CommonHead.tsx index 30341c6f3..465c5a28b 100644 --- a/src/components/layout/Meta/CommonHead.tsx +++ b/src/components/layout/Meta/CommonHead.tsx @@ -7,7 +7,7 @@ export const CommonHead = () => { return ( - + From 5043b9cd3095e822c2defb9c716b6b7c2e969f88 Mon Sep 17 00:00:00 2001 From: ajnart Date: Wed, 15 May 2024 22:07:27 +0200 Subject: [PATCH 2/3] Refactor favicon links in Meta components --- src/components/layout/Meta/BoardHeadOverride.tsx | 6 +++--- src/components/layout/Meta/CommonHead.tsx | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/layout/Meta/BoardHeadOverride.tsx b/src/components/layout/Meta/BoardHeadOverride.tsx index 72d34e137..f62c15405 100644 --- a/src/components/layout/Meta/BoardHeadOverride.tsx +++ b/src/components/layout/Meta/BoardHeadOverride.tsx @@ -14,13 +14,13 @@ export const BoardHeadOverride = () => { return ( {title} - + {faviconUrl && faviconUrl.length > 0 && ( <> - + - + )} diff --git a/src/components/layout/Meta/CommonHead.tsx b/src/components/layout/Meta/CommonHead.tsx index 465c5a28b..55df63e83 100644 --- a/src/components/layout/Meta/CommonHead.tsx +++ b/src/components/layout/Meta/CommonHead.tsx @@ -12,7 +12,7 @@ export const CommonHead = () => { {/* configure apple splash screen & touch icon */} - + From 84f57bb0a12efd1cc383b76aadc0b67940ee79dc Mon Sep 17 00:00:00 2001 From: ajnart Date: Wed, 15 May 2024 22:16:00 +0200 Subject: [PATCH 3/3] chore: add test:docker script for local development --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 255df001d..00cbd6d8d 100644 --- a/package.json +++ b/package.json @@ -19,6 +19,7 @@ "prettier:check": "prettier --check \"**/*.{ts,tsx}\"", "prettier:write": "prettier --write \"**/*.{ts,tsx}\"", "test": "SKIP_ENV_VALIDATION=1 vitest", + "test:docker": "yarn run turbo build && yarn test:run && docker build . -t homarr:local-dev && docker run -p 7575:7575 --name homarr-dev homarr:local-dev", "test:ui": "SKIP_ENV_VALIDATION=1 vitest --ui", "test:run": "SKIP_ENV_VALIDATION=1 vitest run", "test:coverage": "SKIP_ENV_VALIDATION=1 vitest run --coverage", @@ -241,4 +242,4 @@ ] } } -} \ No newline at end of file +}